Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #15746: Don't set active topic to 'ALL' in contributor dashboard page. #15841

Merged
merged 9 commits into from Aug 15, 2022
Merged

Fix #15746: Don't set active topic to 'ALL' in contributor dashboard page. #15841

merged 9 commits into from Aug 15, 2022

Conversation

sagangwee
Copy link
Contributor

@sagangwee sagangwee commented Aug 3, 2022 •
edited by vojtechjelinek

Overview

  1. This PR fixes user not able to review translations in contributor-dashboard page #15746.
  2. This PR does the following: We should not be setting the active topic to 'ALL' until Re-enable "All Topics" in topic selector after fixing reviewable lessons latency #15710 is fixed. This bug was causing console errors when the topic selector would default to 'ALL' before the user selects a topic option. Now, the topic selector defaults to the first topic in the list (published classroom topics).

Essential Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The linter/Karma presubmit checks have passed locally on your machine.
  • "Allow edits from maintainers" is checked. (See here for instructions on how to enable it.)
    • This lets reviewers restart your CircleCI tests for you.
  • The PR is made from a branch that's not called "develop".

Proof that changes are correct

Screen Shot 2022-08-03 at 4 33 43 PM

PR Pointers

  • Make sure to follow the instructions for making a code change.
  • If you need a review or an answer to a question, and don't have permissions to assign people, leave a comment like the following: "{{Question/comment}} @{{reviewer_username}} PTAL". Oppiabot will help assign that person for you.
  • For what code owners will expect, see the Code Owner's wiki page.
  • Make sure your PR follows conventions in the style guide, otherwise this will lead to review delays.
  • Never force push. If you do, your PR will be closed.
  • Some of the e2e tests are flaky, and can fail for reasons unrelated to your PR. We are working on fixing this, but in the meantime, if you need to restart the tests, please check the "If your build fails" wiki page.

@sagangwee sagangwee requested a review from a team as a code owner August 3, 2022 20:37
@oppiabot
Copy link

oppiabot bot commented Aug 3, 2022

Hi @sagangwee, can you complete the following:

  1. The karma and linter checklist has not been checked, please make sure to run the frontend tests and lint tests before pushing.
    Thanks!

@oppiabot
Copy link

oppiabot bot commented Aug 3, 2022

Hi @DubeySandeep, could you please add the appropriate changelog label to this pull request? Thanks!

@sagangwee sagangwee assigned seanlip and unassigned sagangwee and DubeySandeep Aug 3, 2022
@sagangwee
Copy link
Contributor Author

@seanlip Could take a look at this? Thanks!

seanlip
seanlip approved these changes Aug 3, 2022
View reviewed changes
Copy link
Member

@seanlip seanlip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.

Just a question though. Where is the logic for "defaults to the first topic in the list"? Shouldn't we be initializing this.topicName somehow?

@seanlip seanlip assigned sagangwee and unassigned seanlip Aug 3, 2022
@sagangwee sagangwee requested review from a team and gp201 August 5, 2022 17:27
@sagangwee
Copy link
Contributor Author

The HTML select list defaults to the first item in the topic list, but I've also explicitly set the active topic name to the first topic in the list.

@seanlip
Copy link
Member

seanlip commented Aug 5, 2022

Sg, thanks!

@seanlip
Copy link
Member

seanlip commented Aug 5, 2022

FYI Karma tests are failing.

@oppiabot oppiabot bot added the PR: don't merge - STALE BUILD The build on this PR is stale and should be restarted. label Aug 8, 2022
@oppiabot
Copy link

oppiabot bot commented Aug 8, 2022

Hi @sagangwee, the build of this PR is stale and this could result in tests failing in develop. Please update this pull request with the latest changes from develop. Thanks!

@oppiabot oppiabot bot removed the PR: don't merge - STALE BUILD The build on this PR is stale and should be restarted. label Aug 8, 2022
@sagangwee sagangwee assigned gp201 and unassigned sagangwee Aug 8, 2022
@sagangwee
Copy link
Contributor Author

@gp201 PTAL, thanks!

@oppiabot
Copy link

oppiabot bot commented Aug 8, 2022

Hi @sagangwee, there is a new change in develop which needs to be in your PR. Please update your branch with the latest changes in develop. For instructions, refer to this link. Thanks!

@sagangwee sagangwee removed their assignment Aug 8, 2022
gp201
gp201 approved these changes Aug 9, 2022
View reviewed changes
Copy link
Member

@gp201 gp201 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gp201 gp201 assigned sagangwee and unassigned gp201 Aug 9, 2022
@oppiabot
Copy link

oppiabot bot commented Aug 10, 2022

Hi @sagangwee, there is a new change in develop which needs to be in your PR. Please update your branch with the latest changes in develop. For instructions, refer to this link. Thanks!

@oppiabot oppiabot bot added the PR: don't merge - STALE BUILD The build on this PR is stale and should be restarted. label Aug 12, 2022
@oppiabot
Copy link

oppiabot bot commented Aug 12, 2022

Hi @sagangwee, the build of this PR is stale and this could result in tests failing in develop. Please update this pull request with the latest changes from develop. Thanks!

@oppiabot oppiabot bot removed the PR: don't merge - STALE BUILD The build on this PR is stale and should be restarted. label Aug 12, 2022
@oppiabot
Copy link

oppiabot bot commented Aug 14, 2022

Hi @sagangwee, there is a new change in develop which needs to be in your PR. Please update your branch with the latest changes in develop. For instructions, refer to this link. Thanks!

@vojtechjelinek
Copy link
Member

@sagangwee Any update here?

@sagangwee
Copy link
Contributor Author

@vojtechjelinek I've been trying to merge this PR for a few days now, but there are a couple of E2E flaky tests that are blocking. Same issue with #15851. Related to the ExplorationEditorMainTab.setContent() flakes.

@sagangwee sagangwee merged commit 2efbbd4 into oppia:develop Aug 15, 2022
kevintab95 pushed a commit that referenced this pull request Sep 3, 2022
@sagangwee @kevintab95
Fix #15746: Don't set active topic to 'ALL' in contributor dashboard …
1d8077a 
…page. (#15841)

* Don't set ALL topics

* default to first topic

* fix coverage

* Remove fdescribe

* fix lint
@gp201 gp201 mentioned this pull request Nov 12, 2022
Closed
@U8NWXD
Copy link
Member

U8NWXD commented Nov 23, 2022

@sagangwee this PR appears to have introduced a flake into the frontend tests (see #16529). Can you please investigate? @gp201 has suggested a fix, so I think we can fix this forward instead of reverting

@U8NWXD
Copy link
Member

U8NWXD commented Dec 5, 2022

@sagangwee have you looked into this yet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanlip seanlip seanlip approved these changes

@gp201 gp201 gp201 approved these changes

Assignees

@sagangwee sagangwee

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

user not able to review translations in contributor-dashboard page
7 participants
@sagangwee @seanlip @vojtechjelinek @U8NWXD @gp201 @kevintab95 @DubeySandeep