Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Chromevox focus is not going to the checkbox in misconception dialogbox #17080

Closed
KolliAnitha opened this issue Jan 20, 2023 · 15 comments · Fixed by #18427
Closed

[BUG]: Chromevox focus is not going to the checkbox in misconception dialogbox #17080

KolliAnitha opened this issue Jan 20, 2023 · 15 comments · Fixed by #18427
Assignees
Labels
a11y bug Label to indicate an issue is a regression good first issue Impact: Low -- DO NOT WORK ON THIS YET Postponing for now, since it doesn't affect users much. Work: Low Solution is known and broken into good-first-issue-sized chunks.

Comments

@KolliAnitha
Copy link

Describe the bug

Chromevox focus is not going to the checkbox in misconception dialogbox

Steps To Reproduce

  1. Login to www.oppiatestserver.org
    Go to Contributor dashboard
    Click on Submit question tab
    Click on Suggest question for any topic
    Enable chromevox
    Select difficulty level- Click on Continue- Type your question here
    Add interaction as Fraction input- Add Response
    Click on Tag with misconception
    Go to the checkbox using chromevox
    See that the focus is not going to the checkbox

Expected Behavior

Chromevox focus should go to the checkbox  Use misconception feedback as answer group feedback.

Screenshots/Videos

No response

What device are you using?

Desktop

Operating System

Other

What browsers are you seeing the problem on?

Chrome

Browser version

108.0.5359.111

Additional context

No response

@KolliAnitha KolliAnitha added bug Label to indicate an issue is a regression triage needed labels Jan 20, 2023
@sagangwee
Copy link
Contributor

For new contributors

@sagangwee sagangwee added a11y Impact: Low -- DO NOT WORK ON THIS YET Postponing for now, since it doesn't affect users much. Work: Low Solution is known and broken into good-first-issue-sized chunks. good first issue and removed Impact: Low -- DO NOT WORK ON THIS YET Postponing for now, since it doesn't affect users much. labels Feb 16, 2023
@github-actions
Copy link

Hi @sagangwee, thanks for proposing this as a good first issue. I am removing the label for now and looping in @DubeySandeep to approve the label. It will be added back if approved. Thanks!

@kartikay2203
Copy link

I want to work in this issue, please assign me this issue

@kartikeysaran
Copy link

Hey if anyone else is not working on this issue, Can I work on this

@seanlip
Copy link
Member

seanlip commented Feb 27, 2023

@kartikay2203 @kartikeysaran Per the guidance at https://github.com/oppia/oppia/wiki/Contributing-code-to-Oppia#choosing-a-good-first-issue, please provide an explanation of what your PR will do (with names of files you're changing, what you plan to change in each file, etc.). If it looks good, we can assign you to this issue.

Please also follow the other instructions on that wiki page if you have not yet done so. Thanks!

@Krishcode264
Copy link

i think , i should make a PR

@seanlip
Copy link
Member

seanlip commented Mar 30, 2023

@Krishcode264 See guidance in the conversation thread above.

@stevenjgodfrey
Copy link
Collaborator

Hi @KolliAnitha, I'm trying to investigate this issue, but I'm struggling to recreate the steps here, please could you explain a little more what is meant by click on tag with misconception, and where this occurs ? Thanks

@Ash-2k3
Copy link
Member

Ash-2k3 commented May 29, 2023

Hi @Patel-Muhammad Can you please also set target merge dates here and else where too, so that it looks manageable, Thanks.

@Patel-Muhammad
Copy link
Contributor

Patel-Muhammad commented May 29, 2023

@Ash-2k3 Sorry I dont have permission to add merge dates for issues belonging to"Contributor experience". Can you pelase set the merge date to be 24 June. Thanks

@Ash-2k3
Copy link
Member

Ash-2k3 commented May 30, 2023

Done ! Thanks.

@Patel-Muhammad
Copy link
Contributor

Hi @KolliAnitha can you please share a video showing how to reproduce the issue? Thanks!

@Patel-Muhammad
Copy link
Contributor

Hi @KolliAnitha @seanlip @Rijuta-s I am not able to reproduce this issue, the misconception is not visible. Please let me know the steps to reproduce this issue:

Contributor.Dashboard.-.Oppia.-.Google.Chrome.2023-07-20.12-08-22.mp4

@Patel-Muhammad
Copy link
Contributor

Patel-Muhammad commented Jul 25, 2023

Hi @KolliAnitha @seanlip @Rijuta-s I am not able to reproduce this issue, the misconception is not visible. Please let me know the steps to reproduce this issue, please let me know how can I access the checkbox for this issue?

@seanlip
Copy link
Member

seanlip commented Jul 25, 2023

You'll need to create a skill with misconceptions, and add a question to that skill. See the LaCE and CD onboarding docs on the wiki, and if that doesn't help, feel free to contact the respective teams directly.

@seanlip seanlip removed their assignment Jul 25, 2023
Patel-Muhammad added a commit to Patel-Muhammad/oppia that referenced this issue Jul 27, 2023
seanlip pushed a commit that referenced this issue Jul 28, 2023
…17080  : Fixed a11y issues with the contributor dashboard page (#18427)

* fixed a11y issues with the contibutor dashbaord

* removed extra spaces

* changed ".8" to "0.8"

* Changed RTE text

* Reviewers changes

* lint

* Changes requested by designers

* changed the accessibility text

* lint

* designer's changes and fix #17080

* lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y bug Label to indicate an issue is a regression good first issue Impact: Low -- DO NOT WORK ON THIS YET Postponing for now, since it doesn't affect users much. Work: Low Solution is known and broken into good-first-issue-sized chunks.
Projects
Archived in project