Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Topbar buttons are not visible in mobile view. #19443

Open
iamprayush opened this issue Sep 11, 2020 · 25 comments
Open

[Feature request] Topbar buttons are not visible in mobile view. #19443

iamprayush opened this issue Sep 11, 2020 · 25 comments
Labels
enhancement Label to indicate an issue is a feature/improvement Impact: Medium Will improve quality-of-life for at least 30% of users. Work: Low Solution is known and broken into good-first-issue-sized chunks.

Comments

@iamprayush
Copy link
Contributor

iamprayush commented Sep 11, 2020

Describe the bug
While playing an exploration on a mobile device, there is no way to leave feedback, suggest changes, or report the exploration since these buttons are only visible on large screens.

To Reproduce
Steps to reproduce the behavior:

  1. Play any exploration on mobile.

Observed behavior
Buttons are not visible in the topbar.

Expected behavior
The buttons should be visible, or at the very least, they should be present in the drawer.

Important TODO
Once the resolution for this issue is in place, please ensure to address the this TODO that was previously blocked due to this issue.

The task involves the removal of a section that was bypassing the mobile tests for that specific acceptance test. The goal is to ensure that the test is executed and successfully passed in the mobile viewport. This shall be the part of the PR.

Screenshots
Screenshot from 2020-09-11 15-57-00

@dharmelolar
Copy link

Hello @iamprayush please can I take up this issue?

@iamprayush
Copy link
Contributor Author

Hey @dharmelolar!
Yes, you can take this up, but please make sure that you've followed the instructions given here, i.e., signed the CLA and filled the contributor's survey.

@vojtechjelinek
Copy link
Member

@kevintab95 Is this expected?

@kevintab95
Copy link
Member

We currently don't show report/feedback for mobile because of the lack of space but it would be good to have. Not a priority at the moment though. Any thoughts @aks681?

@ARKEOLOGIST
Copy link
Contributor

Is this intended or can changes be done here? Some guidance would definitely be welcome.

@vojtechjelinek
Copy link
Member

As Kevin said it is not a priority but probably can be done.

@oppiabot
Copy link

oppiabot bot commented May 24, 2021

Hi @oppia/core-maintainers, this issue is not assigned to any project. Can you please update the same? Thanks!

@kevintab95 kevintab95 removed their assignment Nov 18, 2021
@devarsh10
Copy link

Is this issue solved?
If not, please assign it to me.
Thanks and Regards.

@SanjaySajuJacob
Copy link
Contributor

@kevintab95 @seanlip, can this be considered a high priority issue now? In my opinion it can be moved out of the high priority issues but can still be kept as a priority issue, since it directly doesn't break user flow but it is good to give these options learners using mobile view as well. Would you agree with this?

@seanlip
Copy link
Member

seanlip commented Dec 7, 2022

@SanjaySajuJacob You'll need to add labels for impact and work before deciding what to classify it as, following our standard triage process. Could you please do that? Then the determination of priority should be straightforward.

If you have questions about those two labels, feel free to ask, but all the guidance should already be there in the triaging process wiki page.

@SanjaySajuJacob
Copy link
Contributor

SanjaySajuJacob commented Dec 8, 2022

Yes @seanlip , I think this issue can remain at high impact, since giving feedback and reporting are factors that improve the learning experience of a user which they are blocked from using. Although as described by the triaging process, it does not directly affect the flow of a user. Would you give me your feedback on which category this would lie in?

@seanlip
Copy link
Member

seanlip commented Dec 8, 2022

How would you classify the "severity" and the "number of users affected"?

@SanjaySajuJacob
Copy link
Contributor

I think the number of users will be high since phones are more available. But the severity would be medium since it affect a secondary user journey of feedback, reporting, etc. Yes, in that case I think the impact would be medium overall.

@seanlip
Copy link
Member

seanlip commented Dec 8, 2022

All right, then let's go with that. Thanks!

@spandit230496
Copy link

hey i want to contribute by can you assign it to me

@SanjaySajuJacob
Copy link
Contributor

Hi @spandit230496, would you like to give a potential solution to this problem? If your solution seems fine, I can assign it to you. Otherwise I recommend that you look into one of the unassigned good first issues here https://github.com/orgs/oppia/projects/3/views/10 to start working on.

@spandit230496
Copy link

spandit230496 commented Jan 20, 2023 via email

@SanjaySajuJacob
Copy link
Contributor

Hi @spandit230496, In this case what you have to do is observe the top bar when using desktop to do an exploration, similarly observe the top bar when using mobile. You will see the symbols to give feedback, report and share exploration in desktop but these options won't be visible in mobile. Is this clear?

@spandit230496
Copy link

spandit230496 commented Jan 20, 2023 via email

@SanjaySajuJacob
Copy link
Contributor

SanjaySajuJacob commented Jan 20, 2023

Great, then would you please try this out and tell me if you are able to replicate the issue? Feel free to ask if you have any doubts

@hrshkshri
Copy link
Contributor

Hey @ConorMack @liwei899
need feedback here for mobile view what should it look like here?

@seanlip
Copy link
Member

seanlip commented Jan 7, 2024

I'm going to move this to the design team project board since it needs design feedback.

@seanlip seanlip assigned ConorMack and liwei899 and unassigned hrshkshri Jan 7, 2024
@seanlip seanlip transferred this issue from oppia/oppia Jan 7, 2024
@seanlip
Copy link
Member

seanlip commented Jan 7, 2024

Note: See #19341 for a sample PR that @hrshkshri made for this.

@seanlip seanlip changed the title Topbar buttons are not visible in mobile view. [Transferred from Web repo] Topbar buttons are not visible in mobile view. Jan 7, 2024
@seanlip
Copy link
Member

seanlip commented Jan 11, 2024

Design feedback is here: #19341 (comment)

This issue can be worked on again by developers. @hrshkshri do you want to complete it?

@seanlip seanlip transferred this issue from oppia/design-team Jan 11, 2024
@seanlip seanlip changed the title [Transferred from Web repo] Topbar buttons are not visible in mobile view. [Feature request] Topbar buttons are not visible in mobile view. Jan 11, 2024
@hrshkshri
Copy link
Contributor

This issue can be worked on again by developers. @hrshkshri do you want to complete it?

Yeah sure I would like to complete it.
thanks

@hrshkshri hrshkshri self-assigned this Jan 11, 2024
@seanlip seanlip added enhancement Label to indicate an issue is a feature/improvement Impact: Medium Will improve quality-of-life for at least 30% of users. Work: Low Solution is known and broken into good-first-issue-sized chunks. labels Jan 28, 2024
@hrshkshri hrshkshri removed their assignment May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Label to indicate an issue is a feature/improvement Impact: Medium Will improve quality-of-life for at least 30% of users. Work: Low Solution is known and broken into good-first-issue-sized chunks.
Projects
Status: Todo
Development

Successfully merging a pull request may close this issue.