-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature request] Topbar buttons are not visible in mobile view. #19443
Comments
Hello @iamprayush please can I take up this issue? |
Hey @dharmelolar! |
@kevintab95 Is this expected? |
We currently don't show report/feedback for mobile because of the lack of space but it would be good to have. Not a priority at the moment though. Any thoughts @aks681? |
Is this intended or can changes be done here? Some guidance would definitely be welcome. |
As Kevin said it is not a priority but probably can be done. |
Hi @oppia/core-maintainers, this issue is not assigned to any project. Can you please update the same? Thanks! |
Is this issue solved? |
@kevintab95 @seanlip, can this be considered a high priority issue now? In my opinion it can be moved out of the high priority issues but can still be kept as a priority issue, since it directly doesn't break user flow but it is good to give these options learners using mobile view as well. Would you agree with this? |
@SanjaySajuJacob You'll need to add labels for impact and work before deciding what to classify it as, following our standard triage process. Could you please do that? Then the determination of priority should be straightforward. If you have questions about those two labels, feel free to ask, but all the guidance should already be there in the triaging process wiki page. |
Yes @seanlip , I think this issue can remain at high impact, since giving feedback and reporting are factors that improve the learning experience of a user which they are blocked from using. Although as described by the triaging process, it does not directly affect the flow of a user. Would you give me your feedback on which category this would lie in? |
How would you classify the "severity" and the "number of users affected"? |
I think the number of users will be high since phones are more available. But the severity would be medium since it affect a secondary user journey of feedback, reporting, etc. Yes, in that case I think the impact would be medium overall. |
All right, then let's go with that. Thanks! |
hey i want to contribute by can you assign it to me |
Hi @spandit230496, would you like to give a potential solution to this problem? If your solution seems fine, I can assign it to you. Otherwise I recommend that you look into one of the unassigned good first issues here https://github.com/orgs/oppia/projects/3/views/10 to start working on. |
Hey Sanjay
I am not able to recreate the issue
…On Fri, 20 Jan, 2023, 9:48 am Sanjay Saju Jacob, ***@***.***> wrote:
Hi @spandit230496 <https://github.com/spandit230496>, would you like to
give a potential solution to this problem? If your solution seems fine, I
can assign it to you. Otherwise I recommend that you look into one of the
unassigned good first issues here
https://github.com/orgs/oppia/projects/3/views/10 to start working on.
—
Reply to this email directly, view it on GitHub
<#19443>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/A4CXXSW24G4JXURSUMCOBILWTIG3FANCNFSM4RHFJ3CQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Hi @spandit230496, In this case what you have to do is observe the top bar when using desktop to do an exploration, similarly observe the top bar when using mobile. You will see the symbols to give feedback, report and share exploration in desktop but these options won't be visible in mobile. Is this clear? |
Yes
…On Fri, 20 Jan, 2023, 7:54 pm Sanjay Saju Jacob, ***@***.***> wrote:
Hi @spandit230496 <https://github.com/spandit230496>, In this case what
you have to do is observe the top bar when using desktop to do an
exploration, similarly observe the top bar when using mobile. You will see
the symbols to give feedback, report and share exploration in desktop but
these options won't be visible in mobile. Is this clear?
—
Reply to this email directly, view it on GitHub
<#19443>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/A4CXXSRXCP5YPWO4HOZGBQLWTKN2VANCNFSM4RHFJ3CQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Great, then would you please try this out and tell me if you are able to replicate the issue? Feel free to ask if you have any doubts |
Hey @ConorMack @liwei899 |
I'm going to move this to the design team project board since it needs design feedback. |
Note: See #19341 for a sample PR that @hrshkshri made for this. |
Design feedback is here: #19341 (comment) This issue can be worked on again by developers. @hrshkshri do you want to complete it? |
Yeah sure I would like to complete it. |
Describe the bug
While playing an exploration on a mobile device, there is no way to leave feedback, suggest changes, or report the exploration since these buttons are only visible on large screens.
To Reproduce
Steps to reproduce the behavior:
Observed behavior
Buttons are not visible in the topbar.
Expected behavior
The buttons should be visible, or at the very least, they should be present in the drawer.
Important TODO
Once the resolution for this issue is in place, please ensure to address the this TODO that was previously blocked due to this issue.
The task involves the removal of a section that was bypassing the mobile tests for that specific acceptance test. The goal is to ensure that the test is executed and successfully passed in the mobile viewport. This shall be the part of the PR.
Screenshots
![Screenshot from 2020-09-11 15-57-00](https://user-images.githubusercontent.com/35144226/92913053-09f38b80-f448-11ea-9c93-947fccca263b.png)
The text was updated successfully, but these errors were encountered: