Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Navigation Issue in Release Coordinator Tab on Mobile Viewport #20476

Closed
Akhilesh-max opened this issue Jun 16, 2024 · 5 comments
Closed
Labels
bug Label to indicate an issue is a regression triage needed

Comments

@Akhilesh-max
Copy link
Contributor

Akhilesh-max commented Jun 16, 2024

Describe the bug

There seems to be a problem with navigating between tabs within the Release Coordinator page when accessed from a mobile device. Specifically, one cannot move to other tabs such as “MISC” or “FEATURES” due to the absence of navigation options in the mobile viewport.

Important TODO:

Please note that there is a test currently skipped on mobile viewports due to this navigation issue. The “MISC” tab, which is inaccessible, is essential for testing promo messages. Once this navigation problem is resolved, the corresponding code that skips this test on mobile viewports should be removed. Make sure to do that as a part of PR fixing this issue.

URL of the page where the issue is observed.

http://localhost:8181/release-coordinator

Steps To Reproduce

i) Access the Release Coordinator (/release-coordinator) tab on Oppia from a mobile device or at mobile viewport
ii) Attempt to navigate to the “MISC” or “FEATURES” tabs.

Expected Behavior

Users should be able to seamlessly navigate between all available tabs within the Release Coordinator page, regardless of the device or viewport. Navigation options should be clearly visible and functional in the mobile viewport.

Screenshots/Videos

What device are you using?

Desktop

Operating System

MacOS

What browsers are you seeing the problem on?

Edge

Browser version

No response

Additional context

No response

Tips for developers

Before addressing the bug, please identify which PR caused the issue (you can follow the steps here). If you identify the PR, comment on the issue with a link to it. If not, mention the commit hash of the oldest commit you saw the bug on (and the month and year it was made in).

Then, please leave a comment with details of the approach that you plan to take to fix the issue (see example).

Note: If this is your first Oppia issue, please make sure to follow our guidelines for choosing an issue and setting things up. You will also need to show a demo of the fix working correctly on your local machine. Thanks!

@Akhilesh-max Akhilesh-max added triage needed bug Label to indicate an issue is a regression labels Jun 16, 2024
@Vir-8
Copy link
Contributor

Vir-8 commented Jun 16, 2024

Hi @Akhilesh-max, a fix is included in #20439 by modifying the release coordinator navbar component to have navigation similar to the admin page. It should be merged very soon but please feel free to take a look in case you are being blocked.

@Akhilesh-max
Copy link
Contributor Author

Thanks for taking a look, @Vir-8.
Yes, a mobile test is blocked onto this due to the lack of navigation in the mobile viewport.
Do you feel, your fix could be merged by tomorrow, EOD?

@Vir-8
Copy link
Contributor

Vir-8 commented Jun 16, 2024

@Akhilesh-max Yes, most likely

@Akhilesh-max
Copy link
Contributor Author

@Vir-8 Sure, then maybe it would be better for me to wait for the merge.
Thanks.

@Akhilesh-max
Copy link
Contributor Author

Fixed by #20439

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Label to indicate an issue is a regression triage needed
Projects
None yet
Development

No branches or pull requests

2 participants