[GSoC'24] M1.3 - Modify translations frontend modal #20439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ons-frontend-modal
…ons-frontend-modal
|
Hi @Vir-8, can you complete the following:
|
|
Hi @Vir-8 please assign the required reviewer(s) for this PR. Thanks! |
…ons-frontend-modal
…ons-frontend-modal
|
Unassigning @kevintab95 since they have already approved the PR. |
|
Just one comment for @seanlip here #20439 (comment) (not a blocker and can be addressed in the next PR if required.) Thanks! |
5 tasks
|
Thanks @kevintab95, replied. @Vir-8 Can you please double-check that this looks right in RTL? |
seanlip
approved these changes
Jun 18, 2024
…ons-frontend-modal
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 18, 2024
* Create frontend modal with list of translations populated * Display language names appropriately * Stylize scrollbar and fix displaying rich text elements * Fix button styles * Handle populating draft translation changes appropriately * Add comments for clarity * Handle cases where translations have been removed and no translations are available * Handle logic for removing published as well as draft translations appropriately * Add frontend tests * Write acceptance tests * Fix lint errors and convert backend dicts appropriately * Fix merge conflict * Fix lint issue * Fix typescript issues * Fix merge issue * Fix frontend test failure * Fix acceptance testing, add feature flag utility * Fix merge issues * Fix lint issues * Fix typo * Make release coordinator page responsive and fix acceptance testing * Fix lint issues * Fix e2e test failing * Attempt to fix acceptance test * Remove acceptance test from CI * Add todo comment for acceptance testing * Address comments * Address comments * Fix lint issue
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
…ons-frontend-modal
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 19, 2024
* Create frontend modal with list of translations populated * Display language names appropriately * Stylize scrollbar and fix displaying rich text elements * Fix button styles * Handle populating draft translation changes appropriately * Add comments for clarity * Handle cases where translations have been removed and no translations are available * Handle logic for removing published as well as draft translations appropriately * Add frontend tests * Write acceptance tests * Fix lint errors and convert backend dicts appropriately * Fix merge conflict * Fix lint issue * Fix typescript issues * Fix merge issue * Fix frontend test failure * Fix acceptance testing, add feature flag utility * Fix merge issues * Fix lint issues * Fix typo * Make release coordinator page responsive and fix acceptance testing * Fix lint issues * Fix e2e test failing * Attempt to fix acceptance test * Remove acceptance test from CI * Add todo comment for acceptance testing * Address comments * Address comments * Fix lint issue
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR fixes part of [Feature Request]: Make it easy for exploration editors to update translations if trivial changes are made. #18549.
This PR does the following: Creates the frontend modal for the exploration editor to modify the existing translations when they edit a piece of content that has already been translated. This modal is populated by the entire list of existing translations, including draft translations, and is completely up to date.
Write acceptance tests, including adding the utility for the release coordinator user of enabling a feature flag, since this modal is gated behind a feature flag, to verify if the translations are seen for each of the following cases -
Essential Checklist
Please follow the instructions for making a code change.
Proof that changes are correct
Note that the acceptance test spec has not been added to the CI yet since it is gated behind a feature flag in dev, and such feature flags cannot be enabled in prod mode.
frontend.demo.mov
Draft translations and removing existing translations -
frontend.demo.2.mov
Proof of changes on mobile phone
Screen.Recording.2024-06-14.at.4.57.47.AM.mov
PR Pointers