Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

start.sh on mac: incorrect npm binary #36

Closed
GoogleCodeExporter opened this issue Aug 14, 2015 · 3 comments
Closed

start.sh on mac: incorrect npm binary #36

GoogleCodeExporter opened this issue Aug 14, 2015 · 3 comments

Comments

@GoogleCodeExporter
Copy link

What steps will reproduce the problem?
1. git pull oppia on a mac
2. run start.sh

What is the expected output? What do you see instead?
The start.sh script pulls the linux version of node.js and npm without looking 
at the actual system, so when it tries to actually use it to get the needed 
node packages, it breaks since the binary can't run on mac.

Original issue reported on code.google.com by yana...@google.com on 18 Aug 2013 at 8:31

@GoogleCodeExporter
Copy link
Author

We can probably get around this by checking `uname`, which is "Linux" on Ubuntu 
and "Darwin" on Mac, and then downloading the correct binaries from 
http://nodejs.org/download/ . I'll work on this today.

Original comment by s...@seanlip.org on 23 Aug 2013 at 5:47

@GoogleCodeExporter
Copy link
Author

I think I've fixed this; could one of you please verify with the new start.sh 
script on a Mac? (I've tested on my Linux x86 at home and will test on an x64 
later today.) Hopefully this addresses the cakephp issues down the line, too.

Original comment by s...@seanlip.org on 23 Aug 2013 at 6:12

  • Changed state: Fixed

@GoogleCodeExporter
Copy link
Author

I can now also confirm that this works on x64 Ubuntu.

Original comment by s...@google.com on 23 Aug 2013 at 6:31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant