Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test frontend services #4057

Closed
shubha1593 opened this issue Nov 5, 2017 · 313 comments · Fixed by #8811
Closed

Test frontend services #4057

shubha1593 opened this issue Nov 5, 2017 · 313 comments · Fixed by #8811
Assignees
@nithusha21
Labels
frontend good first issue
Projects
Automated QA Team

Comments

@shubha1593
Copy link
Contributor

shubha1593 commented Nov 5, 2017 •
edited by Radesh-kumar

This is intended as a starter project for newer contributors but if you're already a contributor for some time, you can help as well.

NOTE: Please ping @nithusha21 if you have any questions about this issue or would like to be assigned to some part of it.

In order to prevent future regressions, we want to ensure that all services in our frontend codebase are thoroughly tested. If it's your first time here, please read carefully the guide of how to get started with frontend unit testing: Guide for writing frontend tests. Please use this guide as your helper, all the instructions of how to test properly is in it.

Also, here is Oppia's wiki page for running the client-side Karma tests.

The services are separated by three levels of complexity:

Complexity Easy Medium Hard
Number of lines up to 100 lines up to 250 lines at least 250 lines

Then, it doesn't matter if you're new to unit test or if you're looking for something more challenging, there will be service for you work with.

Each file is marked with two information that will help you to decide which service to pick. For example:

  • A - B service-name.service.ts

A means the service complexity: E for Easy, M for medium and H for Hard.
B means if the service has a spec file: Y for Yes and N for No.

Spec files for services tests consist of the name of the service, followed by .spec.ts or Spec.ts, it depends of the service file name structure:

  • Use .spec.ts for services like: service-name.service.ts
  • Use Spec.ts for services like: ServiceNameService.ts
    When writing tests, if a spec file already exists for the service you have picked, then edit the existing file. If a spec file isn't present yet, create a new file and name it accordingly. You can also take a look at the existing spec files for different services to get an idea on how to get started.

Note: We are currently in the process of upgrading AngularJS to Angular. If the service is written in AngularJS, write the test in AngularJS. If the service is written in Angular, write the test in Angular. We would also prefer to cover all Angular files before moving to AngularJS files to prevent extra work during the migration.

If you'd like to help with this issue, please select a file from the list below, comment on the thread with the file name or any query you'd like to be assigned, and submit a PR when you've completed writing the test. Once the PR is submitted, you can tick the checkboxes.

PR's for reference: #4135 #8916 #8934

Files to write tests for or increase until 100%:

Angular files

  • core/templates
    • components/graph-services
      • H - N graph-layout.service.ts
    • components/state-editor
      • M - Y state-editor.service.ts @Deepam101
      • M - Y state-property.service.ts
    • domain/collection
      • M - Y collection-node.model.ts @Nisarg-Chaudhari
      • H - Y collection.model.ts
      • E - N collection-playthrough.model.ts @karthikshetty03
      • M - Y editable-collection-backend-api.service.ts
      • M - Y read-only-collection-backend-api.service.ts
    • domain/question
      • E - Y pretest-question-backend-api.service.ts @wcascades
    • domain/skill
      • H - Y SkillObjectFactory.ts
    • domain/state_card
      • M - Y StateCardObjectFactory.ts
    • domain/story
      • M - Y editable-story-backend-api.service.ts @kaushambisharma
      • H - Y StoryContentsObjectFactory.ts
      • H - Y story-node.model.ts
    • domain/topic
      • M - Y SubtopicObjectFactory.ts
      • M - Y SubtopicPageObjectFactory.ts
      • H - Y TopicObjectFactory.ts
    • domain/topics_and_skills_dashboard
      • E - Y topics-and-skills-dashboard-backend-api.service.ts @michaelw54
    • domain/utilities
      • M - Y language-util.service.ts @laujamie
      • M - Y url-interpolation.service.ts
    • expressions
      • M - Y expression-evaluator.service.ts
      • M - Y expression-interpolation.service.ts
    • pages/community-dashboard-page
      • M - Y contribution-opportunities-backend-api.service.ts
    • pages/email-dashboard-pages
    • pages/exploration-editor-page
      • H - N exploration-diff.service.ts
      • M - Y version-tree.service.ts
  • pages/exploration-player-page
    • E - Y audio-translation-manager.service.ts @Nik-09
    • M - Y answer-classification.service.ts
    • M - Y audio-preloader.service.ts
    • M - Y current-interaction.service.ts
    • E - N exploration-recommendations.service.ts @TheoLipeles
    • M - Y learner-answer-info.service.ts
    • E - N player-correctness-feedback-enabled.service.ts @soumyo123-prog
    • M - Y player-transcript.service.ts
    • H - N question-player-engine.service.ts @ehwu
    • H - N stats-reporting.service.ts
  • pages/story-editor-page
    • M - Y story-editor-state.service.ts
  • services
    • E - N autogenerated-audio-player.service.ts
    • H - Y context.service.ts @HarshKhilawala
    • E - Y csrf-token.service.ts @Nik-09
    • E - Y html-escaper.service.ts @Nik-09
    • M - N messenger.service.ts
    • E - Y promo-bar-backend-api.service.ts @tanishq67
    • M - N request-interceptor.service.ts
    • M - Y state-top-answers-stats.service.ts
    • E - Y utils.service.ts @HarshKhilawala
  • extensions
    • classifiers
      • H - Y python-program.tokenizer.ts
      • H - Y svm-prediction.service.ts
    • extensions
      • M - N base-interaction-validation.service.ts
      • H - Y code-repl-prediction.service.ts
      • E - Y continue-rules.service.ts
      • M - Y drag-and-drop-sort-input-validation.service.ts
      • E - N end-exploration-rules.service.ts @SAEb-ai
      • H - Y fraction-input-validation.service.ts
      • E - N graph-detail.service.ts @safwan20
      • M - Y graph-input-rules.service.ts
      • M - Y graph-input-validation.service.ts
      • M - N graph-utils.service.ts @atpug22
      • M - Y item-selection-input-validation.service.ts
      • M - Y music-notes-input-rules.service.ts
      • E - N music-phrase-player.service.ts @HarshKhilawala
      • M - Y number-with-units-validation.service.ts @akshayrathi2102
      • M - Y numeric-input-validation.service.ts @EeshaArif

AngularJS files

  • core/templates
    • components/entity_creation
      • M - N exploration-creation.service.ts
      • E - N skill-creation.service.ts @LakmaNeha
      • E - N story-creation.service.ts @taiwo2
      • E - N topic-creation.service.ts
    • domain/collection
      • H - Y collection-update.service.ts
    • domain/question
      • M - Y question-update.service.ts
    • domain/skill
      • H - Y skill-update.service.ts
    • domain/story
      • H - Y story-update.service.ts
    • pages/community-dashboard-page
      • M - Y contribution-and-review.service.ts
      • E - N contribution-opportunities.service.ts
      • M - N translate-text.service.ts
    • pages/exploration-editor-page
      • M - N change-list.service.ts
      • H - N exploration-save.service.ts
      • H - Y exploration-states.service.ts
      • E - N state-tutorial-first-time.service.ts @safwan20
      • M - N suggestion-modal-for-exploration-editor.service.ts
      • M - N voiceover-recording.service.ts
    • pages/exploration-player-page
      • H - N exploration-engine.service.ts
      • H - Y exploration-player-state.service.ts
      • E - N fatigue-detection.service.ts
      • M - N hint-and-solution-modal.service.ts @Radesh-kumar
      • M - Y learner-answer-info.service.ts
      • E - N refresher-exploration-confirmation-modal.service.ts
      • M - N suggestion-modal-for-exploration-player.service.ts
    • pages/skill-editor-page
      • M - Y skill-editor-state.service.ts
    • pages/topic_editor
      • topic-editor-state.service.ts
    • services
      • M - N audio-player.service.ts
      • E - Y image-upload-helper.service.tests @sachinchauhan2889
      • E - N translation-file-hash-loader.service.ts
Click to see the list of completed work.
  • components/forms
  • components/state_editor
  • domain/classifier
  • domain/classroom
  • domain/collection
    • CollectionRightsBackendApiService.ts @marianazangrossi
    • CollectionRightsObjectFactory.ts @marianazangrossi
    • CollectionValidationService.ts @marianazangrossi
  • domain/creator_dashboard
    • CreatorDashboardBackendApiService.ts @marianazangrossi
  • domain/exploration
    • AnswerStatsObjectFactory.ts @marianazangrossi
    • ExplorationObjectFactory.ts @marianazangrossi
    • HintObjectFactory.js @YashJipkate
    • InteractionObjectFactory.js @YashJipkate
    • OutcomeObjectFactory.js @abhaygupta97
    • ParamChangeObjectFactory.ts @marianazangrossi
    • ParamChangesObjectFactory.ts - @lakshay-angrish
    • ParamSpecObjectFactory.ts @marianazangrossi
    • ParamSpecsObjectFactory.ts @marianazangrossi
    • RuleObjectFactory.ts @abhayraghuwanshi
    • SolutionObjectFactory.ts @marianazangrossi
    • TriggerObjectFactory.js @17bcs029 (removed the file)
    • WrittenTranslationsObjectFactory.ts @marianazangrossi
  • domain/learner_dashboard
  • domain/objects
  • domain/question
    • EditableQuestionBackendApiService.ts @marianazangrossi
    • QuestionBackendApiService.ts @jimbyo
    • QuestionObjectFactory.ts @jimbyo
  • domain/sidebar @WickedBrat #4520
    • SidebarStatusService.js
  • domain/skill
    • ConceptCardBackendApiService.ts @marianazangrossi
    • EditableSkillBackendApiService.ts @marianazangrossi
    • MisconceptionObjectFactory.ts @marianazangrossi
    • SkillRightsObjectFactory.ts @marianazangrossi
    • SkillRightsBackendApiService.ts @marianazangrossi
  • domain/state
    • StateObjectFactory.ts @marianazangrossi
  • domain/statistics
    • FeedbackImprovementTaskObjectFactory.ts @marianazangrossi
    • PlaythroughImprovementTaskObjectFactory.ts @marianazangrossi
    • SuggestionImprovementTaskObjectFactory.ts @marianazangrossi
  • domain/suggestion
    • SuggestionThreadObjectFactory.ts @marianazangrossi
  • domain/summary
    • ExplorationSummaryBackendApiService.ts @marianazangrossi
  • domain/topic
    • EditableTopicBackendApiService.ts @marianazangrossi
    • TopicRightsBackendApiService.ts @marianazangrossi
    • TopicRightsObjectFactory.ts @marianazangrossi
  • domain/user
    • UserInfoObjectFactory.ts
  • domain/utilities
    • AudioLanguageObjectFactory.js @hoangviet1993
    • AutogeneratedAudioLanguageObjectFactory.js @hoangviet1993
    • BrowserCheckerService.ts @marianazangrossi
  • pages/creator_dashboard
    • SuggestionModalForCreatorViewService.ts @marianazangrossi
  • pages/exploration_editor
    • AnswerGroupsCacheService.js @vinitamurthi
    • AutosaveInfoModalService.ts @marianazangrossi
    • ChangesInHumanReadableFormService.ts @marianazangrossi
    • CompareVersionService.ts @marianazangrossi
    • EditorFirstTimeEventsService.ts @marianazangrossi
    • E - N exploration-category.service.ts @safwan20
    • ExplorationCorrectnessFeedbackService.ts @marianazangrossi
    • ExplorationDataService.ts @marianazangrossi
    • ExplorationPropertyService.ts @marianazangrossi
    • ExplorationRightsService.ts @marianazangrossi
    • E - N exploration-tags.service.ts @safwan20
    • ExplorationWarningsService.ts @marianazangrossi
    • GraphDataService.ts @marianazangrossi
    • InteractionDetailsCacheService.js @vinitamurthi
    • ImprovementModalService.ts @marianazangrossi
    • LearnerAnswerDetailsDataService.ts @marianazangrossi
    • ParameterMetadataService.ts @marianazangrossi
    • ResponsesService.ts @marianazangrossi
    • RouterService.ts @marianazangrossi
    • SolutionVerificationService.ts @marianazangrossi
    • ThreadDataService.ts @marianazangrossi
    • ThreadStatusDisplayService.js @paroothisumit Fixed part of #4057: ThreadStatusDisplayService #4606
    • TranslationLanguageService.ts @marianazangrossi
    • UserEmailPreferencesService.ts @Arnesh07
      pages/exploration_player
    • AudioTranslationLanguageService.ts @marianazangrossi
    • HitsAndSolutionManager.service.ts @marianazangrossi
    • ImagePreloaderService.ts @marianazangrossi
    • StateClassifierMappingService.ts @marianazangrossi
      pages/skill_editor
    • SkillEditorRoutingService.ts @marianazangrossi
  • services
    • AlertsService.ts @marianazangrossi
    • AssetsBackendApiService.ts @marianazangrossi
    • AutoplayedVideosService.js @proishan11 Fix part of #4057: Add spec file of AutoplayedVideosService #4805
    • BackgroundMaskService.js @aks681
    • CodeNormalizerService.ts @marianazangrossi
    • ConstructTranslationIdsService.ts @marianazangrossi
    • EditabilityServices.js @square-1111
    • E - N exploration-features.service.ts @abhayraghuwanshi
    • IdGenerationService.js @lilithxxx
    • DateTimeFormatService.ts @marianazangrossi
    • DebouncerService.ts @marianazangrossi
    • DeviceInfoService.ts @marianazangrossi
    • DocumentAttributeCustomizationService.ts @marianazangrossi
    • ExtensionTagAssemblerService.ts @marianazangrossi
    • FocusManagerService.js @aks681
    • LocalStorageService.ts @marianazangrossi
    • LoggerService.ts @marianazangrossi
    • MetaTagCustomizationService.ts @marianazangrossi
    • NavigationService.ts @marianazangrossi
    • NestedDirectivesRecursionTimeoutPreventionService.ts @marianazangrossi
    • PageTitleService.ts @marianazangrossi
    • PlayerPositionService.js @ujjwalgulecha
    • PlaythroughIssuesBackendApiService.ts @marianazangrossi
    • PlaythroughIssuesService.ts @marianazangrossi
    • QuestionsListService.ts @marianazangrossi
    • RteHelperService.ts @marianazangrossi
    • SchemaDefaultValueService.ts @marianazangrossi
    • SchemaUndefinedLastElementService.ts @marianazangrossi
    • SearchService.ts @marianazangrossi
    • SiteAnalyticsService.ts @marianazangrossi
    • SpeechSynthesisChunkerService.ts @marianazangrossi
    • SuggestionModalService.ts @marianazangrossi
    • TrainingDataEditorPainelService.ts @marianazangrossi
    • TrainingModalService.ts @marianazangrossi
    • UrlService.ts @marianazangrossi
    • UserService.ts @marianazangrossi
    • ValidatorsService.ts @marianazangrossi
    • WindowDimensionsService.ts @marianazangrossi
    • WindowRefService.ts @marianazangrossi
  • components/ratings
    • E - Y rating-computation.service.ts @laujamie
  • domain/editor
    • M - N base-undo-redo.service.ts
    • E - N question-undo-redo.service.ts @safwan20
  • domain/exploration
    • M - N AnswerGroupObjectFactory.ts @safwan20
    • M - Y editable-exploration-backend-api.service.ts @shavavo
    • M - Y RecordedVoiceoversObjectFactory.ts @shavavo
    • M - Y StatesObjectFactory.ts @kevjumba
  • domain/feedback_thread
    • M - Y FeedbackThreadSummaryObjectFactory.ts
  • domain/objects
    • H - Y NumberWithUnitsObjectFactory.ts
      Other services:
  • E - N collection-creation.service.ts @Hadyn
  • E - N exploration-embed-button.service.ts
  • E - N question-creation.service.ts @mhotiger
  • E - N state-content.service.ts @safwan20
  • E - N state-customization-args.service.ts @safwan20
  • E - N state-interaction-id.service.ts @safwan20
  • E - N state-recorded-voiceovers.service.ts @safwan20
  • E - N state-solicit-answer-details.service.ts @safwan20
  • E - N state-solution.service.ts @safwan20
  • E - N state-written-translations.service.ts @safwan20
  • M - Y ConceptCardObjectFactory.ts
  • E - Y SkillDifficultyObjectFactory.ts @tianqi-wu
  • domain/statistics
    • E - Y learner-answer-details-backend-api.service.ts @arpit1912
  • domain/story_viewer
    • E - Y story-viewer-backend-api.service.ts @EricZLou
    • H - Y topic-update.service.ts @shavavo
    • E - N AudioFileObjectFactory.ts @safwan20
    • E - N FileDownloadRequestObjectFactory.ts @safwan20
    • E - N ImageFileObjectFactory.ts @safwan20
    • H - Y expression-syntax-tree.service.ts @mertdeg2
    • E - Y expression-type-parser.service.ts
    • M - Y collection-editor-state.service.ts
    • E - N question-suggestion.service.ts
    • E - N exploration-automatic-text-to-speech.service.ts @safwan20
    • E - N exploration-init-state-name.service.ts
    • E - N exploration-language-code.service.ts
    • E - N exploration-objective.service.ts
    • E - N exploration-param-changes.service.ts @safwan20
    • E - N exploration-param-specs.service.ts @safwan20
    • E - N exploration-title.service.ts
    • E - Y state-improvement-suggestion.service.ts
    • E - Y player-position.service.ts @tianqi-wu
    • E - Y prediction-algorithm-registry.service.ts @rriyaldhi
    • E - N suggestion-modal-for-learner-dashboard.service.ts @hulyak
    • TopicEditorRoutingService.ts @amanbora
    • E - N compute-graph.service.ts
    • E - Y improvement-task.service.ts
    • H - Y playthrough.service.ts
    • E - N pencil-code-editor-validation.service.ts @safwan20

Note: For a guide on how to access Oppia's webpages, see this.
@jacobdavis11
Copy link
Member

Would it be better to split this into multiple issues (say one per directory)? That way multiple people could work on it simultaneously.

@seanlip
Copy link
Member

seanlip commented Nov 5, 2017

I think one issue should be fine -- we already follow this pattern for our other starter projects.

@Nix07
Copy link
Contributor

Nix07 commented Nov 6, 2017

Hey, @shubha1593 Can I take "ExplorationEmbedButtonService.js". Hopefully, it will help me to better my understanding of testing processes and writing specs.

@shubha1593
Copy link
Contributor Author

Hi @Nix07, yup sure! assigned you :)

@Nix07
Copy link
Contributor

Nix07 commented Nov 6, 2017 •
edited

This is the screenshot of my karma index page at core/templates/dev/head/components/ Why is it not showing any directory inside the components. It's only giving the results for the JS files present in components directory! However, when I bring the "ExplorationEmbedButtonService.js" file in the components directory its result is visible. Please help @shubha1593
components

@GaganSuneja
Copy link
Contributor

@shubha1593 please assign me editor_tab

@shubha1593
Copy link
Contributor Author

Hi @GaganSuneja, assigned you :)

@shubha1593
Copy link
Contributor Author

Hey @Nix07, in your URL for that it would be like ...karma_coverage_reports/core/templates/dev/head/components/index.html,
make it ...karma_coverage_reports/index.html. Let me know if this works!

@Nix07
Copy link
Contributor

Nix07 commented Nov 8, 2017

Hey, @shubha1593 It didn't help. karma_coverage_reports/index.html just contains all the directory (see the screenshot). To get the result of a specific file, I have to go to that directory.
karma

@seanlip
Copy link
Member

seanlip commented Nov 8, 2017

I just tried this, and I run into the same issue as @Nix07.

So I investigated the script at scripts/run_frontend_tests.sh, and, from there, the karma config at core/tests/karma.conf.js. The config actually looks a little off to me, so I simplified it, and I think it works now -- see #4066

@seanlip
Copy link
Member

seanlip commented Nov 8, 2017

Also, @Nix07, thanks for bringing it up! This is a great bug to catch and I'm happy we're fixing it.

@seanlip seanlip mentioned this issue Nov 8, 2017
Closed
22 tasks
@Nix07 Nix07 mentioned this issue Nov 11, 2017
Closed
@nithusha21
Copy link
Contributor

Hi can I write tests for domain/learner_dashboard?

@DubeySandeep
Copy link
Member

@nithusha21, Sure! I've assigned you.

@nithusha21 nithusha21 mentioned this issue Dec 1, 2017
Merged
3 tasks
@aks681
Copy link
Member

aks681 commented Dec 1, 2017

Hi @shubha1593 , can I take services/stateful?

@DubeySandeep
Copy link
Member

Hi @aks681, Sure! assigend you. :)

aks681 added a commit to aks681/oppia that referenced this issue Dec 3, 2017
@aks681
fixed part of oppia#4057 in services/stateful
536e6dd
1995YogeshSharma added a commit that referenced this issue Dec 10, 2017
@1995YogeshSharma
Merge pull request #4148 from aks681/test-frontend-services
0faa531 
fix part of #4057 - Test frontend services in services/stateful
@jervis446
Copy link
Contributor

HI @shubha1593 ,can i take domain/classifier?

@1995YogeshSharma
Copy link
Contributor

Hi @jervis446, sure, assigned you.

seanlip pushed a commit that referenced this issue Dec 13, 2017
@nithusha21 @seanlip
Fix part of #4057: Learner dashboard tests (#4135)
b8c9b90 
* added tests for LearnerDashboardBackendApiService

* fixed string quotes, added spec file for learner Dashboard IDs API

* incomplete LearnerPlaylistServiceSpec, need help

* Fixed Learner Playlist Service spec file

* Fixed Linting errors

* Fixed Linting errors

* Fixed linting errors

* made review changes
@yashLadha
Copy link
Contributor

Hi i am intreseted in taking and working on this issue. Assign me this

@Radesh-kumar
Copy link
Contributor

@taiwo2
story-creation.service.ts is still in angularJS. You have two options.
1.write tests in angularJS
2.migrate TopicEditorStateService to angular
(I'd recommend 1st option as this service is depending on another service topic-editor-state.service.ts unless you are familiar with angular migration)

@taiwo2
Copy link
Contributor

taiwo2 commented Apr 21, 2021

i should write the test in angular?
please can you send me a guide line to follow or sample to follow

@Radesh-kumar
Copy link
Contributor

Radesh-kumar commented Apr 21, 2021 •
edited

i should write the test in angular?
please can you send me a guide line to follow or sample to follow

You should write them in angular JS.
Instead of using Angular Test Bed use $injector.
(Most of the logic will remain same)
Sample file: #12094
Guide: https://github.com/oppia/oppia/wiki/Frontend-unit-tests-guide

@taiwo2
Copy link
Contributor

taiwo2 commented Apr 21, 2021

thanks

@taiwo2 taiwo2 mentioned this issue Apr 23, 2021
Closed
4 tasks
@ehwu
Copy link

ehwu commented Apr 24, 2021

Would I be able to work on question-player-engine.service.ts?

@Radesh-kumar
Copy link
Contributor

Would I be able to work on question-player-engine.service.ts?

Its all yours :)

@kaushambisharma
Copy link

Hello, I'm new and I was recommended this issue, I'd like to work on editable-story-backend-api.service.ts.

@U8NWXD
Copy link
Member

U8NWXD commented May 7, 2021

@kaushambisharma I've assigned you

@brianyou0
Copy link

brianyou0 commented Jun 9, 2021 •
edited

Hi there: could I be assigned with E - Y continue-rules.service.ts? Thanks. @nithusha21

@PranshuSrivastava
Copy link
Contributor

PranshuSrivastava commented Jun 16, 2021 •
edited

Hey @nithusha21 , could please you assign me the python-program.tokenizer.ts file?

@leylatuon
Copy link
Contributor

@nithusha21 Hi can you assign me the topic-creation.service.ts file?

@soumyo123-prog
Copy link
Contributor

soumyo123-prog commented Jul 28, 2021 •
edited

@vojtechjelinek @U8NWXD, I would like to work on player-correctness-feedback-enabled.service.ts. Can I be assigned this? I was recommended this issue.

@mridul-netizen mridul-netizen mentioned this issue Jul 29, 2021
Merged
4 tasks
@U8NWXD
Copy link
Member

U8NWXD commented Aug 6, 2021

@soumyo123-prog done

U8NWXD pushed a commit that referenced this issue Aug 16, 2021
@soumyo123-prog
Fix part of #4057: Fully cover player-correctness-feedback-enabled.se…
a5a8154 
…rvice.ts (#13519)
seanlip added a commit that referenced this issue Aug 17, 2021
@seanlip
Revert "Fix part of #4057: Fully cover player-correctness-feedback-en…
d60195a 
…abled.service.ts (#13519)"

This reverts commit a5a8154.
seanlip added a commit that referenced this issue Aug 17, 2021
@seanlip
Revert "Fix part of #4057: Fully cover player-correctness-feedback-en…
bec35a1 
…abled.service.ts (#13519)" (#13693)

This reverts commit a5a8154.
@U8NWXD U8NWXD moved this from Triage to Frontend Tests Backlog in Automated QA Team Aug 24, 2021
@U8NWXD U8NWXD moved this from Frontend Tests Backlog to In Progress in Automated QA Team Aug 24, 2021
@siddharthmehta02
Copy link
Contributor

@Rijuta-s hey, i received your mail regarding the issue assignment so can you assign me with email-dashboard-data.service.ts

@Rijuta-s
Copy link
Contributor

@nithusha21 can you please assign @siddharthmehta02 to email-dashboard-data.service.ts ?
Thank you

@Radesh-kumar
Copy link
Contributor

@nithusha21 can you please assign @siddharthmehta02 to email-dashboard-data.service.ts ?
Thank you

done!

@aakashraj01
Copy link

aakashraj01 commented Aug 29, 2021 •
edited

Hi @nithusha21 , I would like to work on this issue. This is my first open-source contribution so please assign me a file accordingly.

@mahendra1290
Copy link
Contributor

hi @nithusha21 I was thinking to work on code-repl-prediction.service.ts but I think this file has been removed.

@siddharthmehta02
Copy link
Contributor

Hey @Radesh-kumar @nithusha21 I was assigned for email-dashboard-data.service.ts but its already showing a 100% coverage
Screenshot from 2021-08-31 21-27-54

@Radesh-kumar
Copy link
Contributor

Hey @Radesh-kumar @nithusha21 I was assigned for email-dashboard-data.service.ts but its already showing a 100% coverage
Screenshot from 2021-08-31 21-27-54

please pick from any of these files
collection-editor-navbar-breadcrumb.directive.ts
collection-footer.component.ts
collection-navbar.component.ts
collection-player-page.directive.ts

@nithusha21
Copy link
Contributor

Hi All, I am happy to inform you that all the pages listed above are completed (As part of GSoC projects this year), and the only ones that remain to be tested are slightly complicated. We don't think the remaining ones are good examples of good first issues. The remaining files are being tracked here: https://docs.google.com/spreadsheets/d/1tky4jE7uxLQTp0MWE3L9USnPvy3PbtGYpMgP7b0bicw/edit#gid=1374717983 and we will handle those as per the plan in the sheet. Thanks everyone for helping out with this issue!

Automated QA Team automation moved this from In Progress to Done Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nithusha21 nithusha21

Labels
frontend good first issue
Projects
No open projects
Automated QA Team
  
Done
Milestone
No milestone