Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images in ItemSelectionInput choices and answers are too big #4091

Closed
seanlip opened this issue Nov 19, 2017 · 8 comments
Closed

Images in ItemSelectionInput choices and answers are too big #4091

seanlip opened this issue Nov 19, 2017 · 8 comments

Comments

@seanlip
Copy link
Member

seanlip commented Nov 19, 2017

If an item selection input interaction is created with images in the choices, we should bound the maximum height/width of the image. Otherwise, you get stuff like this, which really doesn't work well on mobile because there's so much scrolling up and down:

question-card

The images in the previous student answers also need to be bounded:

q2

@vibhor98
Copy link
Contributor

Hi @tjiang11 Can I work on this? Secondly, where is the file for styling the images - css? Thanks!

@tjiang11
Copy link
Contributor

Hi @vibhor98 , sure! I don't know where the CSS for styling images are off-hand. You can try inspecting the browser and then grep-ing for the CSS selectors that you see there. Thanks!

@vibhor98
Copy link
Contributor

Hi @tjiang11 I have seen 'Welcome to Oppia! ' exploration and few others. But I was unable to see these large images anywhere. Can you help? Thanks!

@tjiang11
Copy link
Contributor

Hi @vibhor98 , I think @seanlip simply created these explorations as a demo on his local server.

@vibhor98
Copy link
Contributor

@tjiang11 Ok. So where can I find images in some other explorations so that I can grep from there to find the CSS file?

@tjiang11
Copy link
Contributor

Hi @vibhor98 , you can do the same thing seanlip did and reproduce it by using some large test images.

@vibhor98
Copy link
Contributor

@tjiang11 , I will try. Thanks!

@seanlip seanlip assigned AllanYangZhou and unassigned vibhor98 Dec 18, 2017
@seanlip
Copy link
Member Author

seanlip commented Dec 18, 2017

Fixed in #4229. Thanks @AllanYangZhou!

@seanlip seanlip closed this as completed Dec 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants