-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Images in ItemSelectionInput choices and answers are too big #4091
Comments
Hi @tjiang11 Can I work on this? Secondly, where is the file for styling the images - css? Thanks! |
Hi @vibhor98 , sure! I don't know where the CSS for styling images are off-hand. You can try inspecting the browser and then |
Hi @tjiang11 I have seen 'Welcome to Oppia! ' exploration and few others. But I was unable to see these large images anywhere. Can you help? Thanks! |
@tjiang11 Ok. So where can I find images in some other explorations so that I can grep from there to find the CSS file? |
Hi @vibhor98 , you can do the same thing seanlip did and reproduce it by using some large test images. |
@tjiang11 , I will try. Thanks! |
Fixed in #4229. Thanks @AllanYangZhou! |
If an item selection input interaction is created with images in the choices, we should bound the maximum height/width of the image. Otherwise, you get stuff like this, which really doesn't work well on mobile because there's so much scrolling up and down:
The images in the previous student answers also need to be bounded:
The text was updated successfully, but these errors were encountered: