Add check to enforce that all subclasses of BaseHandler end with "Handler"

[apb7]

All subclasses of BaseHandler (basically, all controllers) should end with "Handler". This issue keeps a track of the check which will enforce it.

[lilithxxx]

Just one question, should this test be in 'base_test.py'?

[apb7]

Hi Rishav! This should be placed in the pre_commit_linter.py script. The list of files modified is already available in this script. We might require some processing to implement this check then. Thanks!

…

On Sun, Sep 9, 2018, 5:41 PM Rishav Chakraborty ***@***.***> wrote: Just one question, should this test be in 'base_test.py'? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#5466 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AXrQua6jJSW1ZMpbHjAeo85vaWynqYXtks5uZQV3gaJpZM4V0TCN> .

[lilithxxx]

What should I do about those files which are inherited from the BaseHandler but does not end with the word? For example the classes in controllers/pages.py

[seanlip]

You'll probably need to change them (the main code) to follow the new lint requirement. When changing main code, make sure the automated tests still pass and that you test manually that everything still works properly.

[anubhavsinha98]

Is this issue open ?

[lilithxxx]

@anubhavsinha98 I am currently working on it

[anubhavsinha98]

okay @lilithxxx

[DubeySandeep]

@lilithxxx, any update on this?