Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong pointing of impact modal #6707

Open
import-keshav opened this issue May 7, 2019 · 19 comments
Open

Wrong pointing of impact modal #6707

import-keshav opened this issue May 7, 2019 · 19 comments
Labels
frontend Impact: Low -- DO NOT WORK ON THIS YET Postponing for now, since it doesn't affect users much. needs debugging Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet.

Comments

@import-keshav
Copy link
Contributor

import-keshav commented May 7, 2019

There is wrong pointing of impact modal.
When we click on the impact option on user profile page then a modal opens describing the impact of explorations created by the user. but the opened modal point in the wrong direction instead of pointing the impact score it points the bio of the user.

Screenshot from 2019-05-07 12-53-27

Steps to reproduce

  1. Go to any exploration on the test server example: Demo exploration 1)
  2. Hover over Author Profiles on the bottom left and click on the username.
  3. Browse the profile page
  4. Now click on impact score available below the user profile picture.
  5. Modal opens describing the impact of explorations created by the user.

Expected Behavior
It should point to the impact score, not bio.

@import-keshav
Copy link
Contributor Author

I want to confirm that is this the actual behavior or bug @seanlip @nithusha21.
Closed it if its actual behavior thanks!

@seanlip
Copy link
Member

seanlip commented May 7, 2019 via email

@import-keshav
Copy link
Contributor Author

Thanks, @seanlip for confirming.

@Dharmesh-Poddar
Copy link
Contributor

645
@import-keshav will that be ok ?

@import-keshav
Copy link
Contributor Author

Yes @Dharmesh-Poddar its correct
thanks

@Dharmesh-Poddar
Copy link
Contributor

Thanks @import-keshav .Making pr for it..

@import-keshav
Copy link
Contributor Author

import-keshav commented May 10, 2019

Thanks @Dharmesh-Poddar
But some points to say

  1. Please check this on different screen size.
  2. Also give a valid reason of whats the main cause of this error. Don't do just trial and error and also mention how you tackel this error.
    Thanks!

@DubeySandeep
Copy link
Member

@Dharmesh-Poddar, any update on this issue?

@Dharmesh-Poddar
Copy link
Contributor

@DubeySandeep I was getting issue at some small screen sizes

@import-keshav
Copy link
Contributor Author

Hello, @Dharmesh-Poddar can you please share your issue, so that we can to help you.
Thanks!

@DubeySandeep DubeySandeep added this to To do in Bug fixing team via automation Aug 14, 2019
@donosco99
Copy link
Contributor

donosco99 commented Nov 3, 2019

@DubeySandeep,@import-keshav I checked this issue in the test server and local development server recently,
but the popover doesn't have a pointer at all.
oppia
Was this change added recently or is it a bug?
Pls, have a look.

@seanlip
Copy link
Member

seanlip commented Nov 3, 2019

Hi @donosco98, I think it's a bug. The pointer needs to be added. Would it be possible to fix this?

Thanks!

@donosco99
Copy link
Contributor

sure i'll try this

@nithusha21 nithusha21 added this to Awaiting Triage in Learner and Creator Experience via automation Mar 4, 2020
@nithusha21 nithusha21 removed this from To do in Bug fixing team Mar 4, 2020
@iamprayush iamprayush moved this from Awaiting Triage to Medium Priority in Learner and Creator Experience Apr 4, 2020
@iamprayush
Copy link
Contributor

Hey @donosco98! Any updates?

@donosco99
Copy link
Contributor

Hi @iamprayush, Sorry for the late reply.
No, I couldn't work on this issue. You could take this up if you wish to.

@kevintab95 kevintab95 moved this from Medium Priority to Starter in Learner and Creator Experience Aug 16, 2020
@kevintab95 kevintab95 moved this from Starter to Learner Pages (@aks681) in Learner and Creator Experience Aug 30, 2020
@seanlip seanlip moved this from Lesson-Related Learner Pages (@aks681) to General learner-facing pages (@donosco98) in Learner and Creator Experience Aug 30, 2020
@donosco99 donosco99 moved this from General learner-facing pages (@donosco98) to Lesson-Related Learner Pages (@aks681) in Learner and Creator Experience Aug 30, 2020
@donosco99 donosco99 moved this from Lesson-Related Learner Pages (@aks681) to General learner-facing pages (@donosco98) in Learner and Creator Experience Aug 30, 2020
@rajni0829
Copy link

rajni0829 commented Jan 4, 2021

There is wrong pointing of impact modal.
When we click on the impact option on user profile page then a modal opens describing the impact of explorations created by the user. but the opened modal point in the wrong direction instead of pointing the impact score it points the bio of the user.

Screenshot from 2019-05-07 12-53-27

Steps to reproduce

  1. Go to any exploration on the test server example: Demo exploration 1)
  2. Hover over Author Profiles on the bottom left and click on the username.
  3. Browse the profile page
  4. Now click on impact score available below the user profile picture.
  5. Modal opens describing the impact of explorations created by the user.

Expected Behavior
It should point to the impact score, not bio.

I would be glad to solve this issue if permitted. @seanlip @anandwana001 @nithusha21 @DubeySandeep

@darksun27
Copy link
Contributor

@rajni0829 assigned to you.

@Nik-09 Nik-09 assigned Nik-09 and unassigned Nik-09 Feb 24, 2021
@Nik-09
Copy link
Member

Nik-09 commented Feb 24, 2021

This issue is still reproducing.
@rajni0829 can you please confirm that are you still wroking on this issue?

@Nik-09
Copy link
Member

Nik-09 commented Feb 25, 2021

@darksun27 @DubeySandeep I am working on this issue. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Impact: Low -- DO NOT WORK ON THIS YET Postponing for now, since it doesn't affect users much. needs debugging Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet.
Projects
Status: Todo
Development

No branches or pull requests

10 participants