Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User Profile Menu Fails to Expand on Mobile #7977

Open
U8NWXD opened this issue Nov 11, 2019 · 16 comments
Open

User Profile Menu Fails to Expand on Mobile #7977

U8NWXD opened this issue Nov 11, 2019 · 16 comments
Labels
bug Label to indicate an issue is a regression Impact: Medium Will improve quality-of-life for at least 30% of users. Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet.

Comments

@U8NWXD
Copy link
Member

U8NWXD commented Nov 11, 2019

Describe the bug
On mobile screens, the user profile menu at the top fails to expand.

To Reproduce
Steps to reproduce the behavior:

  1. Go to the splash screen on mobile
  2. Click on the user profile picture at the top

Observed behavior
The background behind the profile picture turns white, but no menu is visible.

Expected behavior
The menu should expand

Screenshots

OpiaBug_UserProfileMenuFail

Smartphone (please complete the following information; delete this section if the issue does not arise on smartphones):

  • Device: iPhone X (Simulated via Firefox)
  • Browser: Firefox
  • Version: 2.8.7
@U8NWXD
Copy link
Member Author

U8NWXD commented Nov 12, 2019

On iPhone (tested on hardware) the menu appears, but the background of the profile photo remains white when the menu is closed by tapping elsewhere on the menu bar. Tested on Safari and Firefox.

@seanlip seanlip added this to the Blocking bugs milestone Nov 12, 2019
@ankita240796 ankita240796 self-assigned this Nov 12, 2019
@ankita240796
Copy link
Contributor

Hi @U8NWXD, I am not able to reproduce this one as well.

Here are some tests:

  1. iPhone (hardware), Chrome:

chrome

  1. iPhone (hardware), Safari

safari

Can you please check and let me know if I am missing something, Thanks!

@U8NWXD
Copy link
Member Author

U8NWXD commented Nov 15, 2019

@ankita240796 I can still reproduce this error. Here's a screen recording:

user

I am testing on an iPhone 6 on iOS 12.4

@U8NWXD U8NWXD removed their assignment Nov 15, 2019
@ankita240796
Copy link
Contributor

I am sorry but I am still not able to reproduce this. @kevintab95 Can you please check once? Thanks!

@ankita240796
Copy link
Contributor

Hmm, on second thoughts. I am on iPhone 7+ and iOS 13.1.3. I think this may be specific to some devices in that case. I will test this on iPhone 6 once. Thanks!

@ankita240796
Copy link
Contributor

Hi @U8NWXD, I tried simulating this through on Inspect on iPhone 6 but it works fine for me.

@kevintab95 @DubeySandeep @seanlip can anyone of you please check this? Thanks!

@seanlip
Copy link
Member

seanlip commented Nov 20, 2019

I do see this when testing (simulating) with iPhone X in a Firefox desktop browser on Linux.

@seanlip
Copy link
Member

seanlip commented Nov 20, 2019

Incidentally, the hamburger menu is not working too. Clicking on it changes its symbol to a cross, but does nothing else.

@seanlip seanlip removed their assignment Nov 20, 2019
@ankita240796
Copy link
Contributor

Hi @seanlip, Do you also face this issue on hardware?

@ankita240796
Copy link
Contributor

ankita240796 commented Nov 20, 2019

Also, the hamburger issue was supposed to be fix by #8011. I am able to reproduce it too now on test server on iPhone 7+.

\cc @kevintab95

@seanlip
Copy link
Member

seanlip commented Nov 20, 2019

Don't have iPhone, sorry. But tried on Android phone -- I cannot reproduce the top right menu issue, but I am seeing the hamburger issue (both on test server).

@ankita240796
Copy link
Contributor

Ok, I just checked. I haven't deployed the PR to test server still but I have cherrypicked and checked on release branch and the hamburger issue does not exist. I will push and deploy and check once again.

@kevintab95
Copy link
Member

Hi @ankita240796, like you rightly pointed out, looks like the fix #8011 is not on the test server yet. Don't have an iPhone but I'm able to repro this on iPhone X (simulated on firefox). I can confirm that clicking on the User profile seems to work fine on Android though.

@U8NWXD any idea why this happens on your device?

@kevintab95 kevintab95 removed their assignment Nov 20, 2019
@kevintab95
Copy link
Member

kevintab95 commented Nov 20, 2019

Okay I suspect it has something to do with the "onmouseover" event. I tried disabling "touch simulation" in Firefox and it seems to work like @U8NWXD described in this comment*.

Edit:
But on Firefox the highlight disappears once you click outside the submenu.
I guess opening the submenu manually adds a :focus pseudoclass (focus class causes this highlight) and this does not seem to go away on the iPhone (harware) for some reason even on clicking outside the submenu.

navigation.openSubmenu = function(evt, menuName) {
// Focus on the current target before opening its submenu.
navigation.activeMenuName = menuName;
angular.element(evt.currentTarget).focus();
};

@ankita240796
Copy link
Contributor

Thanks for the analysis @kevintab95. I will try to look into it further and find a fix.

@ankita240796
Copy link
Contributor

Removing this from blocking bugs since it cannot be reproduced on mobile devices and only creates issue with Firefox simulation.

@ankita240796 ankita240796 removed their assignment Nov 23, 2019
@ankita240796 ankita240796 removed this from the Blocking bugs milestone Nov 23, 2019
@iamprayush iamprayush added this to Awaiting Triage in Learner and Creator Experience via automation Feb 12, 2020
@iamprayush iamprayush moved this from Awaiting Triage to Frontend in Learner and Creator Experience Feb 16, 2020
@aks681 aks681 moved this from Frontend to Medium Priority in Learner and Creator Experience Feb 22, 2020
@kevintab95 kevintab95 moved this from Medium Priority to Learner Pages in Learner and Creator Experience Aug 16, 2020
@kevintab95 kevintab95 moved this from Learner Pages to Editor Pages in Learner and Creator Experience Aug 16, 2020
@Showtim3 Showtim3 moved this from Editor Pages to Awaiting Triage in Learner and Creator Experience Aug 16, 2020
@kevintab95 kevintab95 moved this from Awaiting Triage to Learner Pages in Learner and Creator Experience Aug 18, 2020
@seanlip seanlip moved this from Lesson-Related Learner Pages (@aks681) to General learner-facing pages (@donosco98) in Learner and Creator Experience Aug 30, 2020
@kevintab95 kevintab95 added the bug Label to indicate an issue is a regression label Sep 1, 2022
@nithinrdy nithinrdy removed this from General learner-facing pages (@donosco98) in Learner and Creator Experience Oct 5, 2022
@SanjaySajuJacob SanjaySajuJacob added Impact: High Blocks or significantly slows down a core workflow. Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet. Impact: Medium Will improve quality-of-life for at least 30% of users. and removed Impact: Low -- DO NOT WORK ON THIS YET Postponing for now, since it doesn't affect users much. Impact: High Blocks or significantly slows down a core workflow. labels Dec 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Label to indicate an issue is a regression Impact: Medium Will improve quality-of-life for at least 30% of users. Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet.
Projects
Status: Todo
Development

No branches or pull requests

6 participants