Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing fraction input validator. #8687

Open
iamprayush opened this issue Feb 20, 2020 · 3 comments
Open

Missing fraction input validator. #8687

iamprayush opened this issue Feb 20, 2020 · 3 comments
Labels
bug Label to indicate an issue is a regression frontend Impact: Low -- DO NOT WORK ON THIS YET Postponing for now, since it doesn't affect users much. Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet.

Comments

@iamprayush
Copy link
Contributor

Describe the bug
As discussed in #8671, we need to add a validator for when the Fraction Input interaction is being created. This validator should disallow numbers with more than 7 digits in the fraction.
#8671 adds validator for the learner's input. We need a validator for creator's input as well.

Additional context
An audit job to alter any existing exploration with such inputs would also need to be added.

@iamprayush iamprayush added this to Awaiting Triage in Learner and Creator Experience via automation Feb 20, 2020
@iamprayush iamprayush moved this from Awaiting Triage to High Priority in Learner and Creator Experience Feb 23, 2020
@samruddhiDharankar
Copy link

@iamprayush would you point me to the frontend file where this issue is located?

@iamprayush
Copy link
Contributor Author

Hi @samruddhiDharankar!
This issue also involves writing an audit job which might be a little tricky since this is your first contribution. I suggest working on a couple of starter issues and then coming back to this one.
Also, make sure to read this page so that you don't miss anything important.
Thanks!

@samruddhiDharankar
Copy link

samruddhiDharankar commented Mar 14, 2020 via email

@kevintab95 kevintab95 moved this from High Priority to Interaction Issues in Learner and Creator Experience Aug 9, 2020
@kevintab95 kevintab95 added the bug Label to indicate an issue is a regression label Sep 1, 2022
@nithinrdy nithinrdy removed this from Interaction Issues (@iamprayush) in Learner and Creator Experience Oct 3, 2022
@Lawful2002 Lawful2002 added Impact: Low -- DO NOT WORK ON THIS YET Postponing for now, since it doesn't affect users much. Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet. labels Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Label to indicate an issue is a regression frontend Impact: Low -- DO NOT WORK ON THIS YET Postponing for now, since it doesn't affect users much. Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet.
Projects
Status: Todo
Development

No branches or pull requests

4 participants