Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the rich-text editor components have better (noneditable) previews #909

Closed
AllanYangZhou opened this issue Aug 19, 2015 · 4 comments
Closed
Assignees

Comments

@AllanYangZhou
Copy link
Contributor

Currently the rich-text component previews in the rich text editor are tiny icons. Ideally, these should resemble the actual learner's view instead.

The preview itself should not be editable, so we should investigate the possibility of using a non-editable 'island' within a contenteditable as our preview.

@seanlip seanlip changed the title Non-editable widget previews in RTE Make the RTE extensions have better (noneditable) previews Aug 19, 2015
@seanlip seanlip added this to the Amazing rich-text editor milestone Aug 19, 2015
@seanlip seanlip changed the title Make the RTE extensions have better (noneditable) previews Make the RTE components have better (noneditable) previews Aug 19, 2015
@seanlip seanlip changed the title Make the RTE components have better (noneditable) previews Make the rich-text editor components have better (noneditable) previews Aug 22, 2015
@seanlip
Copy link
Member

seanlip commented Dec 6, 2015

Hi @virajprabhu -- did you manage to take a look at this? If you need any help, please say!

@virajprabhu
Copy link
Contributor

Hi @seanlip - sorry, I haven't been able to get time to look at this. If this is high priority, could you please get someone else to take it on? I don't think I'll be able to work on this for another couple of weeks.

@seanlip
Copy link
Member

seanlip commented Apr 3, 2016

Update -- from a meeting @kahkhang, @AllanYangZhou and I had, we decided to just make Tabs, Collapsible, Image and Video into big blocks for now, and, in general, handle this issue via baby steps. A one-size-fits-all solution seems to be running into lots of problems (see #1426 and this doc), and doesn't seem feasible due to bugs in the underlying technologies (Firefox, textAngular).

@seanlip
Copy link
Member

seanlip commented May 11, 2016

Superseded by #1810 and #1811. Closing.

@seanlip seanlip closed this as completed May 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants