Fix part of #9827: Migrate Google App Engine Taskqueue to Cloud Tasks #10699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hird-party-installation
…hird-party-installation
…hird-party-installation
… pip-tools to local machine
…hird-party-installation
…hird-party-installation
…hird-party-installation
DubeySandeep
approved these changes
Sep 26, 2020
| @@ -935,6 +935,7 @@ def test_untag_deleted_misconceptions_correctly_on_updating_skill(self): | |||
| change_list, 'Delete misconceptions.') | |||
| skill_fetchers.get_skill_by_id('skillid12345') | |||
| self.process_and_flush_pending_tasks() | |||
There was a problem hiding this comment.
Ah good catch this was added as part of a merge. Removed.
|
Unassigning @DubeySandeep since they have already approved the PR. |
|
Unassigning @vojtechjelinek since they have already approved the PR. |
|
@U8NWXD PTAL! The PR is really large and new develop changes are repeatedly making the tests fail so I would like to merge this PR in asap. |
|
@sagangwee is out -- so, confirming no further reviewers are needed, and that this PR can be merged once all the CI checks pass. |
ankita240796
added
PR CHANGELOG: Developer UX -- @DubeySandeep
and removed
PR CHANGELOG: Miscellaneous -- @ankita240796
labels
|
@seanlip Could you please merge this PR? Thanks! |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR migrates the taskqueue functionality used in Oppia to the new Cloud Tasks service. However, the GAE MapReduce and Pipeline libraries actually use the old appengine taskqueue api so the oppia app will be using both apis for a time. This is ok for the time being since both apis interact with the same environment as confirmed here:
https://cloud.google.com/tasks/docs/migrating
This PR also contains a task queue emulator for both unit test and development server task operations that will now be maintained by oppia developers since GAE no longer provides support for an emulator.
NOTE: This PR still has not passed linter checks or has complete 100% backend coverage(some tests are missing). However, this allows for a first pass review for any issues that need to be fixed immediately.
Essential Checklist
PR Pointers