-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes part of #11462: Update install_backend_python_libs to respect direct urls from GitHub #12315
Conversation
Assigning @DubeySandeep for the first-pass review of this pull request. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for my codeowner files!
Unassigning @nithusha21 since they have already approved the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm as codeowner
Hi @brianrodri, the build of this PR is stale and this could result in tests failing in develop. Please update this pull request with the latest changes from develop. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for the coedeowner files.
… to respect direct urls from GitHub (oppia#12315)" This reverts commit ff7421e.
Hi @brianrodri It looks like this PR is creating an issue for developers while pushing the changes, see #12362 for more info! I'm initiating a revert PR for now, if you can create a PR to fix the issue quickly then we can merge that instead of revert! |
Overview
Essential Checklist
Proof that changes are correct
PR Pointers