Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes part of #11462: Update install_backend_python_libs to respect direct urls from GitHub #12315

Merged
merged 4 commits into from
Mar 27, 2021

Conversation

brianrodri
Copy link
Contributor

Overview

  1. This PR fixes or fixes part of Migrate from GAE user authentication to Firebase authentication #11462.
  2. This PR does the following: Currently we skip Git requirements, but that has proven to be unhelpful since it's important that very specific commits are installed. This PR updates the logic to require that a specific commit is installed, and re-installs when that's not the case.

Essential Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The linter/Karma presubmit checks have passed locally on your machine.
  • "Allow edits from maintainers" is checked. (See here for instructions on how to enable it.)
    • This lets reviewers restart your CircleCI tests for you.
  • The PR is made from a branch that's not called "develop".

Proof that changes are correct

PR Pointers

  • Make sure to follow the instructions for making a code change.
  • Oppiabot will notify you when you don't add a PR_CHANGELOG label. If you are unable to do so, please @-mention a code owner (who will be in the Reviewers list), or ask on Gitter.
  • For what code owners will expect, see the Code Owner's wiki page.
  • Make sure your PR follows conventions in the style guide, otherwise this will lead to review delays.
  • Never force push. If you do, your PR will be closed.
  • Oppiabot can assign anyone for review/help if you leave a comment like the following: "{{Question/comment}} @{{reviewer_username}} PTAL"
  • Some of the e2e tests are flaky, and can fail for reasons unrelated to your PR. We are working on fixing this, but in the meantime, if you need to restart the tests, please check the "If your build fails" wiki page.

@oppiabot
Copy link

oppiabot bot commented Mar 24, 2021

Assigning @DubeySandeep for the first-pass review of this pull request. Thanks!

@brianrodri brianrodri changed the title Update install_backend_python_libs to respect direct urls from GitHub Fixes part of #11462: Update install_backend_python_libs to respect direct urls from GitHub Mar 24, 2021
@brianrodri brianrodri added the PR: require post-merge sync to HEAD Require all open pull requests to be updated after this PR get's merged label Mar 24, 2021
Copy link
Member

@vojtechjelinek vojtechjelinek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vojtechjelinek vojtechjelinek removed their assignment Mar 24, 2021
Copy link
Contributor

@nithusha21 nithusha21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for my codeowner files!

@oppiabot
Copy link

oppiabot bot commented Mar 24, 2021

Unassigning @nithusha21 since they have already approved the PR.

@brianrodri brianrodri enabled auto-merge (squash) March 24, 2021 23:17
Copy link
Contributor

@aks681 aks681 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm as codeowner

@aks681 aks681 removed their assignment Mar 24, 2021
@oppiabot oppiabot bot added the PR: don't merge - STALE BUILD The build on this PR is stale and should be restarted. label Mar 26, 2021
@oppiabot
Copy link

oppiabot bot commented Mar 26, 2021

Hi @brianrodri, the build of this PR is stale and this could result in tests failing in develop. Please update this pull request with the latest changes from develop. Thanks!

@oppiabot oppiabot bot removed the PR: don't merge - STALE BUILD The build on this PR is stale and should be restarted. label Mar 26, 2021
Copy link
Member

@DubeySandeep DubeySandeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the coedeowner files.

This was referenced Mar 27, 2021
nisargsc added a commit to nisargsc/oppia that referenced this pull request Mar 29, 2021
… to respect direct urls from GitHub (oppia#12315)"

This reverts commit ff7421e.
@DubeySandeep
Copy link
Member

Hi @brianrodri It looks like this PR is creating an issue for developers while pushing the changes, see #12362 for more info!

I'm initiating a revert PR for now, if you can create a PR to fix the issue quickly then we can merge that instead of revert!

DubeySandeep added a commit that referenced this pull request Mar 29, 2021
…espect direct urls from GitHub (#12315)"

This reverts commit ff7421e.
seanlip pushed a commit that referenced this pull request Mar 29, 2021
…espect direct urls from GitHub (#12315)" (#12363)

This reverts commit ff7421e.
brianrodri added a commit that referenced this pull request Mar 29, 2021
…ibs to respect direct urls from GitHub (#12315)" (#12363)"

This reverts commit 218e4c6.
@brianrodri brianrodri deleted the direct-url-requirements branch March 29, 2021 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: LGTM PR: require post-merge sync to HEAD Require all open pull requests to be updated after this PR get's merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants