-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Part of #10474: Make Typescript checks strict for some files - (2) #13044
Conversation
some title
merged-with-develop
Hi @mridul-netizen. Due to recent changes in the "develop" branch, this PR now has a merge conflict. Please follow this link if you need help resolving the conflict, so that the PR can be merged. Thanks! |
'id': string | null; | ||
'title': string | null; | ||
'objective': string | null; | ||
'language_code': string | null; | ||
'tags': string[] | null; | ||
'schema_version': number | null; | ||
'category': string | null; | ||
'version': number | null; | ||
'playthrough_dict': CollectionPlaythroughBackendDict; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for explaining.
@kevintab95 @nithusha21 PTAL! |
Unassigning @srijanreddy98 since they have already approved the PR. |
Assigning @vojtechjelinek, @kevintab95, @nithusha21 for code owner reviews. Thanks! |
Hi @mridul-netizen. Due to recent changes in the "develop" branch, this PR now has a merge conflict. Please follow this link if you need help resolving the conflict, so that the PR can be merged. Thanks! |
Unassigning @nithusha21 since they have already approved the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for codeowner files. Thanks @mridul-netizen!
Overview
Essential Checklist
Proof that changes are correct
PR Pointers
Files Covered
PasteBin to Errors - link - (17 errors), (13 files)