-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix part of #10474: Enables strict typescript checks for some files - (2.2) #13394
Conversation
some title
merged-with-develop
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! One last small nit.
@@ -102,7 +102,10 @@ export class StoryContents { | |||
}); | |||
} | |||
|
|||
// If the node id is null, empty or undefined the function returns -1. | |||
// A nodeId will be null if the initial node does not exist. | |||
// A nodeId can be undefined if the nodesQueue(pending nodes to visit) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// A nodeId can be undefined if the nodesQueue(pending nodes to visit) | |
// A nodeId will be undefined if the pending nodes to visit are not present. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Hi @mridul-netizen, the build of this PR is stale and this could result in tests failing in develop. Please update this pull request with the latest changes from develop. Thanks! |
Unassigning @nithusha21 since they have already approved the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Unassigning @vojtechjelinek since they have already approved the PR. |
Hi @mridul-netizen. Due to recent changes in the "develop" branch, this PR now has a merge conflict. Please follow this link if you need help resolving the conflict, so that the PR can be merged. Thanks! |
Unassigning @srijanreddy98 since they have already approved the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for codeowner files. Thanks @mridul-netizen!
Unassigning @kevintab95 since they have already approved the PR. |
Overview
Essential Checklist
Proof that changes are correct
PR Pointers
Files Covered
PasteBin to Errors - link