Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix part of #10474: Enables strict typescript checks for some files - (2.2) #13394

Merged
merged 82 commits into from
Jul 26, 2021

Conversation

mridul-netizen
Copy link
Contributor

@mridul-netizen mridul-netizen commented Jul 13, 2021

Overview

  1. This PR fixes or fixes part of Make typescript checks strict #10474 .
  2. This PR does the following: [Make Typescript checks strict for some files]

Essential Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The linter/Karma presubmit checks have passed locally on your machine.
  • "Allow edits from maintainers" is checked. (See here for instructions on how to enable it.)
    • This lets reviewers restart your CircleCI tests for you.
  • The PR is made from a branch that's not called "develop".

Proof that changes are correct

image

PR Pointers

  • Make sure to follow the instructions for making a code change.
  • Oppiabot will notify you when you don't add a PR_CHANGELOG label. If you are unable to do so, please @-mention a code owner (who will be in the Reviewers list), or ask on Gitter.
  • For what code owners will expect, see the Code Owner's wiki page.
  • Make sure your PR follows conventions in the style guide, otherwise this will lead to review delays.
  • Never force push. If you do, your PR will be closed.
  • Oppiabot can assign anyone for review/help if you leave a comment like the following: "{{Question/comment}} @{{reviewer_username}} PTAL"
  • Some of the e2e tests are flaky, and can fail for reasons unrelated to your PR. We are working on fixing this, but in the meantime, if you need to restart the tests, please check the "If your build fails" wiki page.

Files Covered


1.      "core/templates/pages/exploration-editor-page/translation-tab/services/translation-language.service.ts",
2.      "core/templates/pages/exploration-editor-page/translation-tab/services/translation-language.service.spec.ts",
3.      "core/templates/domain/story/story-validation.service.ts",
4.      "core/templates/domain/story/story-validation.service.spec.ts",
5.      "core/templates/domain/improvements/task-entry.model.ts",
6.      "core/templates/domain/improvements/task-entry.model.spec.ts",
7.      "core/templates/components/state-editor/state-editor-properties-services/state-written-translations.service.ts",
8.      "core/templates/components/state-editor/state-editor-properties-services/state-solicit-answer-details.service.ts",
9.      "core/templates/components/state-editor/state-editor-properties-services/state-recorded-voiceovers.service.ts",
10.     "core/templates/components/state-editor/state-editor-properties-services/state-param-changes.service.ts",
11.     "core/templates/components/state-editor/state-editor-properties-services/state-param-changes.service.spec.ts",
12.     "core/templates/components/state-editor/state-editor-properties-services/state-next-content-id-index.service.ts",
13.     "core/templates/components/state-editor/state-editor-properties-services/state-interaction-id.service.ts",
14.     "core/templates/components/state-editor/state-editor-properties-services/state-interaction-id.service.spec.ts",
15.     "core/templates/components/state-editor/state-editor-properties-services/state-hints.service.ts",
16.     "core/templates/components/state-editor/state-editor-properties-services/state-hints.service.spec.ts", 
17.     "core/templates/components/state-editor/state-editor-properties-services/state-customization-args.service.ts",
18.     "core/templates/components/state-editor/state-editor-properties-services/state-content.service.ts",
19.     "core/templates/domain/collection/search-explorations-backend-api.service.ts",
20.     "core/templates/domain/collection/search-explorations-backend-api.service.spec.ts",
21.     "core/templates/domain/collection/collection-rights-backend-api.service.ts",
22.     "core/templates/domain/collection/collection-rights-backend-api.service.spec.ts",
23.     "core/templates/domain/classroom/classroom-backend-api.service.ts",
24.     "core/templates/domain/classroom/classroom-backend-api.service.spec.ts",
25.     "core/templates/domain/admin/admin-backend-api.service.ts",
26.     "core/templates/domain/admin/admin-backend-api.service.spec.ts",
27.     "extensions/rich_text_components/Video/directives/oppia-noninteractive-video.component.ts",
28.     "extensions/rich_text_components/Video/directives/oppia-noninteractive-video.component.spec.ts",
29.     "extensions/rich_text_components/Link/directives/oppia-noninteractive-link.component.ts",
30.     "extensions/rich_text_components/Link/directives/oppia-noninteractive-link.component.spec.ts",
31.     "core/templates/pages/exploration-editor-page/editor-tab/services/solution-validity.service.ts",
32.     "core/templates/pages/exploration-editor-page/editor-tab/services/solution-validity.service.spec.ts"
33.     "extensions/classifiers/classifiers-extension.constants.ajs.ts",
34.     "core/templates/domain/platform_feature/platform-feature-backend-api.service.ts",
35.     "core/templates/domain/platform_feature/platform-feature-backend-api.service.spec.ts",

PasteBin to Errors - link

Copy link
Member

@vojtechjelinek vojtechjelinek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! One last small nit.

@@ -102,7 +102,10 @@ export class StoryContents {
});
}

// If the node id is null, empty or undefined the function returns -1.
// A nodeId will be null if the initial node does not exist.
// A nodeId can be undefined if the nodesQueue(pending nodes to visit)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// A nodeId can be undefined if the nodesQueue(pending nodes to visit)
// A nodeId will be undefined if the pending nodes to visit are not present.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@vojtechjelinek vojtechjelinek removed their assignment Jul 21, 2021
@oppiabot oppiabot bot added the PR: don't merge - STALE BUILD The build on this PR is stale and should be restarted. label Jul 21, 2021
@oppiabot
Copy link

oppiabot bot commented Jul 21, 2021

Hi @mridul-netizen, the build of this PR is stale and this could result in tests failing in develop. Please update this pull request with the latest changes from develop. Thanks!

@oppiabot oppiabot bot removed the PR: don't merge - STALE BUILD The build on this PR is stale and should be restarted. label Jul 22, 2021
@oppiabot
Copy link

oppiabot bot commented Jul 22, 2021

Unassigning @nithusha21 since they have already approved the PR.

Copy link
Member

@vojtechjelinek vojtechjelinek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@oppiabot
Copy link

oppiabot bot commented Jul 22, 2021

Unassigning @vojtechjelinek since they have already approved the PR.

@mridul-netizen
Copy link
Contributor Author

@kevintab95 @srijanreddy98 PTAL

@oppiabot
Copy link

oppiabot bot commented Jul 24, 2021

Hi @mridul-netizen. Due to recent changes in the "develop" branch, this PR now has a merge conflict. Please follow this link if you need help resolving the conflict, so that the PR can be merged. Thanks!

@oppiabot
Copy link

oppiabot bot commented Jul 25, 2021

Unassigning @srijanreddy98 since they have already approved the PR.

Copy link
Member

@kevintab95 kevintab95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for codeowner files. Thanks @mridul-netizen!

@oppiabot
Copy link

oppiabot bot commented Jul 26, 2021

Unassigning @kevintab95 since they have already approved the PR.

@mridul-netizen mridul-netizen merged commit 9fa1e65 into oppia:develop Jul 26, 2021
@mridul-netizen mridul-netizen deleted the st-2.2 branch July 26, 2021 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants