-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate Library page #13498
Migrate Library page #13498
Conversation
Unassigning @srijanreddy98 since they have already approved the PR. |
Assigning @vojtechjelinek, @seanlip, @kevintab95, @nithusha21, @BenHenning, @aks681, @darksun27 for code owner reviews. Thanks! |
@ashutoshc8101, please lmk when this PR is ready to merge and I'll merge it. Thanks! |
Hi @ashutoshc8101. Due to recent changes in the "develop" branch, this PR now has a merge conflict. Please follow this link if you need help resolving the conflict, so that the PR can be merged. Thanks! |
@seanlip CI checks are passing now. PTAL |
Merging this, per discussion above. |
Overview
Everything same as #13412 except this commit 8362f7a
Why #13412 caused typescript checks to fail:
#12989 got merged just 1 hour before and #13412 didn't had the changes from #12989 during merge.
Essential Checklist
Proof that changes are correct
library-page-2021-07-17_15.02.12.mp4
PR Pointers