Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Library page #13498

Merged
merged 21 commits into from
Jul 27, 2021
Merged

Migrate Library page #13498

merged 21 commits into from
Jul 27, 2021

Conversation

ashutoshc8101
Copy link
Contributor

@ashutoshc8101 ashutoshc8101 commented Jul 26, 2021

Overview

  1. This PR fixes or fixes part of Migrate directives/controllers to Angular components #9749
  2. This PR does the following: Migrate library page.

Everything same as #13412 except this commit 8362f7a

Why #13412 caused typescript checks to fail:
#12989 got merged just 1 hour before and #13412 didn't had the changes from #12989 during merge.

Essential Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The linter/Karma presubmit checks have passed locally on your machine.
  • "Allow edits from maintainers" is checked. (See here for instructions on how to enable it.)
    • This lets reviewers restart your CircleCI tests for you.
  • The PR is made from a branch that's not called "develop".

Proof that changes are correct

library-page-2021-07-17_15.02.12.mp4

PR Pointers

  • Make sure to follow the instructions for making a code change.
  • Oppiabot will notify you when you don't add a PR_CHANGELOG label. If you are unable to do so, please @-mention a code owner (who will be in the Reviewers list), or ask on Gitter.
  • For what code owners will expect, see the Code Owner's wiki page.
  • Make sure your PR follows conventions in the style guide, otherwise this will lead to review delays.
  • Never force push. If you do, your PR will be closed.
  • Oppiabot can assign anyone for review/help if you leave a comment like the following: "{{Question/comment}} @{{reviewer_username}} PTAL"
  • Some of the e2e tests are flaky, and can fail for reasons unrelated to your PR. We are working on fixing this, but in the meantime, if you need to restart the tests, please check the "If your build fails" wiki page.

@oppiabot
Copy link

oppiabot bot commented Jul 26, 2021

Unassigning @srijanreddy98 since they have already approved the PR.

@oppiabot
Copy link

oppiabot bot commented Jul 26, 2021

Assigning @vojtechjelinek, @seanlip, @kevintab95, @nithusha21, @BenHenning, @aks681, @darksun27 for code owner reviews. Thanks!

@seanlip
Copy link
Member

seanlip commented Jul 26, 2021

@ashutoshc8101, please lmk when this PR is ready to merge and I'll merge it. Thanks!

@oppiabot
Copy link

oppiabot bot commented Jul 27, 2021

Hi @ashutoshc8101. Due to recent changes in the "develop" branch, this PR now has a merge conflict. Please follow this link if you need help resolving the conflict, so that the PR can be merged. Thanks!

@ashutoshc8101
Copy link
Contributor Author

@seanlip CI checks are passing now. PTAL

@seanlip
Copy link
Member

seanlip commented Jul 27, 2021

Merging this, per discussion above.

@seanlip seanlip enabled auto-merge (squash) July 27, 2021 15:08
@seanlip seanlip disabled auto-merge July 27, 2021 15:08
@seanlip seanlip merged commit 6b5d784 into oppia:develop Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants