Fix part of #13162: added schemas for SkillMasteryDataHandler

core/controllers/domain_objects_validator.py

@@ -26,11 +26,31 @@
 from core.domain import collection_domain
 from core.domain import config_domain
 from core.domain import exp_domain
+from core.domain import skill_domain
 from core.domain import state_domain
 
 from typing import Dict, Optional, Union
 
 
+def validate_mastery_change(mastery_change_per_skill):
+    """Validates user skill mastery changes.
+
+    Args:
+        mastery_change_per_skill: dict. Data that needs to be validated.
+
+    Returns:
+        dict(str, float). Returns mastery_change_per_skill after validation.
+    """
+    for (skill_id, mastery) in mastery_change_per_skill:
+        skill_domain.Skill.require_valid_skill_id(skill_id)
+        if not isinstance(mastery, float):
+            raise Exception(
+                'degree of mastery change should be a float, received'
+                ': %s' % mastery)
+
+    return mastery_change_per_skill
+
+
 def validate_exploration_change(obj):
     """Validates exploration change.
 

core/controllers/skill_mastery.py

@@ -21,6 +21,7 @@
 from core import utils
 from core.controllers import acl_decorators
 from core.controllers import base
+from core.controllers import domain_objects_validator
 from core.domain import skill_domain
 from core.domain import skill_fetchers
 from core.domain import skill_services
@@ -33,6 +34,25 @@ class SkillMasteryDataHandler(base.BaseHandler):
     """
 
     GET_HANDLER_ERROR_RETURN_TYPE = feconf.HANDLER_TYPE_JSON
+    URL_PATH_ARGS_SCHEMAS = {}
+    HANDLER_ARGS_SCHEMAS = {
+        'GET': {
+            'comma_separated_exp_ids': {
+                'schema': {
+                    'type': 'basestring'
+                }
+            }
+        },
+        'PUT': {
+            'mastery_change_per_skill': {
+                'schema': {
+                    'type': 'object_dict',
+                    'validation_method': (
+                        domain_objects_validator.validate_mastery_change)
+                }
+            }
+        }
+    }
 
     @acl_decorators.can_access_learner_dashboard
     def get(self):

core/handler_schema_constants.py

@@ -80,7 +80,6 @@
     'SiteLanguageHandler',
     'SkillDataHandler',
     'SkillDescriptionHandler',
-    'SkillMasteryDataHandler',
     'SkillsDashboardPageDataHandler',
     'StartedTranslationTutorialEventHandler',
     'StateCompleteEventHandler',