-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Catch errors at the time of javascript compilation #14849
Conversation
Hi @Hudda, can you complete the following:
|
Hi @Hudda, the build of this PR is stale and this could result in tests failing in develop. Please update this pull request with the latest changes from develop. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Hudda Thanks for the PR, do we need a backend test for this changes? (The coverage check is failing o this PR)
Added tests, @DubeySandeep PTAL! |
Hi @Hudda, there is a new change in develop which needs to be in your PR. Please update your branch with the latest changes in develop. For instructions, refer to this link. Thanks! |
Unassigning @DubeySandeep since they have already approved the PR. |
Hi @Hudda, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to merge this PR once the CI checks pass and you're happy with it. Thanks! |
Overview
1. This PR fixes or fixes part of #[fill_in_number_here].2. This PR does the following: Use check to catch errors during javascript compilation.
Essential Checklist
Proof that changes are correct
PR Pointers