Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix part of #14702: Add the stale tab detection functionality for topic editor page #15278

Merged
merged 45 commits into from Jun 16, 2022

Conversation

soumyo123-prog
Copy link
Contributor

@soumyo123-prog soumyo123-prog commented Apr 8, 2022

Overview

  1. This PR fixes or fixes part of Making changes to a stale topic editor page causes errors #14702
  2. This is PR 3 from This design doc
  3. This PR does the following:
  • Adds the modals for showing stale tab or unsaved changes warning.
  • Adds other relevant functions to topic editor page component.
  • Adds e2e tests for the functionality.

Essential Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The linter/Karma presubmit checks have passed locally on your machine.
  • "Allow edits from maintainers" is checked. (See here for instructions on how to enable it.)
    • This lets reviewers restart your CircleCI tests for you.
  • The PR is made from a branch that's not called "develop".

Proof that changes are correct

Screencast.from.10-04-22.04.14.20.PM.IST.mp4

PR Pointers

  • Make sure to follow the instructions for making a code change.
  • Oppiabot will notify you when you don't add a PR_CHANGELOG label. If you are unable to do so, please @-mention a code owner (who will be in the Reviewers list), or ask on Gitter.
  • For what code owners will expect, see the Code Owner's wiki page.
  • Make sure your PR follows conventions in the style guide, otherwise this will lead to review delays.
  • Never force push. If you do, your PR will be closed.
  • Oppiabot can assign anyone for review/help if you leave a comment like the following: "{{Question/comment}} @{{reviewer_username}} PTAL"
  • Some of the e2e tests are flaky, and can fail for reasons unrelated to your PR. We are working on fixing this, but in the meantime, if you need to restart the tests, please check the "If your build fails" wiki page.

@oppiabot
Copy link

oppiabot bot commented Apr 8, 2022

Hi @kevintab95, @nithusha21 -- could one of you please add the appropriate changelog label to this pull request? Thanks!

@soumyo123-prog
Copy link
Contributor Author

@kevintab95 I have made the changes.

@oppiabot
Copy link

oppiabot bot commented May 28, 2022

Hi @soumyo123-prog. Due to recent changes in the "develop" branch, this PR now has a merge conflict. Please follow this link if you need help resolving the conflict, so that the PR can be merged. Thanks!

Copy link
Member

@kevintab95 kevintab95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @soumyo123-prog!

@kevintab95 kevintab95 removed their assignment May 30, 2022
@oppiabot oppiabot bot added the PR: don't merge - STALE BUILD The build on this PR is stale and should be restarted. label May 31, 2022
@oppiabot
Copy link

oppiabot bot commented May 31, 2022

Hi @soumyo123-prog, the build of this PR is stale and this could result in tests failing in develop. Please update this pull request with the latest changes from develop. Thanks!

Copy link
Member

@aks681 aks681 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm as codeowner

@aks681 aks681 removed their assignment May 31, 2022
@soumyo123-prog soumyo123-prog removed the request for review from nithusha21 June 3, 2022 07:47
@oppiabot
Copy link

oppiabot bot commented Jun 10, 2022

Hi @soumyo123-prog, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 4 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 4 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale label Jun 10, 2022
@oppiabot oppiabot bot closed this Jun 14, 2022
@oppiabot oppiabot bot removed the stale label Jun 14, 2022
@oppiabot oppiabot bot removed PR: don't merge - STALE BUILD The build on this PR is stale and should be restarted. PR: don't merge - HAS MERGE CONFLICTS labels Jun 16, 2022
@soumyo123-prog
Copy link
Contributor Author

soumyo123-prog commented Jun 16, 2022

Dismissing @nithusha21 's review now as their comment (about adding new files in check_frontend_test_coverage.py) is now fixed.

@soumyo123-prog soumyo123-prog enabled auto-merge (squash) June 16, 2022 13:51
@soumyo123-prog soumyo123-prog dismissed nithusha21’s stale review June 16, 2022 13:52

Dismissing @nithusha21 's review now as their comment (about adding new files in check_frontend_test_coverage.py) is now fixed.

@soumyo123-prog soumyo123-prog merged commit 76db086 into oppia:develop Jun 16, 2022
soumyo123-prog added a commit that referenced this pull request Jun 17, 2022
seanlip pushed a commit that referenced this pull request Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants