Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pre-commit linter and release scripts #15608

Merged
merged 2 commits into from
Jun 20, 2022

Conversation

vojtechjelinek
Copy link
Member

Overview

  1. This PR fixes Unable to run the cut_release_or_hotfix_branch script #15600 and fixes Unable to commit after #15557 got merged #15606
  2. This PR does the following: Fixes more issues with importing typing_extensions

Essential Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The linter/Karma presubmit checks have passed locally on your machine.
  • "Allow edits from maintainers" is checked. (See here for instructions on how to enable it.)
    • This lets reviewers restart your CircleCI tests for you.
  • The PR is made from a branch that's not called "develop".

Proof that changes are correct

Proof of changes on desktop with slow/throttled network

Proof of changes on mobile phone

Proof of changes in Arabic language

PR Pointers

  • Make sure to follow the instructions for making a code change.
  • If you need a review or an answer to a question, and don't have permissions to assign people, leave a comment like the following: "{{Question/comment}} @{{reviewer_username}} PTAL". Oppiabot will help assign that person for you.
  • For what code owners will expect, see the Code Owner's wiki page.
  • Make sure your PR follows conventions in the style guide, otherwise this will lead to review delays.
  • Never force push. If you do, your PR will be closed.
  • Some of the e2e tests are flaky, and can fail for reasons unrelated to your PR. We are working on fixing this, but in the meantime, if you need to restart the tests, please check the "If your build fails" wiki page.

@oppiabot
Copy link

oppiabot bot commented Jun 20, 2022

Hi, @vojtechjelinek, this pull request does not have a "CHANGELOG: ..." label as mentioned in the PR pointers. Assigning @vojtechjelinek to add the required label. PRs without this label will not be merged. If you are unsure of which label to add, please ask the reviewers for guidance. Thanks!

Copy link
Contributor

@ankita240796 ankita240796 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for codeowner files, Thanks!

@ankita240796 ankita240796 removed their assignment Jun 20, 2022
@vojtechjelinek vojtechjelinek changed the title Fix precommit linter Fix pre-commit linter and release scripts Jun 20, 2022
@vojtechjelinek vojtechjelinek added the PR: require post-merge sync to HEAD Require all open pull requests to be updated after this PR get's merged label Jun 20, 2022
This was referenced Jun 20, 2022
@ankita240796 ankita240796 requested review from ankita240796 and removed request for ankita240796 October 19, 2022 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: require post-merge sync to HEAD Require all open pull requests to be updated after this PR get's merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to commit after #15557 got merged Unable to run the cut_release_or_hotfix_branch script
3 participants