-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
material icons changed #15972
material icons changed #15972
Conversation
Hi @nettle790, can you complete the following:
|
Hi @krishita30j, could you please add the appropriate changelog label to this pull request? Thanks! |
Hi! @nettle790 Welcome to Oppia! Could you please follow the instructions here and sign the CLA Sheet to get started? You'll need to do this before we can accept your PR. Thanks! |
Please check if the issues are set right. I have set the closest |
Hi please run ci tests from your end.I am just learning how to implement them.
…Sent from my iPhone
On 01-Sep-2022, at 11:33 PM, oppiabot[bot] ***@***.***> wrote:
Hi @nettle790, can you complete the following:
The body of this PR is missing the overview section, please update it to include the overview.
The body of this PR is missing the checklist section, please update it to include the checklist.
The body of this PR is missing the proof that changes are correct section, please update it to include the section.
Thanks!
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were assigned.
|
@nettle790 Thank you for your PR. Please note the following:
I am closing this PR because it does not follow our pull request guidelines, but feel free to open a new PR when you have those screenshots and filled out the template correctly so that it can be properly reviewed. Thanks! |
I would like to know if a bot is running the pr tests?I am new to testing.would anyone be helpful enough to enlighten me as to how to run checks for my code before opening a pr?? |
Please unassign me from the files 3,4,5.I need to learn how to test the codes before submitting pr.
Thanks for giving me an opportunity to participate.
…Sent from my iPhone
On 02-Sep-2022, at 5:04 AM, Sean Lip ***@***.***> wrote:
Closed #15972.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.
|
Hi @nettle790, there is a lot of information on the wiki about testing. Please see the wiki sidebar for the relevant links, and take a moment to read about it. I'll unassign you from the original issue, thanks. Also, if you have further general questions, we recommend using our GitHub Discussions page. But try and find the information you are looking for on the wiki first, since that is fairly comprehensive and is likely to have what you need. Thanks! |
This is with reference to issue #15968.
The material icons have been replaced by the closest matching fontawesome icons.
Html boilerplate added and appropriate css changes made to the closest possible.
before in file #3
after in file #3
before in #4
after in file #4
before in file #5
after in file #5