Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

material icons changed #15972

Closed
wants to merge 1 commit into from
Closed

material icons changed #15972

wants to merge 1 commit into from

Conversation

nettle790
Copy link

This is with reference to issue #15968.
The material icons have been replaced by the closest matching fontawesome icons.
Html boilerplate added and appropriate css changes made to the closest possible.

before in file #3
 before3

after in file #3
 after3

before in #4
 before4

after in file #4
 after4

before in file #5
 before5

after in file #5
 after5

@nettle790 nettle790 requested a review from a team as a code owner September 1, 2022 18:02
@oppiabot
Copy link

oppiabot bot commented Sep 1, 2022

Hi @nettle790, can you complete the following:

  1. The body of this PR is missing the overview section, please update it to include the overview.
  2. The body of this PR is missing the checklist section, please update it to include the checklist.
  3. The body of this PR is missing the proof that changes are correct section, please update it to include the section.
    Thanks!

@oppiabot
Copy link

oppiabot bot commented Sep 1, 2022

Hi @krishita30j, could you please add the appropriate changelog label to this pull request? Thanks!

@github-actions
Copy link

github-actions bot commented Sep 1, 2022

Hi! @nettle790 Welcome to Oppia! Could you please follow the instructions here and sign the CLA Sheet to get started? You'll need to do this before we can accept your PR. Thanks!

@nettle790
Copy link
Author

Please check if the issues are set right. I have set the closest
icon counterparts from font awesome.

@nettle790
Copy link
Author

nettle790 commented Sep 1, 2022 via email

@seanlip
Copy link
Member

seanlip commented Sep 1, 2022

@nettle790 Thank you for your PR. Please note the following:

  • Please follow the PR template. It has a place for you to provide screenshots of the pages loading correctly on your local server (which you should have set up as part of installing Oppia for local development per the setup instructions). This is important because we want to make sure that this PR does not break the Oppia website, and we can't see any guarantee of that without seeing those screenshots.

I am closing this PR because it does not follow our pull request guidelines, but feel free to open a new PR when you have those screenshots and filled out the template correctly so that it can be properly reviewed. Thanks!

@seanlip seanlip closed this Sep 1, 2022
@nettle790
Copy link
Author

I would like to know if a bot is running the pr tests?I am new to testing.would anyone be helpful enough to enlighten me as to how to run checks for my code before opening a pr??

@nettle790 nettle790 deleted the icon-change branch September 2, 2022 14:57
@nettle790
Copy link
Author

nettle790 commented Sep 2, 2022 via email

@seanlip
Copy link
Member

seanlip commented Sep 2, 2022

Hi @nettle790, there is a lot of information on the wiki about testing. Please see the wiki sidebar for the relevant links, and take a moment to read about it.

I'll unassign you from the original issue, thanks.

Also, if you have further general questions, we recommend using our GitHub Discussions page. But try and find the information you are looking for on the wiki first, since that is fairly comprehensive and is likely to have what you need. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants