(Contributor Recognition Infrastructure) Milestone 2.1: Add new frontend endpoints to call the ContributorStatsSummariesHandler #16153

chris7716 · 2022-09-27T15:35:34Z

Overview

This PR fixes or fixes part of n/a.
This PR does the following:

Adds the required frontend services to fetch stats
Doc https://docs.google.com/document/d/16SciF9u-AngOdmvBaSyjYCAYrppR6lTE-S2vwhhh86A/edit#

Essential Checklist

The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
The linter/Karma presubmit checks have passed locally on your machine.
"Allow edits from maintainers" is checked. (See here for instructions on how to enable it.)
- This lets reviewers restart your CircleCI tests for you.
The PR is made from a branch that's not called "develop".

Proof that changes are correct

Proof of changes on desktop with slow/throttled network

Proof of changes on mobile phone

Proof of changes in Arabic language

PR Pointers

Make sure to follow the instructions for making a code change.
If you need a review or an answer to a question, and don't have permissions to assign people, leave a comment like the following: "{{Question/comment}} @{{reviewer_username}} PTAL". Oppiabot will help assign that person for you.
For what code owners will expect, see the Code Owner's wiki page.
Make sure your PR follows conventions in the style guide, otherwise this will lead to review delays.
Never force push. If you do, your PR will be closed.
Some of the e2e tests are flaky, and can fail for reasons unrelated to your PR. We are working on fixing this, but in the meantime, if you need to restart the tests, please check the "If your build fails" wiki page.

Merged with uostream

merged with develop

uptodated

Update branch

Update local

oppiabot · 2022-09-27T15:35:47Z

Hi @seanlip, @gp201 -- could one of you please add the appropriate changelog label to this pull request? Thanks!

seanlip

Looked at 2 codeowner files, just one comment for now

seanlip · 2022-09-28T08:27:34Z

...templates/pages/contributor-dashboard-page/services/contribution-and-review-stats.service.ts

+    return (
+      this.contributionAndReviewStatsBackendApiService
+        .fetchContributionAndReviewStatsAsync(
+          'translation', 'submission', username));


These hardcoded strings ought to be named constants / enums, I think.

Also these are four roundtrip calls. How long does each take? I'm wondering about this strategy vs batching the GET into a single one.

These hardcoded strings ought to be named constants / enums, I think.

Done

How long does each take?

Translation Submissions -> 0.0019922256469726562 s Translation Reviews -> 0.002099275588989258 s Question Submissions -> 0.0017049312591552734 s Question Reviews -> 0.0022652149200439453 s ------------------------------------------------------ Total -> 0.00806164741 s

Also I have a separate endpoint fetch all stats at once in case to fetch everything from one request. It takes 0.008791923522949219 s.

Just to check, these are being measured starting from the frontend? Could you show a screenshot of where the measurement was done from? I'm a bit surprised because I'd have thought the network latency itself would be larger than this.

Ah, I just checked it in the backend.

This when they are fetched from the frontend. The first record with 126 ms corresponds to fetch everything from one request. The other four correspond for fetching stats for translation submissions, translation reviews, question submissions and question reviews.

gp201

LGTM for codeowner files

oppiabot · 2022-10-10T09:00:14Z

Hi @chris7716, there is a new change in develop which needs to be in your PR. Please update your branch with the latest changes in develop. For instructions, refer to this link. Thanks!

chris7716 · 2022-10-13T06:52:45Z

@seanlip PTAL. Thanks!

oppiabot · 2022-10-13T06:55:48Z

Unassigning @chris7716 since a re-review was requested. @chris7716, please make sure you have addressed all review comments. Thanks!

seanlip · 2022-10-13T07:30:14Z

@ashutoshc8101 PTAL for codeowners.

ashutoshc8101

LGTM for codeowners.

oppiabot · 2022-10-13T07:35:33Z

Unassigning @ashutoshc8101 since they have already approved the PR.

seanlip

Thanks @chris7716! OK, sounds like there isn't much difference then. I think the rest of the PR looks good.

oppiabot · 2022-10-13T22:34:57Z

Hi @chris7716, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to merge this PR once the CI checks pass and you're happy with it. Thanks!

chris7716 and others added 15 commits January 10, 2021 01:32

service file name changed to backend-api

c798e78

backend api file added

218b79c

previous service file removed from CODEOWNERS

d03d579

new backend service file added to CODEOWNERS

536a551

Merge remote-tracking branch 'upstream/develop' into develop

b853c9a

Merged with uostream

Merge remote-tracking branch 'upstream/develop' into develop

cab061f

merged with develop

Merge remote-tracking branch 'upstream/develop' into develop

7f746b9

uptodated

Merge branch 'oppia:develop' into develop

63a9988

Merge branch 'oppia:develop' into develop

40e6c29

Merge branch 'develop' of https://github.com/oppia/oppia into develop

1e042a8

Update branch

Merge branch 'develop' of https://github.com/oppia/oppia into develop

6d2e59b

Update branch

Merge branch 'develop' of https://github.com/oppia/oppia into develop

ec06909

Update local

Merge branch 'develop' of https://github.com/oppia/oppia into develop

82b8dae

Update local

First pass

ac53598

First pass

e211ca5

chris7716 requested a review from a team September 27, 2022 15:35

chris7716 requested a review from a team as a code owner September 27, 2022 15:35

chris7716 requested review from a team, gp201, seanlip and heyimShivam September 27, 2022 15:35

oppiabot bot added the REVIEWERS: Please add changelog label label Sep 27, 2022

oppiabot bot assigned gp201 and seanlip Sep 27, 2022

seanlip requested changes Sep 28, 2022

View reviewed changes

seanlip assigned chris7716 and unassigned seanlip Sep 28, 2022

gp201 approved these changes Sep 29, 2022

View reviewed changes

gp201 removed their assignment Sep 29, 2022

chris7716 added 2 commits October 12, 2022 22:06

Make small change

2173fcb

Add constants

58d21d8

chris7716 requested review from a team and ashutoshc8101 October 12, 2022 16:45

oppiabot bot removed the PR: don't merge - STALE BUILD The build on this PR is stale and should be restarted. label Oct 12, 2022

Update branch

30bfaef

oppiabot bot removed the PR: don't merge - HAS MERGE CONFLICTS label Oct 12, 2022

vojtechjelinek added PR CHANGELOG: Contributor Pages -- @sagangwee and removed REVIEWERS: Please add changelog label labels Oct 12, 2022

oppiabot bot assigned seanlip and unassigned chris7716 Oct 13, 2022

seanlip assigned chris7716 and ashutoshc8101 and unassigned seanlip Oct 13, 2022

ashutoshc8101 approved these changes Oct 13, 2022

View reviewed changes

oppiabot bot unassigned ashutoshc8101 Oct 13, 2022

chris7716 requested a review from seanlip October 13, 2022 18:07

chris7716 assigned seanlip and unassigned chris7716 Oct 13, 2022

seanlip approved these changes Oct 13, 2022

View reviewed changes

seanlip assigned chris7716 and unassigned seanlip Oct 13, 2022

oppiabot bot added the PR: LGTM label Oct 13, 2022

chris7716 merged commit 2375a02 into oppia:develop Oct 14, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

(Contributor Recognition Infrastructure) Milestone 2.1: Add new frontend endpoints to call the ContributorStatsSummariesHandler #16153

(Contributor Recognition Infrastructure) Milestone 2.1: Add new frontend endpoints to call the ContributorStatsSummariesHandler #16153

chris7716 commented Sep 27, 2022

oppiabot bot commented Sep 27, 2022

seanlip left a comment

seanlip Sep 28, 2022

chris7716 Oct 13, 2022

seanlip Oct 13, 2022 •

edited

chris7716 Oct 13, 2022

gp201 left a comment

oppiabot bot commented Oct 10, 2022

chris7716 commented Oct 13, 2022

oppiabot bot commented Oct 13, 2022

seanlip commented Oct 13, 2022

ashutoshc8101 left a comment

oppiabot bot commented Oct 13, 2022

seanlip left a comment

oppiabot bot commented Oct 13, 2022

(Contributor Recognition Infrastructure) Milestone 2.1: Add new frontend endpoints to call the ContributorStatsSummariesHandler #16153

(Contributor Recognition Infrastructure) Milestone 2.1: Add new frontend endpoints to call the ContributorStatsSummariesHandler #16153

Conversation

chris7716 commented Sep 27, 2022

Overview

Essential Checklist

Proof that changes are correct

Proof of changes on desktop with slow/throttled network

Proof of changes on mobile phone

Proof of changes in Arabic language

PR Pointers

oppiabot bot commented Sep 27, 2022

seanlip left a comment

Choose a reason for hiding this comment

seanlip Sep 28, 2022

Choose a reason for hiding this comment

chris7716 Oct 13, 2022

Choose a reason for hiding this comment

seanlip Oct 13, 2022 • edited

Choose a reason for hiding this comment

chris7716 Oct 13, 2022

Choose a reason for hiding this comment

gp201 left a comment

Choose a reason for hiding this comment

oppiabot bot commented Oct 10, 2022

chris7716 commented Oct 13, 2022

oppiabot bot commented Oct 13, 2022

seanlip commented Oct 13, 2022

ashutoshc8101 left a comment

Choose a reason for hiding this comment

oppiabot bot commented Oct 13, 2022

seanlip left a comment

Choose a reason for hiding this comment

oppiabot bot commented Oct 13, 2022

seanlip Oct 13, 2022 •

edited