Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix part of #15968: Replace material icons with FA icons #16227

Merged

Conversation

Sakshi-75
Copy link
Contributor

@Sakshi-75 Sakshi-75 commented Oct 6, 2022

Overview

  1. This PR fixes part of Replace Material Icons with Font Awesome icons #15968.
  2. This PR does the following: In this PR the material icons have been replaced with their respective Font Awesome icons for the following files:
  • oppia/core/templates/components/summary-tile/collection-summary-tile.component.html
  • oppia/core/templates/components/summary-tile/exploration-summary-tile.component.html
  • oppia/core/templates/components/summary-tile/story-summary-tile.component.html

Essential Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The linter/Karma presubmit checks have passed locally on your machine.
  • "Allow edits from maintainers" is checked. (See here for instructions on how to enable it.)
    • This lets reviewers restart your CircleCI tests for you.
  • The PR is made from a branch that's not called "develop".

Proof that changes are correct

Proof of changes on desktop with slow/throttled network

  • oppia/core/templates/components/summary-tile/collection-summary-tile.component.html
  1. Bullet separator:
    Before:
    collection_summary_before_cropped
    After:
    collection_summary_after_cropped
  • oppia/core/templates/components/summary-tile/exploration-summary-tile.component.html
  1. Bullet separator:
    Before:
    exploration_summary_before_cropped
    After:
    exploration_summary_after_cropped
  • oppia/core/templates/components/summary-tile/story-summary-tile.component.html
  1. Up arrow
    Before:
    story_summary_up_before_cropped
    After:
    story_summary_up_after_cropped

  2. Down arrow
    Before:
    story_summary_down_before_cropped
    After:
    story_summary_down_after_cropped

  3. Done
    Before:
    story_summary_done_before_cropped
    After:
    story_summary_done_after_cropped

  4. Up arrow (mobile view)
    Before:
    story_summary_up_mobile_before_cropped
    After:
    story_summary_up_mobile_after_cropped

  5. Down arrow (mobile view)
    Before:
    story_summary_down_mobile_before_cropped
    After:
    story_summary_down_mobile_after_cropped

Proof of changes on mobile phone

Proof of changes in Arabic language

PR Pointers

  • Make sure to follow the instructions for making a code change.
  • If you need a review or an answer to a question, and don't have permissions to assign people, leave a comment like the following: "{{Question/comment}} @{{reviewer_username}} PTAL". Oppiabot will help assign that person for you.
  • For what code owners will expect, see the Code Owner's wiki page.
  • Make sure your PR follows conventions in the style guide, otherwise this will lead to review delays.
  • Never force push. If you do, your PR will be closed.
  • Some of the e2e tests are flaky, and can fail for reasons unrelated to your PR. We are working on fixing this, but in the meantime, if you need to restart the tests, please check the "If your build fails" wiki page.

@Sakshi-75 Sakshi-75 requested review from a team October 6, 2022 17:26
@oppiabot
Copy link

oppiabot bot commented Oct 6, 2022

Hi @Sakshi-75, can you complete the following:

  1. The karma and linter checklist has not been checked, please make sure to run the frontend tests and lint tests before pushing.
    Thanks!

@oppiabot
Copy link

oppiabot bot commented Oct 6, 2022

Hi @ashutoshc8101, could you please add the appropriate changelog label to this pull request? Thanks!

@Sakshi-75 Sakshi-75 marked this pull request as draft October 6, 2022 21:00
@Sakshi-75 Sakshi-75 marked this pull request as ready for review October 7, 2022 05:39
@oppiabot
Copy link

oppiabot bot commented Oct 7, 2022

Unassigning @ashutoshc8101 since they have already approved the PR.

@oppiabot oppiabot bot added the PR: LGTM label Oct 7, 2022
@ShivamJhaa ShivamJhaa merged commit 47895be into oppia:develop Oct 7, 2022
@vojtechjelinek vojtechjelinek changed the title "Fix part of #15968: Replace material icons with FA icons Fix part of #15968: Replace material icons with FA icons Oct 7, 2022
aaronlwan pushed a commit to aaronlwan/oppia that referenced this pull request Oct 9, 2022
…#16227)

* replace bullet separator material icon with FA icon

* replace bullet separator material icon with FA icon for collection summary

* replace material icons with FA for story summary

* Fix linting error

* Fix linting error

* Fix linting error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants