New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix part of #15968: Replace material icons with FA icons #16227
Merged
ShivamJhaa
merged 11 commits into
oppia:develop
from
Sakshi-75:replace-material-icons-with-FA-icons
Oct 7, 2022
Merged
Fix part of #15968: Replace material icons with FA icons #16227
ShivamJhaa
merged 11 commits into
oppia:develop
from
Sakshi-75:replace-material-icons-with-FA-icons
Oct 7, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….com/Sakshi-75/oppia into replace-material-icons-with-FA-icons
Hi @Sakshi-75, can you complete the following:
|
Hi @ashutoshc8101, could you please add the appropriate changelog label to this pull request? Thanks! |
….com/Sakshi-75/oppia into replace-material-icons-with-FA-icons
ashutoshc8101
approved these changes
Oct 7, 2022
Unassigning @ashutoshc8101 since they have already approved the PR. |
vojtechjelinek
changed the title
"Fix part of #15968: Replace material icons with FA icons
Fix part of #15968: Replace material icons with FA icons
Oct 7, 2022
vojtechjelinek
added
PR CHANGELOG: Speed improvement -- @vojtechjelinek
and removed
REVIEWERS: Please add changelog label
labels
Oct 7, 2022
aaronlwan
pushed a commit
to aaronlwan/oppia
that referenced
this pull request
Oct 9, 2022
…#16227) * replace bullet separator material icon with FA icon * replace bullet separator material icon with FA icon for collection summary * replace material icons with FA for story summary * Fix linting error * Fix linting error * Fix linting error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Essential Checklist
Proof that changes are correct
Proof of changes on desktop with slow/throttled network
Before:
After:
Before:
After:
Up arrow
Before:
After:
Down arrow
Before:
After:
Done
Before:
After:
Up arrow (mobile view)
Before:
After:
Down arrow (mobile view)
Before:
After:
Proof of changes on mobile phone
Proof of changes in Arabic language
PR Pointers