Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #16830: Remove unclear sentence from save progress popup #16838

Merged
merged 16 commits into from
Feb 7, 2023
Merged

Fix #16830: Remove unclear sentence from save progress popup #16838

merged 16 commits into from
Feb 7, 2023

Conversation

Kej-r03
Copy link
Contributor

@Kej-r03 Kej-r03 commented Jan 5, 2023

Overview

  1. This PR fixes Unclear sentence in the save progress popup. #16830.
  2. This PR does the following: [Removes the ambiguous sentence in the save progress popup.]
    oppia

Essential Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The linter/Karma presubmit checks have passed locally on your machine.
  • "Allow edits from maintainers" is checked. (See here for instructions on how to enable it.)
    • This lets reviewers restart your CircleCI tests for you.
  • The PR is made from a branch that's not called "develop".

Proof that changes are correct

Proof of changes on desktop with slow/throttled network

Proof of changes on mobile phone

Proof of changes in Arabic language

PR Pointers

  • Make sure to follow the instructions for making a code change.
  • If you need a review or an answer to a question, and don't have permissions to assign people, leave a comment like the following: "{{Question/comment}} @{{reviewer_username}} PTAL". Oppiabot will help assign that person for you.
  • For what code owners will expect, see the Code Owner's wiki page.
  • Make sure your PR follows conventions in the style guide, otherwise this will lead to review delays.
  • Never force push. If you do, your PR will be closed.
  • Some of the e2e tests are flaky, and can fail for reasons unrelated to your PR. We are working on fixing this, but in the meantime, if you need to restart the tests, please check the "If your build fails" wiki page.

@Kej-r03 Kej-r03 requested a review from a team January 5, 2023 21:33
@Kej-r03 Kej-r03 requested a review from a team as a code owner January 5, 2023 21:33
@oppiabot
Copy link

oppiabot bot commented Jan 5, 2023

Hi @JayVivarekar, @aasiffaizal -- could one of you please add the appropriate changelog label to this pull request? Thanks!

aasiffaizal
aasiffaizal suggested changes Jan 6, 2023
View reviewed changes
Copy link
Contributor

@aasiffaizal aasiffaizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we remove it from the below file as well?

oppia/assets/i18n/qqq.json

Line 1125 in ab66f74

"I18N_SAVE_EXPLORATION_PROGRESS_TEXT_4": "Text displayed on the save progress menu of exploration lesson info modal telling the users that the progress URL generated will save their progress for the next 72 hours only.",

@oppiabot
Copy link

oppiabot bot commented Jan 6, 2023

Unassigning @aasiffaizal since the review is done.

@oppiabot
Copy link

oppiabot bot commented Jan 6, 2023

Hi @Kej-r03, it looks like some changes were requested on this pull request by @aasiffaizal. PTAL. Thanks!

@vojtechjelinek vojtechjelinek changed the title Remove unclear sentence from save progress popup Fix #16830: Remove unclear sentence from save progress popup Jan 7, 2023
@vojtechjelinek
Copy link
Member

@Kej-r03 In your screenshot the text to copy seems to be kinda broken, can you also fix that?

image

@oppiabot oppiabot bot added the PR: don't merge - STALE BUILD The build on this PR is stale and should be restarted. label Jan 8, 2023
@oppiabot
Copy link

oppiabot bot commented Jan 8, 2023

Hi @Kej-r03, the build of this PR is stale and this could result in tests failing in develop. Please update this pull request with the latest changes from develop. Thanks!

@nithinrdy
Copy link
Contributor

Changes look good, but the section containing the link to be copied seems broken (although it appears to be unrelated to the changes, so I'm not sure why), please take a look!

@nithinrdy nithinrdy removed their assignment Jan 9, 2023
@oppiabot oppiabot bot removed the PR: don't merge - STALE BUILD The build on this PR is stale and should be restarted. label Jan 9, 2023
@Kej-r03 Kej-r03 requested a review from a team as a code owner January 9, 2023 18:11
@Kej-r03
Copy link
Contributor Author

Kej-r03 commented Feb 2, 2023

@nithinrdy I am getting this after merging the develop in my save-progress-fix branch
opp

nithinrdy
nithinrdy suggested changes Feb 2, 2023
View reviewed changes
Copy link
Contributor

@nithinrdy nithinrdy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kej-r03 the left edge of the div containing the url is supposed to be aligned with the text, like so:
image

Should be a quick CSS change, could you PTAL?

@oppiabot oppiabot bot unassigned nithinrdy Feb 2, 2023
@oppiabot
Copy link

oppiabot bot commented Feb 2, 2023

Unassigning @nithinrdy since the review is done.

@oppiabot
Copy link

oppiabot bot commented Feb 2, 2023

Hi @Kej-r03, it looks like some changes were requested on this pull request by @nithinrdy. PTAL. Thanks!

@Kej-r03
Copy link
Contributor Author

Kej-r03 commented Feb 2, 2023

op

@nithinrdy Hopefully this solves the issue.

nithinrdy
nithinrdy approved these changes Feb 3, 2023
View reviewed changes
Copy link
Contributor

@nithinrdy nithinrdy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nithinrdy
Copy link
Contributor

@aasiffaizal PTAL

paprajapati9
paprajapati9 approved these changes Feb 3, 2023
View reviewed changes
Copy link
Contributor

@paprajapati9 paprajapati9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@paprajapati9 paprajapati9 removed their assignment Feb 3, 2023
@oppiabot oppiabot bot added the PR: don't merge - STALE BUILD The build on this PR is stale and should be restarted. label Feb 5, 2023
@oppiabot
Copy link

oppiabot bot commented Feb 5, 2023

Hi @Kej-r03, the build of this PR is stale and this could result in tests failing in develop. Please update this pull request with the latest changes from develop. Thanks!

@Kej-r03
Copy link
Contributor Author

Kej-r03 commented Feb 5, 2023

@aasiffaizal PTAL

@oppiabot oppiabot bot assigned aasiffaizal and unassigned Kej-r03 Feb 5, 2023
@oppiabot
Copy link

oppiabot bot commented Feb 5, 2023

Unassigning @Kej-r03 since a re-review was requested. @Kej-r03, please make sure you have addressed all review comments. Thanks!

aasiffaizal
aasiffaizal approved these changes Feb 5, 2023
View reviewed changes
Copy link
Contributor

@aasiffaizal aasiffaizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aasiffaizal aasiffaizal removed their assignment Feb 5, 2023
@oppiabot oppiabot bot added the PR: LGTM label Feb 5, 2023
@oppiabot
Copy link

oppiabot bot commented Feb 5, 2023

Hi @aks681, this PR is ready to be merged. Author of this PR does not have permissions to merge this PR. Before you merge it, please make sure that there are no pending comments that require action from the author's end. Thanks!

@oppiabot oppiabot bot assigned aks681 Feb 5, 2023
@oppiabot oppiabot bot removed the PR: don't merge - STALE BUILD The build on this PR is stale and should be restarted. label Feb 7, 2023
@Kej-r03
Copy link
Contributor Author

Kej-r03 commented Feb 7, 2023

@aks681 Please merge the PR

@aks681 aks681 merged commit 3442cbd into oppia:develop Feb 7, 2023
@Kej-r03 Kej-r03 deleted the save-progress-fix branch February 7, 2023 18:59
@U8NWXD U8NWXD mentioned this pull request Feb 8, 2023
Open
adityanarayanm095 pushed a commit to adityanarayanm095/oppia that referenced this pull request Feb 15, 2023
@Kej-r03
Fix oppia#16830: Remove unclear sentence from save progress popup (op…
1a41010 
…pia#16838)

* Remove unclear sentence from save progress popup

* Remove remaining unclear text and fix broken copy link for save progress

* Revert config property change

* Fix copy url textbox UI

* Fix URL copy CSS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JayVivarekar JayVivarekar JayVivarekar approved these changes

@aasiffaizal aasiffaizal aasiffaizal approved these changes

@paprajapati9 paprajapati9 paprajapati9 approved these changes

@nithinrdy nithinrdy nithinrdy approved these changes

Assignees

@aks681 aks681

Labels
PR: LGTM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unclear sentence in the save progress popup.
7 participants
@Kej-r03 @vojtechjelinek @nithinrdy @paprajapati9 @JayVivarekar @aasiffaizal @aks681