-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #18211: Validation of video start and end time in creator dashboard #19153
Conversation
Assigning @vojtechjelinek for the first pass review of this PR. Thanks! |
PTAL @seanlip |
Thanks, I'm adding @kevintab95 and @vojtechjelinek who can review this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Backend changes look good to me. I've added a few frontend comments. Please try to fix them, but deffering to @kevintab95 to check if they are fixed correctly.
if (start === 0 && end === 0) { | ||
return false; | ||
} | ||
return start >= end; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is a bit weird that the name of the function is called validateVideoStartEnd
but the true
return value means this is an invalid video
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I agree and changed the function name to isVideoStartTimeValid that returns true if the start time < end time. PTAL @kevintab95.
077d0bd
to
bb30efb
Compare
Overview
Essential Checklist
followed by a short, clear summary of the changes.
comment with the phrase "@{{reviewer_username}} PTAL" if I don't have
permissions to assign reviewers directly).
Proof that changes are correct
275773719-456747d6-c3b0-4a31-91f9-4fc0a201572a.mov
PR Pointers