Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix part of #19435: Migrate Blog Admin page #19471

Merged
merged 12 commits into from
Jan 17, 2024

Conversation

Vir-8
Copy link
Contributor

@Vir-8 Vir-8 commented Jan 14, 2024

Overview

  1. This PR fixes part of Migration of Individual Pages from Webpack/AngularJS to Lazy-Loaded Angular Modules #19435.
  2. This PR does the following: Migrates the Blog Admin page from Webpack/AngularJS to Lazy-Loaded Angular Modules

Essential Checklist

  • The PR title starts with "Fix #bugnum: " or "Fix part of #bugnum: ...", followed by a short, clear summary of the changes.
  • I have followed the instructions for making a code change.
  • I have assigned the correct reviewers to this PR (or will leave a comment with the phrase "@{{reviewer_username}} PTAL" if I don't have permissions to assign reviewers directly).
  • The linter/Karma presubmit checks pass on my local machine, and my PR follows the coding style guide).
  • "Allow edits from maintainers" is checked. (See here for instructions on how to enable it.)

Proof that changes are correct

blog_admin_migration1.webm

PR Pointers

@Vir-8 Vir-8 requested review from a team as code owners January 14, 2024 09:42
Copy link

oppiabot bot commented Jan 14, 2024

Assigning @kevintab95 for the first pass review of this PR. Thanks!

Copy link
Member

@DubeySandeep DubeySandeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Vir-8 Thanks for the PR, the changes look great! 😮

I've left a few minor comments, PTAL!

Copy link

oppiabot bot commented Jan 14, 2024

Hi @Vir-8, it looks like some changes were requested on this pull request by @DubeySandeep. PTAL. Thanks!

@oppiabot oppiabot bot assigned Vir-8 Jan 14, 2024
@Vir-8
Copy link
Contributor Author

Vir-8 commented Jan 14, 2024

@DubeySandeep thanks for the review! I've made the changes, PTAL

@oppiabot oppiabot bot assigned DubeySandeep and unassigned Vir-8 Jan 14, 2024
Copy link

oppiabot bot commented Jan 14, 2024

Unassigning @Vir-8 since a re-review was requested. @Vir-8, please make sure you have addressed all review comments. Thanks!

Copy link

oppiabot bot commented Jan 14, 2024

Unassigning @DubeySandeep since they have already approved the PR.

@DubeySandeep
Copy link
Member

@Vir-8 Would you like to pick one more from #19435 ? (optional) If yes, please leave a comment in the issue and start working on it (on a separate branch).

Thanks again for helping out on #19435 :)

Copy link
Member

@kevintab95 kevintab95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for codeowner files. Thanks @Vir-8!

@kevintab95 kevintab95 added this pull request to the merge queue Jan 17, 2024
@kevintab95 kevintab95 assigned Vir-8 and unassigned kevintab95 Jan 17, 2024
@oppiabot oppiabot bot added the PR: LGTM label Jan 17, 2024
Copy link

oppiabot bot commented Jan 17, 2024

Hi @Vir-8, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to ask someone to merge your PR once the CI checks pass and you're happy with it. Thanks!

Merged via the queue into oppia:develop with commit 10abdcc Jan 17, 2024
70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants