-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix part of #19435: Migrate Blog Admin page #19471
Conversation
Assigning @kevintab95 for the first pass review of this PR. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Vir-8 Thanks for the PR, the changes look great! 😮
I've left a few minor comments, PTAL!
Hi @Vir-8, it looks like some changes were requested on this pull request by @DubeySandeep. PTAL. Thanks! |
@DubeySandeep thanks for the review! I've made the changes, PTAL |
Unassigning @DubeySandeep since they have already approved the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for codeowner files. Thanks @Vir-8!
Hi @Vir-8, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to ask someone to merge your PR once the CI checks pass and you're happy with it. Thanks! |
Overview
Essential Checklist
Proof that changes are correct
blog_admin_migration1.webm
PR Pointers