Fix part of #19435: Migrate Email Dashboard #19627

sagar-subedi · 2024-01-29T18:37:58Z

Overview

This PR fixes part of Migration of Individual Pages from Webpack/AngularJS to Lazy-Loaded Angular Modules #19435.
This PR does the following: Migrates 'Email Dashboard Page' from AngularJs/Webpack to lazy-loaded angular module

Essential Checklist

The PR title starts with "Fix #bugnum: " or "Fix part of #bugnum: ...", followed by a short, clear summary of the changes.
I have followed the instructions for making a code change.
I have assigned the correct reviewers to this PR (or will leave a comment with the phrase "@{{reviewer_username}} PTAL" if I don't have permissions to assign reviewers directly).
The linter/Karma presubmit checks pass on my local machine, and my PR follows the coding style guide).
"Allow edits from maintainers" is checked. (See here for instructions on how to enable it.)

Proof that changes are correct

email-dashboard-migration.mp4

PR Pointers

Never force push! If you do, your PR will be closed.
To reply to reviewers, follow these instructions: https://github.com/oppia/oppia/wiki/Make-a-pull-request#step-5-address-review-comments-until-all-reviewers-approve
Some e2e tests are flaky, and can fail for reasons unrelated to your PR. We are working on fixing this, but in the meantime, if you need to restart the tests, please check the "If your build fails" wiki page.
See the Code Owner's wiki page for what code owners will expect.

oppiabot · 2024-01-29T18:38:10Z

Hi @sagar-subedi please assign the required reviewer(s) for this PR. Thanks!

sagar-subedi · 2024-01-29T18:42:49Z

PTAL @DubeySandeep.

Thanks.

oppiabot · 2024-01-29T18:45:53Z

Unassigning @sagar-subedi since a re-review was requested. @sagar-subedi, please make sure you have addressed all review comments. Thanks!

DubeySandeep

@sagar-subedi This looks great! 😮 I've left one minor comment, PTAL!

core/templates/pages/email-dashboard-pages/email-dashboard-page.mainpage.html

DubeySandeep · 2024-01-29T20:19:43Z

@sagar-subedi The Backend test is failing on this PR, PTAL!

sagar-subedi · 2024-02-09T00:59:59Z

@DubeySandeep Oh, I guess I missed it.
Thanks for reminding.

sagar-subedi · 2024-02-10T02:57:41Z

PTAL @Nik-09

Thanks.

Nik-09

One small nit.

Nik-09 · 2024-02-10T06:12:24Z

core/templates/pages/email-dashboard-pages/email-dashboard-auth.guard.spec.ts

+      });
+  });
+
+  it('should not redirect user to 401 page if user is super admin', (done) => {


Please rename this test case to something around -- should access the email dashboard page if the user is super admin.

…subedi/oppia into email-dashboard-migration pulling newer commits

oppiabot · 2024-02-11T15:58:22Z

Unassigning @sagar-subedi since a re-review was requested. @sagar-subedi, please make sure you have addressed all review comments. Thanks!

sagar-subedi · 2024-02-11T16:03:15Z

@Nik-09 PTAL

oppiabot · 2024-02-12T13:26:57Z

Hi @sagar-subedi. Due to recent changes in the "develop" branch, this PR now has a merge conflict. Please follow this link if you need help resolving the conflict, so that the PR can be merged. Thanks!

oppiabot · 2024-02-12T13:27:00Z

Hi @sagar-subedi. Due to recent changes in the "develop" branch, this PR now has a merge conflict. Please follow this link if you need help resolving the conflict, so that the PR can be merged. Thanks!

DubeySandeep · 2024-02-12T14:39:56Z

@Nik-09 Can you please review this PR? Also, I would highly suggest reviewing codeowner changes in one go else it delays the PR merge time significantly (Here by 5 days for two minor nit comments each after a week)!

@sagar-subedi Sorry for the trouble, we will try to get the PR merged quickly!

Nik-09

Thanks @sagar-subedi, LGTM

Nik-09 · 2024-02-12T15:14:44Z

@Nik-09 Can you please review this PR? Also, I would highly suggest reviewing codeowner changes in one go else it delays the PR merge time significantly (Here by 5 days for two minor nit comments each after a week)!

@DubeySandeep Sure, I will take care of this, thank you for your guidance.

sagar-subedi · 2024-02-12T17:04:46Z

Thanks @DubeySandeep @Nik-09

Glad to have contributed.

* email dashboard page added among the pages registered with frontend * handler for email dashboard removed from backend * removed backend test for email dashbard page * removed link with old handler * redundant mainpage file deleted * added auth guard for email dashboard * removed downgrading of email dashboard page * added root component for email dashboard * updated module for email dashboard * added to the app routing module * removed email dashboard module from webpack configuration * fixed linter errors * linter checks fixed * navbar added to the email dashboard page * test added for auth guard and root component of email dashboard * removed redundant backend test case as the page is migrated to frontend * added css to the root page component * style moved to the top to follow the existing standard * updated 2023 to 2024 in copyright disclaimer * updated test description

sagar-subedi added 15 commits January 26, 2024 22:36

email dashboard page added among the pages registered with frontend

c5a1f4a

handler for email dashboard removed from backend

33bd7fc

removed backend test for email dashbard page

5190e00

removed link with old handler

dc084b2

redundant mainpage file deleted

ba494f9

added auth guard for email dashboard

a42196b

removed downgrading of email dashboard page

9dc0e39

added root component for email dashboard

9988bd4

updated module for email dashboard

89416a4

added to the app routing module

f0b82fa

removed email dashboard module from webpack configuration

2a14bb1

fixed linter errors

6482e88

linter checks fixed

bff0e7d

navbar added to the email dashboard page

006d21d

test added for auth guard and root component of email dashboard

eab914f

sagar-subedi requested review from a team as code owners January 29, 2024 18:37

sagar-subedi requested review from Nik-09 and U8NWXD January 29, 2024 18:38

oppiabot bot assigned sagar-subedi Jan 29, 2024

oppiabot bot assigned DubeySandeep and unassigned sagar-subedi Jan 29, 2024

DubeySandeep requested changes Jan 29, 2024

View reviewed changes

core/templates/pages/email-dashboard-pages/email-dashboard-page.mainpage.html Show resolved Hide resolved

DubeySandeep assigned U8NWXD and unassigned DubeySandeep Jan 29, 2024

Merge branch 'develop' into email-dashboard-migration

b545d40

Nik-09 requested changes Feb 10, 2024

View reviewed changes

Nik-09 assigned sagar-subedi and unassigned Nik-09 Feb 10, 2024

sagar-subedi added 2 commits February 11, 2024 20:57

updated test description

e4ce9b1

Merge branch 'email-dashboard-migration' of https://github.com/sagar-…

efc23ef

…subedi/oppia into email-dashboard-migration pulling newer commits

oppiabot bot unassigned sagar-subedi Feb 11, 2024

sagar-subedi requested a review from Nik-09 February 11, 2024 16:05

sagar-subedi assigned Nik-09 Feb 11, 2024

oppiabot bot added the PR: don't merge - HAS MERGE CONFLICTS label Feb 12, 2024

oppiabot bot assigned sagar-subedi Feb 12, 2024

Merge branch 'develop' into email-dashboard-migration

60c0e02

oppiabot bot removed the PR: don't merge - HAS MERGE CONFLICTS label Feb 12, 2024

Nik-09 approved these changes Feb 12, 2024

View reviewed changes

Nik-09 removed their assignment Feb 12, 2024

DubeySandeep added this pull request to the merge queue Feb 12, 2024

Merged via the queue into oppia:develop with commit fe15ab8 Feb 12, 2024
70 checks passed

sagar-subedi deleted the email-dashboard-migration branch February 12, 2024 17:04

DubeySandeep mentioned this pull request Feb 12, 2024

Migration of Individual Pages from Webpack/AngularJS to Lazy-Loaded Angular Modules #19435

Open

29 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix part of #19435: Migrate Email Dashboard #19627

Fix part of #19435: Migrate Email Dashboard #19627

sagar-subedi commented Jan 29, 2024

oppiabot bot commented Jan 29, 2024

sagar-subedi commented Jan 29, 2024

oppiabot bot commented Jan 29, 2024

DubeySandeep left a comment

DubeySandeep commented Jan 29, 2024

sagar-subedi commented Feb 9, 2024

sagar-subedi commented Feb 10, 2024

Nik-09 left a comment

Nik-09 Feb 10, 2024 •

edited

sagar-subedi Feb 11, 2024

oppiabot bot commented Feb 11, 2024

sagar-subedi commented Feb 11, 2024

oppiabot bot commented Feb 12, 2024

oppiabot bot commented Feb 12, 2024

DubeySandeep commented Feb 12, 2024 •

edited

Nik-09 left a comment

Nik-09 commented Feb 12, 2024

sagar-subedi commented Feb 12, 2024

Fix part of #19435: Migrate Email Dashboard #19627

Fix part of #19435: Migrate Email Dashboard #19627

Conversation

sagar-subedi commented Jan 29, 2024

Overview

Essential Checklist

Proof that changes are correct

PR Pointers

oppiabot bot commented Jan 29, 2024

sagar-subedi commented Jan 29, 2024

oppiabot bot commented Jan 29, 2024

DubeySandeep left a comment

Choose a reason for hiding this comment

DubeySandeep commented Jan 29, 2024

sagar-subedi commented Feb 9, 2024

sagar-subedi commented Feb 10, 2024

Nik-09 left a comment

Choose a reason for hiding this comment

Nik-09 Feb 10, 2024 • edited

Choose a reason for hiding this comment

sagar-subedi Feb 11, 2024

Choose a reason for hiding this comment

oppiabot bot commented Feb 11, 2024

sagar-subedi commented Feb 11, 2024

oppiabot bot commented Feb 12, 2024

oppiabot bot commented Feb 12, 2024

DubeySandeep commented Feb 12, 2024 • edited

Nik-09 left a comment

Choose a reason for hiding this comment

Nik-09 commented Feb 12, 2024

sagar-subedi commented Feb 12, 2024

Nik-09 Feb 10, 2024 •

edited

DubeySandeep commented Feb 12, 2024 •

edited