-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes part of #18442: Remove deprecated edit state content suggestion model #20079
Fixes part of #18442: Remove deprecated edit state content suggestion model #20079
Conversation
Hi @vojtechjelinek, @DubeySandeep, @kevintab95, PTAL at this PR, it modifies files in jobs or platform folders. |
Assigning @kevintab95 for the first pass review of this PR. Thanks! |
…d_edit_state_content_suggestion_model
@masterboy376 I have not seen this testing doc before, but it is listed as me being the server admin and all the dropdowns in the reviewer checklist are marked as Yes. However I don't think this has actually been reviewed by any of us yet (I don't even have access to edit the doc). Please read and follow the instructions in the release testing doc template carefully, and do not self-approve things and attribute those approvals to other people. That is not OK. (I am also not supposed to be the server admin for this.) |
…d_edit_state_content_suggestion_model
Pardon @seanlip, I misunderstood the testing doc instruction before. I have fixed it. I am working on 2 issues and a project proposal currently. I assure this won't repeat. PTAL |
@kevintab95 and @U8NWXD , just polite reminder PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for changes in the (2) codeowner files!
Unassigning @DubeySandeep since they have already approved the PR. |
…d_edit_state_content_suggestion_model
…d_edit_state_content_suggestion_model
Unassigning @kevintab95 since the review is done. |
Hi @masterboy376, it looks like some changes were requested on this pull request by @kevintab95. PTAL. Thanks! |
Hello @kevintab95 addressed your review comments. PTAL |
Unassigning @masterboy376 since a re-review was requested. @masterboy376, please make sure you have addressed all review comments. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @masterboy376!
Unassigning @kevintab95 since they have already approved the PR. |
Hi @masterboy376, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to ask someone to merge your PR once the CI checks pass and you're happy with it. Thanks! |
…d_edit_state_content_suggestion_model
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assigning my self as the server admin to run this job
Unassigning @chris7716 since the review is done. |
Hi, @chris7716, the LGTM Label has been removed because the changes were requested on this PR. Thanks!. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ran it successfully on backup server.
Hi @masterboy376, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to ask someone to merge your PR once the CI checks pass and you're happy with it. Thanks! |
Overview
Essential Checklist
Testing doc (for PRs with Beam jobs that modify production server data)
Proof that changes are correct
PR Pointers