Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix part of #19864 : Added feature to generate dummy suggestion questions #20233

Closed
wants to merge 3 commits into from

Conversation

HardikGoyal2003
Copy link
Collaborator

Overview

  1. This PR fixes or fixes part of [Feature Request]: Add dummy review translation and review question option #19864
  2. This PR does the following:
    • Adds a feature to generate dummy suggestion question
    • Adds 'N' number of suggestion questions to specified skill.

Essential Checklist

Please follow the instructions for making a code change.

  • I have linked the issue that this PR fixes in the "Development" section of the sidebar.
  • I have checked the "Files Changed" tab and confirmed that the changes are what I want to make.
  • I have written tests for my code.
  • The PR title starts with "Fix #bugnum: " or "Fix part of #bugnum: ...", followed by a short, clear summary of the changes.
  • I have assigned the correct reviewers to this PR (or will leave a comment with the phrase "@{{reviewer_username}} PTAL" if I can't assign them directly).

Proof that changes are correct

Screencast.from.28-04-24.08.16.18.PM.IST.webm

PR Pointers

Copy link

oppiabot bot commented Apr 28, 2024

Hi @vojtechjelinek, @DubeySandeep, @kevintab95, PTAL at this PR, it adds a new cron job.
Also @HardikGoyal2003 It seems you have added or edited a CRON job, if so please request a testing of this CRON job with this server jobs form Please refer to this guide for details.
Thanks!

@oppiabot oppiabot bot added the PR: Affects datastore layer Labels to indicate a PR that changes the datastore layer. label Apr 28, 2024
Copy link

oppiabot bot commented Apr 28, 2024

Assigning @nikitaevg for the first pass review of this PR. Thanks!

Copy link

oppiabot bot commented Apr 28, 2024

Hi @HardikGoyal2003. Due to recent changes in the "develop" branch, this PR now has a merge conflict. Please follow this link if you need help resolving the conflict, so that the PR can be merged. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Affects datastore layer Labels to indicate a PR that changes the datastore layer. PR: don't merge - HAS MERGE CONFLICTS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants