[GSoC'24] M1.4 Add features, platform section #20479

AkashPaloju · 2024-06-17T11:33:03Z

Overview

This PR fixes or fixes part of [Feature Request]: Update the informational pages on the Oppia website #19850 .
This PR does the following: Adds features, platform section

Essential Checklist

Please follow the instructions for making a code change.

I have linked the issue that this PR fixes in the "Development" section of the sidebar.
I have checked the "Files Changed" tab and confirmed that the changes are what I want to make.
I have written tests for my code.
The PR title starts with "Fix #bugnum: " or "Fix part of #bugnum: ...", followed by a short, clear summary of the changes.
I have assigned the correct reviewers to this PR (or will leave a comment with the phrase "@{{reviewer_username}} PTAL" if I can't assign them directly).

Proof that changes are correct

features-desktop-preview.webm

Proof of changes on desktop with slow/throttled network

features-throttle-preview.webm

Proof of changes on mobile phone

features-mobile-preview.webm

Proof of changes in Arabic language

features-arabic-preview.webm

PTAL @Lawful2002

PR Pointers

Never force push! If you do, your PR will be closed.
To reply to reviewers, follow these instructions: https://github.com/oppia/oppia/wiki/Make-a-pull-request#step-5-address-review-comments-until-all-reviewers-approve
Some e2e tests are flaky, and can fail for reasons unrelated to your PR. We are working on fixing this, but in the meantime, if you need to restart the tests, please check the "If your build fails" wiki page.
See the Code Owner's wiki page for what code owners will expect.

oppiabot · 2024-06-17T11:33:15Z

Assigning @Lawful2002 for the first pass review of this PR. Thanks!

AkashPaloju · 2024-06-17T12:40:19Z

PTAL @melhikh review the videos posted above. Thanks!

melhikh · 2024-06-17T12:54:06Z

PTAL @melhikh review the videos posted above. Thanks!

Both the interaction and the design are correct and nice.

AkashPaloju · 2024-06-17T13:41:04Z

Couldn't understand why this test is not covered and it is failing on my PR

ERROR:root:summarize-nonnegative-number.pipe.ts seems to be not completely tested. Make sure it's fully covered.

seanlip · 2024-06-17T15:27:18Z

@AkashPaloju Have you read the wiki page on frontend tests and the section on coverage? There should be a local coverage report file you can look at to see what the issue is.

In general when you run into dev stack issues please take a look at the wiki page and see if your doubt is answered in the relevant section, then in your question specify which pages you've looked at. Thanks!

AkashPaloju · 2024-06-17T16:36:13Z

Yes, I am aware of the test coverage part on the wiki. My doubt is why the test coverage check of the file core/templates/filters/summarize-nonnegative-number.pipe.ts is failing on CI of my PR here. I haven't written this file and the code I removed in this PR haven't used this pipe ( No, such big numbers are there in the old features section that are summarized by this pipe.)

Edit : Found the bug the pipe summarize-nonnegative-number is imported in SharedComponentsModule and I have imported this module in the .spec.ts file in the PR. That pipe is imported but it's methods are not called, so that's why it came under un-coveraged files.

Lawful2002

Thanks @AkashPaloju, a couple comments. Also at 0:13 in your first video, clicking on the Explore Lessons is redirecting to non existent page. I don't think that should happen.

Lawful2002 · 2024-06-17T17:07:35Z

core/templates/pages/about-page/about-page.component.ts

+    },
+  ];
+
+  panelIsCollapsed: boolean[] = [true, true, true, true];


Instead of having this here separately, let's include this as part of the featuresData array items itself. This makes it more maintainable.

I still see this array

Lawful2002 · 2024-06-17T17:08:47Z

core/templates/pages/about-page/data.model.ts

+  text: string;
+  image?: string;
+  customPanelClassNames: string[];
+  customTitleClassNames: string[];


Inline with the previous comment, include a boolean collapsed here.

oppiabot · 2024-06-17T17:12:53Z

Unassigning @Lawful2002 since the review is done.

oppiabot · 2024-06-17T17:12:56Z

Hi @AkashPaloju, it looks like some changes were requested on this pull request by @Lawful2002. PTAL. Thanks!

AkashPaloju · 2024-06-17T17:38:52Z

Hey Lawful2002 learn/math/ page won't be available for general user on local server that's why we get 404 on that page.
For example, I haven't made any changes to the splash page, but this button takes us to learn/math which gives us 404. You can verify on your local server. To access it we need to create a classroom in the super admin page first.

Screencast.from.17-06-24.11.01.18.PM.IST.webm

AkashPaloju · 2024-06-17T21:18:36Z

@Lawful2002 PTAL at the changes
Thanks!

oppiabot · 2024-06-17T21:21:40Z

Unassigning @AkashPaloju since a re-review was requested. @AkashPaloju, please make sure you have addressed all review comments. Thanks!

Lawful2002 · 2024-06-18T12:28:46Z

Hey Lawful2002 learn/math/ page won't be available for general user on local server that's why we get 404 on that page. For example, I haven't made any changes to the splash page, but this button takes us to learn/math which gives us 404. You can verify on your local server. To access it we need to create a classroom in the super admin page first.

Screencast.from.17-06-24.11.01.18.PM.IST.webm

Hi Akash, can you create a classroom, and test it, just to be absolutely sure.

AkashPaloju · 2024-06-18T12:55:50Z

@Lawful2002 , PTAL at this video. Thanks!

Screencast.from.18-06-24.06.23.57.PM.IST.webm

oppiabot · 2024-06-19T10:18:06Z

Hi @AkashPaloju. Due to recent changes in the "develop" branch, this PR now has a merge conflict. Please follow this link if you need help resolving the conflict, so that the PR can be merged. Thanks!

…tures

Lawful2002

Actually, I don't see my comment resolved. PTAL

Lawful2002 · 2024-06-20T14:01:34Z

core/templates/pages/about-page/about-page.component.ts

+    },
+  ];
+
+  panelIsCollapsed: boolean[] = [true, true, true, true];


I still see this array

oppiabot · 2024-06-20T14:03:29Z

Unassigning @Lawful2002 since they have already approved the PR.

AkashPaloju · 2024-06-20T14:04:55Z

Actually, I don't see my comment resolved. PTAL

Where ?
https://github.com/oppia/oppia/pull/20479/files#diff-f6a254d63de21eb2bd14c8722d18ef6df52a4e367e723cf0d0af851b800a2264

Lawful2002 · 2024-06-20T14:05:49Z

Actually, I don't see my comment resolved. PTAL

Where ? https://github.com/oppia/oppia/pull/20479/files#diff-f6a254d63de21eb2bd14c8722d18ef6df52a4e367e723cf0d0af851b800a2264

Hmm can't find it now. Weird

oppiabot · 2024-06-20T14:09:11Z

Hi @AkashPaloju, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to merge this PR once the CI checks pass and you're happy with it. Thanks!

AkashPaloju added 2 commits June 17, 2024 16:22

Add features section

f25d91e

minor style fix

839da88

AkashPaloju requested a review from Lawful2002 June 17, 2024 11:33

AkashPaloju requested a review from a team as a code owner June 17, 2024 11:33

oppiabot bot assigned Lawful2002 Jun 17, 2024

AkashPaloju mentioned this pull request Jun 17, 2024

[Feature Request]: Update the informational pages on the Oppia website #19850

Open

Lawful2002 requested changes Jun 17, 2024

View reviewed changes

oppiabot bot unassigned Lawful2002 Jun 17, 2024

oppiabot bot assigned AkashPaloju Jun 17, 2024

AkashPaloju added 2 commits June 18, 2024 01:28

Address comments, fix failing tests

cbfd143

fix backend tests

d2e786a

oppiabot bot assigned Lawful2002 and unassigned AkashPaloju Jun 17, 2024

AkashPaloju requested a review from Lawful2002 June 18, 2024 15:43

oppiabot bot added the PR: don't merge - HAS MERGE CONFLICTS label Jun 19, 2024

oppiabot bot assigned AkashPaloju Jun 19, 2024

AkashPaloju added 6 commits June 19, 2024 18:59

Merge branch 'develop' of https://github.com/oppia/oppia into our-fea…

728a3da

…tures

Merge branch 'develop' of https://github.com/oppia/oppia into our-fea…

3e18927

…tures

Remove duplicate selectors coming from develop

3fde797

css selectors fix

693f356

Merge branch 'develop' of https://github.com/oppia/oppia into our-fea…

9e178e1

…tures

Consolidate changes from other PRs

ce8851f

oppiabot bot removed the PR: don't merge - HAS MERGE CONFLICTS label Jun 20, 2024

AkashPaloju enabled auto-merge June 20, 2024 06:36

This was referenced Jun 20, 2024

[Flake]: Meta Tags should set the correct og meta tags #20093

Open

[Flake]: TimeoutError: Navigation timeout of 30000 ms exceeded in partnerships page #20475

Open

[Flake]: Element JSHandle@node took too long to be clickable. #20507

Open

Lawful2002 approved these changes Jun 20, 2024

View reviewed changes

AkashPaloju added this pull request to the merge queue Jun 20, 2024

Lawful2002 requested changes Jun 20, 2024

View reviewed changes

oppiabot bot unassigned Lawful2002 Jun 20, 2024

Lawful2002 approved these changes Jun 20, 2024

View reviewed changes

oppiabot bot added the PR: LGTM label Jun 20, 2024

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 20, 2024

AkashPaloju mentioned this pull request Jun 20, 2024

E2E Flake: Splash page takes too long to appear #16260

Open

AkashPaloju added this pull request to the merge queue Jun 20, 2024

Merged via the queue into oppia:develop with commit 94ca382 Jun 20, 2024
95 of 96 checks passed

AkashPaloju deleted the our-features branch June 20, 2024 16:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[GSoC'24] M1.4 Add features, platform section #20479

[GSoC'24] M1.4 Add features, platform section #20479

AkashPaloju commented Jun 17, 2024

oppiabot bot commented Jun 17, 2024

AkashPaloju commented Jun 17, 2024 •

edited

melhikh commented Jun 17, 2024

AkashPaloju commented Jun 17, 2024

seanlip commented Jun 17, 2024 •

edited

AkashPaloju commented Jun 17, 2024 •

edited

Lawful2002 left a comment

Lawful2002 Jun 17, 2024

AkashPaloju Jun 18, 2024

Lawful2002 Jun 20, 2024

Lawful2002 Jun 17, 2024

AkashPaloju Jun 18, 2024

oppiabot bot commented Jun 17, 2024

oppiabot bot commented Jun 17, 2024

AkashPaloju commented Jun 17, 2024 •

edited

AkashPaloju commented Jun 17, 2024

oppiabot bot commented Jun 17, 2024

Lawful2002 commented Jun 18, 2024

AkashPaloju commented Jun 18, 2024

oppiabot bot commented Jun 19, 2024

Lawful2002 left a comment

Lawful2002 Jun 20, 2024

oppiabot bot commented Jun 20, 2024

AkashPaloju commented Jun 20, 2024

Lawful2002 commented Jun 20, 2024

oppiabot bot commented Jun 20, 2024

[GSoC'24] M1.4 Add features, platform section #20479

[GSoC'24] M1.4 Add features, platform section #20479

Conversation

AkashPaloju commented Jun 17, 2024

Overview

Essential Checklist

Proof that changes are correct

Proof of changes on desktop with slow/throttled network

Proof of changes on mobile phone

Proof of changes in Arabic language

PR Pointers

oppiabot bot commented Jun 17, 2024

AkashPaloju commented Jun 17, 2024 • edited

melhikh commented Jun 17, 2024

AkashPaloju commented Jun 17, 2024

seanlip commented Jun 17, 2024 • edited

AkashPaloju commented Jun 17, 2024 • edited

Lawful2002 left a comment

Choose a reason for hiding this comment

Lawful2002 Jun 17, 2024

Choose a reason for hiding this comment

AkashPaloju Jun 18, 2024

Choose a reason for hiding this comment

Lawful2002 Jun 20, 2024

Choose a reason for hiding this comment

Lawful2002 Jun 17, 2024

Choose a reason for hiding this comment

AkashPaloju Jun 18, 2024

Choose a reason for hiding this comment

oppiabot bot commented Jun 17, 2024

oppiabot bot commented Jun 17, 2024

AkashPaloju commented Jun 17, 2024 • edited

AkashPaloju commented Jun 17, 2024

oppiabot bot commented Jun 17, 2024

Lawful2002 commented Jun 18, 2024

AkashPaloju commented Jun 18, 2024

oppiabot bot commented Jun 19, 2024

Lawful2002 left a comment

Choose a reason for hiding this comment

Lawful2002 Jun 20, 2024

Choose a reason for hiding this comment

oppiabot bot commented Jun 20, 2024

AkashPaloju commented Jun 20, 2024

Lawful2002 commented Jun 20, 2024

oppiabot bot commented Jun 20, 2024

AkashPaloju commented Jun 17, 2024 •

edited

seanlip commented Jun 17, 2024 •

edited

AkashPaloju commented Jun 17, 2024 •

edited

AkashPaloju commented Jun 17, 2024 •

edited