[GSoC'24] M2.1 : Fix a part of #20374: Acceptance test coverage for 2 Logged-out Users' CUJs. #20674

Akhilesh-max · 2024-07-14T16:34:33Z

Overview

This PR fixes or fixes part of [GSoC'24 M1+M2]: Acceptance Test Coverage for Learner's and Admin's CUJs. #20374 .
This PR does the following: This PR provides acceptance test coverage for the CUJs:

12.1: select-and-play-topic-from-math-classroom.spec.ts

12.2: browse-and-search-for-lessons-in-community-library.spec.ts

Essential Checklist

Please follow the instructions for making a code change.

I have linked the issue that this PR fixes in the "Development" section of the sidebar.
I have checked the "Files Changed" tab and confirmed that the changes are what I want to make.
I have written tests for my code.
The PR title starts with "Fix #bugnum: " or "Fix part of #bugnum: ...", followed by a short, clear summary of the changes.
I have assigned the correct reviewers to this PR (or will leave a comment with the phrase "@{{reviewer_username}} PTAL" if I can't assign them directly).

Proof that changes are correct

NA

PR Pointers

Never force push! If you do, your PR will be closed.
To reply to reviewers, follow these instructions: https://github.com/oppia/oppia/wiki/Make-a-pull-request#step-5-address-review-comments-until-all-reviewers-approve
Some e2e tests are flaky, and can fail for reasons unrelated to your PR. We are working on fixing this, but in the meantime, if you need to restart the tests, please check the "If your build fails" wiki page.
See the Code Owner's wiki page for what code owners will expect.

oppiabot · 2024-07-14T16:34:35Z

Hi @Akhilesh-max, can you complete the following:

The proof that changes are correct has not been provided, please make sure to upload a image/video showing that the changes are correct. Or include a sentence saying "No proof of changes needed because" and the reason why proof of changes cannot be provided.
Thanks!

oppiabot · 2024-07-14T16:34:45Z

Assigning @imchristie for the first pass review of this PR. Thanks!

Akhilesh-max · 2024-07-16T10:28:35Z

@imchristie These tests ain't really small, there are lots of utilities needed. For now, have only written the specs file and decided what all is needed for the tests. Hoping to complete this PR by today EOD, IST.

imchristie

Left some comments. Reassign me for review when all the functions are defined.

imchristie · 2024-07-15T10:12:31Z

...tance-tests/specs/logged-out-user/browse-and-search-for-lessons-in-community-library.spec.ts

+// limitations under the License.
+
+/**
+ * @fileoverview Acceptance Test for checking if all buttons on the


Wrong description

imchristie · 2024-07-17T05:41:58Z

core/tests/puppeteer-acceptance-tests/utilities/user/logged-in-user.ts

+   * @param {string} explorationId - The ID of the exploration to play.
+   */
+  async playExploration(explorationId: string): Promise<void> {
+    await Promise.all([


Use this.goto()

core/templates/pages/exploration-player-page/layout-directives/feedback-popup.component.ts

Akhilesh-max · 2024-07-17T21:24:45Z

@DubeySandeep @nikitaevg PTAL.
Thanks.

oppiabot · 2024-07-17T21:27:49Z

Unassigning @Akhilesh-max since a re-review was requested. @Akhilesh-max, please make sure you have addressed all review comments. Thanks!

oppiabot · 2024-07-17T23:19:57Z

Hi @Akhilesh-max. Due to recent changes in the "develop" branch, this PR now has a merge conflict. Please follow this link if you need help resolving the conflict, so that the PR can be merged. Thanks!

oppiabot · 2024-07-17T23:20:00Z

Hi @Akhilesh-max. Due to recent changes in the "develop" branch, this PR now has a merge conflict. Please follow this link if you need help resolving the conflict, so that the PR can be merged. Thanks!

imchristie

Left some comments

core/tests/puppeteer-acceptance-tests/utilities/user/logged-out-user.ts

imchristie · 2024-07-18T03:47:10Z

core/tests/webdriverio_utils/ClassroomPage.js

Why not delete the whole file?

Some of the functions in this utility file are being used in some other wdio e2e tests, so, couldn't remove it whole. (Only removed the dead functions)

Akhilesh-max · 2024-07-18T07:06:13Z

@imchristie PTAL.
thanks.

imchristie

LGTM! But there're 6 failures in CI. Make sure to fix them before merging.

oppiabot · 2024-07-18T08:53:35Z

Unassigning @imchristie since they have already approved the PR.

nikitaevg

LGTM for the frontend changes

oppiabot · 2024-07-18T17:56:14Z

Unassigning @nikitaevg since they have already approved the PR.

updates

7b03b60

Akhilesh-max requested review from a team as code owners July 14, 2024 16:34

Akhilesh-max requested a review from imchristie July 14, 2024 16:34

Akhilesh-max requested a review from DubeySandeep July 14, 2024 16:34

oppiabot bot assigned Akhilesh-max Jul 14, 2024

oppiabot bot assigned imchristie Jul 14, 2024

Akhilesh-max marked this pull request as draft July 14, 2024 16:35

Akhilesh-max added 11 commits July 14, 2024 22:37

Merge branch 'develop' of https://github.com/oppia/oppia into m2.1

c6c3ff7

updates

9a0a5ef

updates

6f14c04

updates

ff5512f

updates

ac902c0

updates

c9abba5

Merge branch 'develop' of https://github.com/oppia/oppia into m2.1

bd27041

updates

0e38828

Merge branch 'develop' into m2.1

7e63fe7

Merge branch 'develop' of https://github.com/oppia/oppia into m2.1

cec71b7

Merge branch 'm2.1' of https://github.com/Akhilesh-max/oppia into m2.1

62d555e

Akhilesh-max marked this pull request as ready for review July 16, 2024 10:26

updates

406842b

imchristie reviewed Jul 17, 2024

View reviewed changes

Akhilesh-max added 2 commits July 17, 2024 14:10

updates

ecece36

updates

6dbd9ba

Akhilesh-max requested a review from a team as a code owner July 17, 2024 14:03

Akhilesh-max requested a review from nikitaevg July 17, 2024 14:03

updates

78eb6b1

Akhilesh-max added 4 commits July 17, 2024 22:00

updates

8d3d4ee

updates

8377e4a

Merge branch 'develop' of https://github.com/oppia/oppia into m2.1

a7409af

updates

5965a56

Akhilesh-max commented Jul 17, 2024

View reviewed changes

core/templates/pages/exploration-player-page/layout-directives/feedback-popup.component.ts Show resolved Hide resolved

oppiabot bot assigned DubeySandeep and nikitaevg and unassigned Akhilesh-max Jul 17, 2024

oppiabot bot added the PR: don't merge - HAS MERGE CONFLICTS label Jul 17, 2024

oppiabot bot assigned Akhilesh-max Jul 17, 2024

imchristie reviewed Jul 18, 2024

View reviewed changes

Akhilesh-max added 2 commits July 18, 2024 12:17

updates

b4c24c8

updates

ad365e6

oppiabot bot removed the PR: don't merge - HAS MERGE CONFLICTS label Jul 18, 2024

imchristie approved these changes Jul 18, 2024

View reviewed changes

oppiabot bot unassigned imchristie Jul 18, 2024

nikitaevg approved these changes Jul 18, 2024

View reviewed changes

oppiabot bot unassigned nikitaevg Jul 18, 2024

Akhilesh-max changed the title ~~[GSoC'24] M2.1 : Fix a part of #20374: Acceptance test coverage for 3 Logged-out Users' CUJs.~~ [GSoC'24] M2.1 : Fix a part of #20374: Acceptance test coverage for 2 Logged-out Users' CUJs. Jul 18, 2024

updates

a382927

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[GSoC'24] M2.1 : Fix a part of #20374: Acceptance test coverage for 2 Logged-out Users' CUJs. #20674

[GSoC'24] M2.1 : Fix a part of #20374: Acceptance test coverage for 2 Logged-out Users' CUJs. #20674

Akhilesh-max commented Jul 14, 2024 •

edited

Loading

oppiabot bot commented Jul 14, 2024

oppiabot bot commented Jul 14, 2024

Akhilesh-max commented Jul 16, 2024

imchristie left a comment

imchristie Jul 15, 2024

Akhilesh-max Jul 17, 2024

imchristie Jul 17, 2024

Akhilesh-max Jul 17, 2024

Akhilesh-max commented Jul 17, 2024

oppiabot bot commented Jul 17, 2024

oppiabot bot commented Jul 17, 2024

oppiabot bot commented Jul 17, 2024

imchristie left a comment

imchristie Jul 18, 2024

Akhilesh-max Jul 18, 2024

Akhilesh-max commented Jul 18, 2024

imchristie left a comment •

edited

Loading

oppiabot bot commented Jul 18, 2024

nikitaevg left a comment

oppiabot bot commented Jul 18, 2024

[GSoC'24] M2.1 : Fix a part of #20374: Acceptance test coverage for 2 Logged-out Users' CUJs. #20674

Are you sure you want to change the base?

[GSoC'24] M2.1 : Fix a part of #20374: Acceptance test coverage for 2 Logged-out Users' CUJs. #20674

Conversation

Akhilesh-max commented Jul 14, 2024 • edited Loading

Overview

Essential Checklist

Proof that changes are correct

PR Pointers

oppiabot bot commented Jul 14, 2024

oppiabot bot commented Jul 14, 2024

Akhilesh-max commented Jul 16, 2024

imchristie left a comment

Choose a reason for hiding this comment

imchristie Jul 15, 2024

Choose a reason for hiding this comment

Akhilesh-max Jul 17, 2024

Choose a reason for hiding this comment

imchristie Jul 17, 2024

Choose a reason for hiding this comment

Akhilesh-max Jul 17, 2024

Choose a reason for hiding this comment

Akhilesh-max commented Jul 17, 2024

oppiabot bot commented Jul 17, 2024

oppiabot bot commented Jul 17, 2024

oppiabot bot commented Jul 17, 2024

imchristie left a comment

Choose a reason for hiding this comment

imchristie Jul 18, 2024

Choose a reason for hiding this comment

Akhilesh-max Jul 18, 2024

Choose a reason for hiding this comment

Akhilesh-max commented Jul 18, 2024

imchristie left a comment • edited Loading

Choose a reason for hiding this comment

oppiabot bot commented Jul 18, 2024

nikitaevg left a comment

Choose a reason for hiding this comment

oppiabot bot commented Jul 18, 2024

Akhilesh-max commented Jul 14, 2024 •

edited

Loading

imchristie left a comment •

edited

Loading