Added notes to run single e2e and unit tests. #5116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanlip
reviewed
Jun 17, 2018
feconf.py
Outdated
| @@ -520,23 +520,23 @@ def get_empty_ratings(): | |||
| DEMO_EXPLORATIONS = { | |||
| u'0': 'welcome.yaml', | |||
| u'1': 'multiples.yaml', | |||
| u'2': 'binary_search', | |||
| u'2': 'binary_search.yaml', | |||
There was a problem hiding this comment.
Why this change? I thought exploration files with assets were referred to without the yaml suffix.
There was a problem hiding this comment.
Oh! Thanks for the info, this wasn't known to me and I found admin page was looking bit weird so did it. I'll revert this changes. Thanks!
Codecov Report
@@ Coverage Diff @@
## develop #5116 +/- ##
========================================
Coverage 46.12% 46.12%
========================================
Files 423 423
Lines 24562 24562
Branches 3919 3919
========================================
Hits 11328 11328
Misses 13234 13234Continue to review full report at Codecov.
|
hoangviet1993
pushed a commit
to hoangviet1993/oppia
that referenced
this pull request
Jun 20, 2018
* Added notes to run single e2e and unit tests
giritheja
added a commit
to giritheja/oppia
that referenced
this pull request
Jun 20, 2018
* upstream/develop: (78 commits) Create Topic Editor (Part 3): Create the editor UI (oppia#5112) Fix part of oppia#3968: ParamMetadataObjectFactory domain object (oppia#5082) Update CHANGELOG for v2.6.5 (oppia#5123) fix backend load test (oppia#5120) Improving the dev workflow: Add restrict check for directives (oppia#5068) Added notes to run single e2e and unit tests. (oppia#5116) Add node path to stylelint cmd args (oppia#5117) Fix oppia#5111: remove notification preferences card from non-editors. Fix oppia#5009: Add wait for suggestions e2e test (oppia#5109) Create Topic Editor (Part 2): Created Topics and Skills dashboard (oppia#5094) Milestone 1.2: Lesson translation dashboard. (oppia#5099) Add angular-ui-tree dependency. (oppia#5110) Number with Units Interaction: Milestone 1.3 (oppia#5028) Fix oppia#5083: Audio needs update span disable for guest users. (oppia#5091) Fix oppia#5044: Added a named constant for revert commit command (oppia#5102) Create Topic Editor (Part 1): Added frontend domain objects for topics. (oppia#5090) Added try again button. (oppia#5087) Fix oppia#5088: Removed refresh option from the create view (oppia#5100) Added migration function for Textangular - Milestone 1 (part 2) (oppia#4985) Routine translations update. (oppia#5101) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Added notes to run single e2e and unit tests.
Checklist
python scripts/pre_commit_linter.pyandbash scripts/run_frontend_tests.sh.