Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #4838: Ternary operator scope creation #5262

Merged
merged 2 commits into from Jul 11, 2018
Merged

Fix #4838: Ternary operator scope creation #5262

merged 2 commits into from Jul 11, 2018

Conversation

apb7
Copy link
Contributor

@apb7 apb7 commented Jul 11, 2018

Explanation

Fixes #4838

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes.
  • The PR explanation includes the words "Fixes #bugnum: ...".
  • The linter/Karma presubmit checks have passed.
    • These should run automatically, but if not, you can manually trigger them locally using python scripts/pre_commit_linter.py and bash scripts/run_frontend_tests.sh.
  • The PR is made from a branch that's not called "develop".
  • The PR follows the style guide.
  • The PR is assigned to an appropriate reviewer.
    • If you're a new contributor, please ask on Gitter for someone to assign a reviewer.
    • If you're not sure who the appropriate reviewer is, please assign to the issue's "owner" -- see the "talk-to" label on the issue.

@apb7 apb7 requested a review from kevinlee12 July 11, 2018 17:17
Copy link
Contributor

@kevinlee12 kevinlee12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@codecov-io
Copy link

codecov-io commented Jul 11, 2018

Codecov Report

Merging #5262 into develop will not change coverage.
The diff coverage is 9.09%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #5262   +/-   ##
========================================
  Coverage    47.42%   47.42%           
========================================
  Files          472      472           
  Lines        27166    27166           
  Branches      4195     4195           
========================================
  Hits         12884    12884           
  Misses       14282    14282
Impacted Files Coverage Δ
...tes/dev/head/components/StateGraphLayoutService.js 0.41% <0%> (ø) ⬆️
...templates/dev/head/components/forms/FormBuilder.js 60.41% <0%> (ø) ⬆️
...s/interactions/LogicProof/directives/LogicProof.js 8.73% <0%> (ø) ⬆️
...mponents/forms/AudioTranslationsEditorDirective.js 9.9% <0%> (ø) ⬆️
core/templates/dev/head/filters.js 66.91% <20%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64aba6a...348ed49. Read the comment docs.

@apb7
Copy link
Contributor Author

apb7 commented Jul 11, 2018

Merging this, thanks @kevinlee12 :)

@apb7 apb7 merged commit 371545b into oppia:develop Jul 11, 2018
@apb7 apb7 deleted the ternary-expression branch July 11, 2018 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Blocked on eslint] Scope creation in case of "?" for indent rule in Eslint
3 participants