Removes audio translation editor from editor tab and enables translation tab.

[DubeySandeep]

Explanation

This PR removes audio translations editor driective from editor tab and enables translation tab.

This will get merged after #5279 and #5378. (Done!)
This PR fixes #5452, fixes #4521

Checklist

• The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes.
• The PR explanation includes the words "Fixes #bugnum: ...".
• The linter/Karma presubmit checks have passed.
  • These should run automatically, but if not, you can manually trigger them locally using python scripts/pre_commit_linter.py and bash scripts/run_frontend_tests.sh.
• The PR is made from a branch that's not called "develop".
• The PR follows the style guide.
• The PR is assigned to an appropriate reviewer.
  • If you're a new contributor, please ask on Gitter for someone to assign a reviewer.
  • If you're not sure who the appropriate reviewer is, please assign to the issue's "owner" -- see the "talk-to" label on the issue.

[codecov-io]

Codecov Report

Merging #5413 into develop will increase coverage by 0.18%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##           develop    #5413      +/-   ##
===========================================
+ Coverage    46.23%   46.41%   +0.18%     
===========================================
  Files          502      499       -3     
  Lines        29352    29197     -155     
  Branches      4463     4440      -23     
===========================================
- Hits         13571    13553      -18     
+ Misses       15781    15644     -137

Impacted Files	Coverage Δ
.../pages/state_editor/StateContentEditorDirective.js	76.74% <ø> (+3.66%)	⬆️
...ates/dev/head/components/OutcomeEditorDirective.js	1.03% <ø> (+0.05%)	⬆️
...mplates/dev/head/components/HintEditorDirective.js	2.63% <ø> (+0.3%)	⬆️
...es/exploration_editor/EditorNavigationDirective.js	2.27% <ø> (-2.08%)	⬇️
...d/components/SolutionExplanationEditorDirective.js	2.94% <0%> (+0.61%)	⬆️
...dev/head/components/share/SharingLinksDirective.js	4.34% <0%> (-0.66%)	⬇️
extensions/objects/templates/FractionEditor.js	5.55% <0%> (-0.33%)	⬇️
..._editor/feedback_tab/ThreadStatusDisplayService.js	100% <0%> (ø)	⬆️
.../templates/dev/head/services/AudioPlayerService.js	15.49% <0%> (ø)	⬆️
extensions/objects/templates/ListOfTabsEditor.js
... and 2 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c0ac4f...695b758. Read the comment docs.

[oppiabot]

Hi @DubeySandeep. Due to recent changes in the "develop" branch, this PR now has a merge conflict. Please follow this link if you need help resolving the conflict, so that the PR can be merged. Thanks!

[DubeySandeep]

Added @aks681 for review the changes in question editor.

[DubeySandeep]

Oops! I forgot to disable this!

[DubeySandeep]

Done!

[omerharshit]

I want to contribute in Oppia. But in installation I am finding that error , can anyone help me to resolve it. Harshit Omer@DESKTOP-CO5TLQU MINGW64 /c/opensource/oppia (develop) $ bash scripts/start.sh WARNING: Unsupported OS for installation of node.js. If you are running this script on Windows, see the instructions here regarding installation of node.js: https://github.com/oppia/oppia/wiki/Installing-Oppia-%28Windows%29 STATUS: Installation completed except for node.js. Exiting.

…

On 8 August 2018 at 23:02, Sandeep Dubey ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In assets/constants.js <#5413 (comment)>: > @@ -474,7 +474,7 @@ var constants = { "USE_NEW_SUGGESTION_FRAMEWORK": false, - "ENABLE_NEW_STRUCTURES": false, + "ENABLE_NEW_STRUCTURES": true, Done! — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#5413 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ATp-sOihedkMoFowyMMoauE-6oKW4-f8ks5uOyCjgaJpZM4VrOU_> .

[tjiang11]

Can you merge develop into this?

Looks great, one small thing I think should be changed. In the modal that asks if the editor wants to mark all the translation as needs update. Maybe we should make the text more clear now since the translations aren't in the editor.

I think it would be fine to append at the end of the modal's body, something like: "This informs audio translators to record new audio that reflects any changes in text."

[DubeySandeep]

@tjiang11, Done! PTAL!

[tjiang11]

Lgtm!