New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Milestone 3.5: Lesson translation dashboard. #5506
Conversation
core/tests/protractor.conf.js
Outdated
@@ -119,6 +119,10 @@ exports.config = { | |||
'protractor/subscriptionsFlow.js' | |||
], | |||
|
|||
translatorFeatures: [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @DubeySandeep, just a doubt -- where is this suite located?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops! I forgot to remove this!
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
Codecov Report
@@ Coverage Diff @@
## develop #5506 +/- ##
=========================================
Coverage ? 46.3%
=========================================
Files ? 500
Lines ? 29275
Branches ? 4452
=========================================
Hits ? 13557
Misses ? 15718
Partials ? 0 Continue to review full report at Codecov.
|
Explanation
This PR adds e2e test for translation tab.
Checklist
python scripts/pre_commit_linter.py
andbash scripts/run_frontend_tests.sh
.