Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Milestone 3.5: Lesson translation dashboard. #5506

Merged
merged 6 commits into from Aug 13, 2018

Conversation

DubeySandeep
Copy link
Member

Explanation

This PR adds e2e test for translation tab.

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes.
  • The PR explanation includes the words "Fixes #bugnum: ...".
  • The linter/Karma presubmit checks have passed.
    • These should run automatically, but if not, you can manually trigger them locally using python scripts/pre_commit_linter.py and bash scripts/run_frontend_tests.sh.
  • The PR is made from a branch that's not called "develop".
  • The PR follows the style guide.
  • The PR is assigned to an appropriate reviewer.
    • If you're a new contributor, please ask on Gitter for someone to assign a reviewer.
    • If you're not sure who the appropriate reviewer is, please assign to the issue's "owner" -- see the "talk-to" label on the issue.

@@ -119,6 +119,10 @@ exports.config = {
'protractor/subscriptionsFlow.js'
],

translatorFeatures: [
Copy link
Contributor

@apb7 apb7 Aug 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @DubeySandeep, just a doubt -- where is this suite located?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops! I forgot to remove this!
Thanks!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

Copy link
Contributor

@tjiang11 tjiang11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@seanlip seanlip added this to the Blocking bugs milestone Aug 13, 2018
@codecov-io
Copy link

codecov-io commented Aug 13, 2018

Codecov Report

❗ No coverage uploaded for pull request base (develop@51f2ed8). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             develop   #5506   +/-   ##
=========================================
  Coverage           ?   46.3%           
=========================================
  Files              ?     500           
  Lines              ?   29275           
  Branches           ?    4452           
=========================================
  Hits               ?   13557           
  Misses             ?   15718           
  Partials           ?       0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51f2ed8...babf9b3. Read the comment docs.

@DubeySandeep DubeySandeep merged commit 11f5f6c into oppia:develop Aug 13, 2018
@BenHenning BenHenning removed this from the Blocking bugs milestone Sep 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants