Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throttle error reporting to at most once every 5 seconds. #5767

Merged
merged 1 commit into from
Oct 19, 2018

Conversation

seanlip
Copy link
Member

@seanlip seanlip commented Oct 19, 2018

PTAL if you're around -- I need to push this somewhat urgently, as discussed in the email thread. Thanks!

Copy link
Contributor

@nithusha21 nithusha21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving! I have one question though. Does this mean that if another independent error occurs within this 5 second period, it won't be logged?

@seanlip
Copy link
Member Author

seanlip commented Oct 19, 2018

Yes that's right. I was thinking about that too but I couldn't see a way around it. That said, I guess we have enough errors to deal with at the moment, so maybe that's an okay tradeoff for now?

@nithusha21
Copy link
Contributor

Yeah that sounds good. I think that tradeoff is fine considering we have a lot of issues on stackdriver already!

@codecov-io
Copy link

Codecov Report

Merging #5767 into develop will increase coverage by <.01%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop   #5767      +/-   ##
==========================================
+ Coverage    45.69%   45.7%   +<.01%     
==========================================
  Files          515     515              
  Lines        29987   29991       +4     
  Branches      4527    4528       +1     
==========================================
+ Hits         13702   13706       +4     
  Misses       16285   16285
Impacted Files Coverage Δ
core/templates/dev/head/app.js 58.82% <85.71%> (+0.9%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f234a3a...c844534. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants