-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Throttle error reporting to at most once every 5 seconds. #5767
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving! I have one question though. Does this mean that if another independent error occurs within this 5 second period, it won't be logged?
Yes that's right. I was thinking about that too but I couldn't see a way around it. That said, I guess we have enough errors to deal with at the moment, so maybe that's an okay tradeoff for now? |
Yeah that sounds good. I think that tradeoff is fine considering we have a lot of issues on stackdriver already! |
Codecov Report
@@ Coverage Diff @@
## develop #5767 +/- ##
==========================================
+ Coverage 45.69% 45.7% +<.01%
==========================================
Files 515 515
Lines 29987 29991 +4
Branches 4527 4528 +1
==========================================
+ Hits 13702 13706 +4
Misses 16285 16285
Continue to review full report at Codecov.
|
PTAL if you're around -- I need to push this somewhat urgently, as discussed in the email thread. Thanks!