Fix #5019 : The continue button is now visible with long feedback

[geetchoudhary]

Explanation

Fixes #5019
When the text in the supplemental card is long, the continue button is now visible.

Screenshots
Before

After

Checklist

• The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
• The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
• The linter/Karma presubmit checks have passed.
  • These should run automatically, but if not, you can manually trigger them locally using python scripts/pre_commit_linter.py and bash scripts/run_frontend_tests.sh.
• The PR is made from a branch that's not called "develop".
• The PR follows the style guide.
• The PR is assigned to an appropriate reviewer.
  • If you're a new contributor, please ask on Gitter for someone to assign a reviewer.
  • If you're not sure who the appropriate reviewer is, please assign to the issue's "owner" -- see the "talk-to" label on the issue.

[geetchoudhary]

Hi @kevinlee12 , PTAL. Thanks :)

[codecov-io]

Codecov Report

Merging #6136 into develop will decrease coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #6136      +/-   ##
===========================================
- Coverage    45.33%   45.33%   -0.01%     
===========================================
  Files          525      525              
  Lines        30862    30869       +7     
  Branches      4615     4615              
===========================================
+ Hits         13990    13993       +3     
- Misses       16872    16876       +4

Impacted Files	Coverage Δ
.../pages/state_editor/StateContentEditorDirective.js	72% <0%> (-4.75%)	⬇️
...ges/exploration_editor/feedback_tab/FeedbackTab.js	0.68% <0%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfc1c18...8c1e23c. Read the comment docs.

[kevinlee12]

Hi @geetchoudhary, it's still hidden for me, this could be how Firefox (v64) is handling this. Here's what I see:

[kevinlee12]

and also, the assignee is typically the person who needs to take action, so unless you are still working on it, the assignee should have been me 😄. I'll assign it back to you once I've done my review.

[geetchoudhary]

Hi @geetchoudhary, it's still hidden for me, this could be how Firefox (v64) is handling this. Here's what I see:

Hi @kevinlee12 , I am also using Firefox (v64), but this is what I am seeing

Do you know what might be happening? Thanks :).

[geetchoudhary]

and also, the assignee is typically the person who needs to take action, so unless you are still working on it, the assignee should have been me 😄. I'll assign it back to you once I've done my review.

Sure

[kevinlee12]

For the scrolling issue, my guess is that my screen height isn't as high as yours, since I didn't see that much empty space below the interactions (my screen height is 768px).

[geetchoudhary]

Hi @kevinlee12 , PTAL. Thanks :)

[kevinlee12]

Hi @geetchoudhary, left a comment regarding the padding property, ptal!

[kevinlee12]

Decrease it by 5 px and I think we'll be good

[geetchoudhary]

Done

[kevinlee12]

lgtm, thanks a lot @geetchoudhary!

[geetchoudhary]

Thanks @kevinlee12 😄

[geetchoudhary]

Hi @kevinlee12 , kindly merge. Thanks :)

[kevinlee12]

sorry about that, I thought the maintainer on duty would pick it up.