Enabling Learner for fill out answer details #7159

anubhavsinha98 · 2019-07-17T16:06:05Z

This PR includes the frontend changes, to enable the learner to fill out answer details when he is asked for it.

Explanation

Checklist

The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
The linter/Karma presubmit checks have passed.
- These should run automatically, but if not, you can manually trigger them locally using python scripts/pre_commit_linter.py and bash scripts/run_frontend_tests.sh.
The PR is made from a branch that's not called "develop".
The PR has an appropriate "CHANGELOG: ..." label (If you are unsure of which label to add, ask the reviewers for guidance).
The PR follows the style guide.
The PR addresses the points mentioned in the codeowner checks for the files/folders changed. (See the codeowner's wiki page.)
The PR is assigned to an appropriate reviewer.
- If you're a new contributor, please ask on Gitter for someone to assign a reviewer and don't tick this checkbox.
- If you're not sure who the appropriate reviewer is, please assign to the issue's "owner" -- see the "talk-to" label on the issue. Do not only request the review but also add the reviewer as an assignee.

…o develop

anubhavsinha98 · 2019-08-23T11:06:09Z

Hi @seanlip, made the changes PTAL. I will upload the video soon

anubhavsinha98 · 2019-08-23T17:15:25Z

Video 1
Video 2

anubhavsinha98 · 2019-08-23T17:15:50Z

Hi @seanlip uploaded the video too. PTAL Thanks!

seanlip

Looks good, @anubhavsinha98! Just one more comment and I think it can be merged.

seanlip · 2019-08-23T22:42:51Z

...emplates/dev/head/pages/exploration-player-page/services/learner-answer-info.service.spec.ts

    spyOn(
      mockAnswerClassificationService,
      'getMatchingClassificationResult').and.returnValue(acrof.createNew(
      oof.createNew('default', 'default_outcome', '', []), 2, 0,
      DEFAULT_OUTCOME_CLASSIFICATION));
+    mockAnswer = 'This is my answer';
+    mockInteractionRulesService = 'Sample interaction rules service';


This should be a service, not a string.

Why not just use one of the actual interaction rules services?

seanlip · 2019-08-23T22:45:38Z

Also @nithusha21 PTAL as codeowner. Thanks!

nithusha21

LGTM. Just one question

core/templates/dev/head/domain/statistics/LearnerAnswerDetailsBackendApiServiceSpec.ts

anubhavsinha98 · 2019-08-24T16:27:57Z

Done @seanlip

seanlip · 2019-08-25T03:09:55Z

Apparently this needs a codeowner review from @brianrodri (not sure why this did not show up in GitHub before). @brianrodri could you PTAL?

brianrodri

CODEOWNER LGTM

codician and others added 30 commits November 27, 2018 04:28

First

f115e45

First

28b6e0e

Second

c429cae

Third

83f6a9c

Fourth

9cac86f

Merge branch 'develop' of https://github.com/anubhavsinha98/oppia int…

010e82c

…o develop

Merge branch 'develop' of https://github.com/oppia/oppia into develop

ed6db59

Merge branch 'develop' of https://github.com/oppia/oppia into develop

cd0f299

Merge branch 'develop' of https://github.com/oppia/oppia into develop

a3c44a4

Merge branch 'develop' of https://github.com/oppia/oppia into develop

7276cb1

Merge branch 'develop' of https://github.com/oppia/oppia into develop

e04ff0e

Merge branch 'develop' of https://github.com/oppia/oppia into develop

f566c57

Merge branch 'develop' of https://github.com/oppia/oppia into develop

4913821

Merge branch 'develop' of https://github.com/oppia/oppia into develop

b017a2b

Merge branch 'develop' of https://github.com/oppia/oppia into develop

53f68cd

Merge branch 'develop' of https://github.com/oppia/oppia into develop

892949a

Merge branch 'develop' of https://github.com/oppia/oppia into develop

4aa5e63

Merge branch 'develop' of https://github.com/oppia/oppia into develop

0283d75

Merge branch 'develop' of https://github.com/oppia/oppia into develop

e595522

Merge branch 'develop' of https://github.com/oppia/oppia into develop

21d6944

Merge branch 'develop' of https://github.com/oppia/oppia into develop

46e2322

Merge branch 'develop' of https://github.com/oppia/oppia into develop

3cc076e

Merge branch 'develop' of https://github.com/oppia/oppia into develop

d4df339

Reset

a84476e

Merge branch 'develop' of https://github.com/oppia/oppia into develop

1bce319

Merge branch 'develop' of https://github.com/oppia/oppia into develop

9c75ed5

Merge branch 'develop' of https://github.com/oppia/oppia into develop

4448fdb

Merge branch 'develop' of https://github.com/oppia/oppia into develop

31758f9

Merge branch 'develop' of https://github.com/oppia/oppia into develop

4ec472a

Merge branch 'develop' of https://github.com/oppia/oppia into develop

9826745

Merge branch 'develop' into lais

c480dbd

seanlip assigned anubhavsinha98 and unassigned seanlip Aug 22, 2019

anubhavsinha98 added 2 commits August 23, 2019 02:12

Made the changes

fcadfdc

Made the changes

4878c9b

anubhavsinha98 assigned seanlip and unassigned anubhavsinha98 Aug 23, 2019

seanlip requested changes Aug 23, 2019

View reviewed changes

seanlip assigned nithusha21 and anubhavsinha98 and unassigned seanlip Aug 23, 2019

nithusha21 approved these changes Aug 24, 2019

View reviewed changes

core/templates/dev/head/domain/statistics/LearnerAnswerDetailsBackendApiServiceSpec.ts Show resolved Hide resolved

nithusha21 removed their assignment Aug 24, 2019

anubhavsinha98 added 3 commits August 24, 2019 19:19

Merge branch 'develop' of https://github.com/oppia/oppia into develop

94f34e1

Made the changes

629af50

Merge branch 'develop' into lais

d8748e4

seanlip approved these changes Aug 24, 2019

View reviewed changes

seanlip added the PR: LGTM label Aug 24, 2019

seanlip requested a review from brianrodri August 25, 2019 03:09

seanlip assigned brianrodri Aug 25, 2019

brianrodri approved these changes Aug 25, 2019

View reviewed changes

brianrodri merged commit 4461c72 into oppia:develop Aug 25, 2019

anubhavsinha98 deleted the lais branch August 25, 2019 22:41

sophiewu6 mentioned this pull request Sep 5, 2019

Fixed a bug that raises after submitting an answer in the question player #7551

Merged

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enabling Learner for fill out answer details #7159

Enabling Learner for fill out answer details #7159

anubhavsinha98 commented Jul 17, 2019

anubhavsinha98 commented Aug 23, 2019

anubhavsinha98 commented Aug 23, 2019

anubhavsinha98 commented Aug 23, 2019

seanlip left a comment

seanlip Aug 23, 2019

seanlip commented Aug 23, 2019

nithusha21 left a comment

anubhavsinha98 commented Aug 24, 2019

seanlip commented Aug 25, 2019

brianrodri left a comment

Enabling Learner for fill out answer details #7159

Enabling Learner for fill out answer details #7159

Conversation

anubhavsinha98 commented Jul 17, 2019

Explanation

Checklist

anubhavsinha98 commented Aug 23, 2019

anubhavsinha98 commented Aug 23, 2019

anubhavsinha98 commented Aug 23, 2019

seanlip left a comment

Choose a reason for hiding this comment

seanlip Aug 23, 2019

Choose a reason for hiding this comment

seanlip commented Aug 23, 2019

nithusha21 left a comment

Choose a reason for hiding this comment

anubhavsinha98 commented Aug 24, 2019

seanlip commented Aug 25, 2019

brianrodri left a comment

Choose a reason for hiding this comment