Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Milestone 1.2: Type definitions for midi, skulpt, math expressions #9266

Merged
merged 3 commits into from May 10, 2020
Merged

Milestone 1.2: Type definitions for midi, skulpt, math expressions #9266

merged 3 commits into from May 10, 2020

Conversation

nishantwrp
Copy link
Contributor

@nishantwrp nishantwrp commented May 8, 2020

Overview

1. This PR fixes or fixes part of #[fill_in_number_here]. #6351
2. This PR does the following: Type definitions for midi, skulpt, math expressions

Essential Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The linter/Karma presubmit checks have passed locally on your machine.
  • "Allow edits from maintainers" is checked. (See here for instructions on how to enable it.)
    • This lets reviewers restart your CircleCI tests for you.
  • The PR is made from a branch that's not called "develop".

PR Pointers

  • Oppiabot will notify you when you don't add a PR_CHANGELOG label. If you are unable to do so, please @-mention a code owner (who will be in the Reviewers list), or ask on Gitter.
  • For what code owners will expect, see the Code Owner's wiki page.
  • Make sure your PR follows conventions in the style guide, otherwise this will lead to review delays
  • Never force push. If you do, your PR will be closed.

@oppiabot
Copy link

oppiabot bot commented May 8, 2020

Hi, @nishantwrp. This pull request does not have a "CHANGELOG: ..." label as mentioned in the PR checkbox list. Please add this label. PRs without this label will not be merged. If you are unsure of which label to add, please ask the reviewers for guidance. Thanks!

@oppiabot
Copy link

oppiabot bot commented May 9, 2020

Assigning @vojtechjelinek for the first-pass review of this pull request. Thanks!

@oppiabot
Copy link

oppiabot bot commented May 9, 2020

Assigning @kevinlee12 for the first-pass review of this pull request. Thanks!

Copy link
Member

@vojtechjelinek vojtechjelinek left a comment

LGTM!

@vojtechjelinek vojtechjelinek removed their assignment May 9, 2020
@nishantwrp nishantwrp changed the title Type definitions for midi, skulpt, math expressions Milestone 1.2: Type definitions for midi, skulpt, math expressions May 9, 2020
Copy link
Contributor

@ankita240796 ankita240796 left a comment

LGTM, Thanks @nishantwrp!

@ankita240796 ankita240796 removed their assignment May 9, 2020
@kevinlee12 kevinlee12 merged commit 1ca0cdb into oppia:develop May 10, 2020
13 checks passed
@nishantwrp nishantwrp deleted the midi-skulpt-mathex branch May 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants