New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Milestone 1.2: Type definitions for midi, skulpt, math expressions #9266
Conversation
Hi, @nishantwrp. This pull request does not have a "CHANGELOG: ..." label as mentioned in the PR checkbox list. Please add this label. PRs without this label will not be merged. If you are unsure of which label to add, please ask the reviewers for guidance. Thanks! |
Assigning @vojtechjelinek for the first-pass review of this pull request. Thanks! |
Assigning @kevinlee12 for the first-pass review of this pull request. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks @nishantwrp!
Overview
1. This PR fixes or fixes part of #[fill_in_number_here].#63512. This PR does the following: Type definitions for midi, skulpt, math expressions
Essential Checklist
PR Pointers