Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix part of #7176: Add types for Customization Args #9463

Merged
merged 8 commits into from Jun 12, 2020
Merged

Fix part of #7176: Add types for Customization Args #9463

merged 8 commits into from Jun 12, 2020

Conversation

nishantwrp
Copy link
Contributor

Overview

  1. This PR fixes or fixes part of Add types for Object Factories  #7176
  2. This PR does the following: Add types for Customization Args

Essential Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The linter/Karma presubmit checks have passed locally on your machine.
  • "Allow edits from maintainers" is checked. (See here for instructions on how to enable it.)
    • This lets reviewers restart your CircleCI tests for you.
  • The PR is made from a branch that's not called "develop".

PR Pointers

  • Oppiabot will notify you when you don't add a PR_CHANGELOG label. If you are unable to do so, please @-mention a code owner (who will be in the Reviewers list), or ask on Gitter.
  • For what code owners will expect, see the Code Owner's wiki page.
  • Make sure your PR follows conventions in the style guide, otherwise this will lead to review delays
  • Never force push. If you do, your PR will be closed.

@oppiabot
Copy link

oppiabot bot commented Jun 8, 2020

Hi, @nishantwrp. This pull request does not have a "CHANGELOG: ..." label as mentioned in the PR checkbox list. Please add this label. PRs without this label will not be merged. If you are unsure of which label to add, please ask the reviewers for guidance. Thanks!

@oppiabot
Copy link

oppiabot bot commented Jun 8, 2020

Assigning @bansalnitish for the first-pass review of this pull request. Thanks!

vojtechjelinek
vojtechjelinek requested changes Jun 8, 2020
View reviewed changes
Copy link
Member

@vojtechjelinek vojtechjelinek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just a few comments.

core/templates/services/compute-graph.service.ts Outdated
_computeBfsTraversalOfStates(initStateId: string, states: any,
sourceStateName: string): Array<any> {

_computeBfsTraversalOfStates(initStateId: string, states: States,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

break after (

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

core/templates/services/compute-graph.service.ts Outdated
computeBfsTraversalOfStates(initStateId: string, states: any,
sourceStateName: any): Array<any> {

computeBfsTraversalOfStates(initStateId: string, states: States,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

break after (

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

extensions/interactions/customization-args-defs.ts Outdated
Comment on lines 185 to 192
ICodeReplCustomizationArgs | IContinueCustomizationArgs |
IDragAndDropSortInputCustomizationArgs | IEndExplorationCustomizationArgs |
IFractionInputCustomizationArgs | IGraphInputCustomizationArgs |
IImageClickInputCustomizationArgs | IInteractiveMapCustomizationArgs |
IItemSelectionInputCustomizationArgs | ILogicCustomizationArgs |
IMultipleChoiceInputCustomizationArgs | IMusicNotesInputCustomizationArgs |
IPencilCodeCustomizationArgs | ISetInputCustomizationArgs |
ITextInputCustomizationArgs);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

put every type on a separate line

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@vojtechjelinek
Copy link
Member

@brianrodri, @kevintab95, @ankita240796, @aks681 and @marianazangrossi PTAL

kevintab95
kevintab95 approved these changes Jun 8, 2020
View reviewed changes
Copy link
Member

@kevintab95 kevintab95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for code-owner files. Thanks @nishantwrp!

@kevintab95 kevintab95 removed their assignment Jun 8, 2020
@nishantwrp
Copy link
Contributor Author

@marianazangrossi @brianrodri @aks681 PTAL!

aks681
aks681 approved these changes Jun 9, 2020
View reviewed changes
Copy link
Member

@aks681 aks681 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm as codeowner

@aks681 aks681 removed their assignment Jun 9, 2020
brianrodri
brianrodri suggested changes Jun 9, 2020
View reviewed changes
core/templates/components/state-editor/state-editor-properties-services/state-editor.service.ts Outdated Show resolved Hide resolved
core/templates/components/state-editor/state-editor-properties-services/state-editor.service.ts Outdated Show resolved Hide resolved
core/templates/components/state-editor/state-editor-properties-services/state-editor.service.ts Outdated Show resolved Hide resolved
core/templates/services/extension-tag-assembler.service.ts Show resolved Hide resolved
core/templates/services/improvements.service.spec.ts Show resolved Hide resolved
...ions/interactions/MathExpressionInput/directives/math-expression-input-validation.service.ts Outdated Show resolved Hide resolved
...ions/interactions/MathExpressionInput/directives/math-expression-input-validation.service.ts Outdated Show resolved Hide resolved
...ions/interactions/MultipleChoiceInput/directives/multiple-choice-input-validation.service.ts Show resolved Hide resolved
extensions/interactions/NumericInput/directives/numeric-input-validation.service.ts Outdated Show resolved Hide resolved
extensions/interactions/NumericInput/directives/numeric-input-validation.service.ts Outdated Show resolved Hide resolved
@brianrodri brianrodri assigned nishantwrp and unassigned brianrodri Jun 9, 2020
@nishantwrp nishantwrp assigned brianrodri and unassigned nishantwrp Jun 9, 2020
@brianrodri brianrodri assigned nishantwrp and unassigned brianrodri Jun 9, 2020
@nishantwrp nishantwrp assigned brianrodri and unassigned nishantwrp Jun 9, 2020
@brianrodri brianrodri removed their assignment Jun 9, 2020
@nishantwrp
Copy link
Contributor Author

@marianazangrossi PTAL!

@nishantwrp nishantwrp removed the request for review from marianadasilvadev June 10, 2020 14:36
@kevintab95
Copy link
Member

@nithusha21 PTAL!

@nishantwrp
Copy link
Contributor Author

@nithusha21 ptal!

nithusha21
nithusha21 approved these changes Jun 12, 2020
View reviewed changes
Copy link
Contributor

@nithusha21 nithusha21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as a codeowner!

@nithusha21 nithusha21 merged commit 612b181 into oppia:develop Jun 12, 2020
@nishantwrp nishantwrp deleted the any-type-6 branch June 12, 2020 14:21
shavavo pushed a commit to shavavo/oppia that referenced this pull request Aug 20, 2020
@nishantwrp
Fix part of oppia#7176: Add types for Customization Args (oppia#9463)
2b8f06b 
* Add types for Customization Args

* Copyright Notice

* Reviews

* lint tests

* reviews

* reviews

* reviews
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianrodri brianrodri brianrodri approved these changes

@vojtechjelinek vojtechjelinek vojtechjelinek approved these changes

@kevintab95 kevintab95 kevintab95 approved these changes

@nithusha21 nithusha21 nithusha21 approved these changes

@ankita240796 ankita240796 ankita240796 approved these changes

@aks681 aks681 aks681 approved these changes

Assignees

@nithusha21 nithusha21

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@nishantwrp @vojtechjelinek @kevintab95 @brianrodri @nithusha21 @ankita240796 @aks681 @bansalnitish @marianadasilvadev