Fix #236 and #313: Remove unnecessary comment about modifications to codeowner file; notify server admins about changes to files in jobs and platform folders. #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanlip
approved these changes
Jul 31, 2023
There was a problem hiding this comment.
Thanks @vojtechjelinek! Just a couple small comments, otherwise LGTM.
lib/checkPullRequestJob.js
Outdated
| plural: 'jobs' | ||
| }, | ||
| JOB_REGEX | ||
| const fileChangesShouldBeVerified = (filename) => { |
There was a problem hiding this comment.
Suggest shouldFileChangesBeVerified (start with a "verb")
spec/checkNewCronJobSpec.js
Outdated
| @@ -517,4 +516,4 @@ describe('Cron Job Spec', () => { | |||
| expect(github.issues.createComment).not.toHaveBeenCalled(); | |||
| }); | |||
| }); | |||
| }); | |||
| }); | |||
seanlip
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Fix #236: Remove the comment about modifications to codeowner file as it is unnecessary.
Fix #313: Notify server admins about any changes to non-test files in jobs and platform folders.
Checklist