-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor recommendation packages #2910
refactor recommendation packages #2910
Conversation
🦋 Changeset detectedLatest commit: 5996c15 The changes in this PR will be included in the next version bump. This PR includes changesets to release 17 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…adge in README.md
…stem compatibility badge
…s-sell-ninja-in-sherlock
…herl-2-cross-sell-ninja-in-sherlock
…s-sell-ninja-in-sherlock
@LorisSigrist | @NiklasBuchfink, please review this for your apps and see if everything regarding the recommendations is working correctly? @LorisSigrist I went for a patch change, but we should potentially do a minor one. Furthermore, I changed the package names. If I remember correctly, you already did this with the paraglide packages. Do you know if I have to look after something regarding npm publishing? |
We should probably do a "minor" patch for packages using it, as "patch" changes are usually not taken as seriously by module-resolvers. As for the renaming: I don't think anything is going to break, but i would mark the old packages as depreciated on npm via the npm cli |
…on in ninja.test.ts
In his PR, we
cross-sell-X
packages torecommend-X
to be more descriptiveshouldRecommend
function to@inlang/recommend-sherlock
&@inlang/recommend-ninja
cc @NiklasBuchfink needs your review after I'm done.