Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: old neu file passing #3059

Merged
merged 9 commits into from
Aug 13, 2024
Merged

fix: old neu file passing #3059

merged 9 commits into from
Aug 13, 2024

Conversation

samuelstroschein
Copy link
Member

Context

Closes opral/lix-sdk#33 and likely also closes opral/lix-sdk#34.

Changes

  1. Fix the argument order of handle_file_change
  2. Workaround for awaiting written changes to SQlite. See the changes to inithandleChangesToLix.
  3. Deactivate query getParent() as the query crashes and is not important for now.

Additional info

This is a workaround to unblock Fink2. Should be refactored in the future to handle inlang sdk changes to lix without a setTimeout.

Copy link

changeset-bot bot commented Aug 12, 2024

⚠️ No Changeset found

Latest commit: 476fd8e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@samuelstroschein
Copy link
Member Author

Confirmed. Fixes both bugs.

@janfjohannes feel free to merge

cc @NilsJacobsen @NiklasBuchfink

CleanShot.2024-08-12.at.18.33.16.mp4

@janfjohannes janfjohannes merged commit 59ce2ed into lix-integration Aug 13, 2024
2 checks passed
@janfjohannes janfjohannes deleted the samuel/fix-old-neu branch August 13, 2024 11:45
@github-actions github-actions bot locked and limited conversation to collaborators Aug 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants