Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update example config script #1125

Merged
merged 1 commit into from
Oct 4, 2019

Conversation

jos3p
Copy link
Contributor

@jos3p jos3p commented Oct 4, 2019

Description

  • core modules and their .md files (connectors/databases) are read first and modules with the same name get ignored if found in opsdroid/ (should work if more modules get into core)
  • no longer listing skills twice as un/commented
  • generated and included new example_configuration.yaml built with the new version of the script
  • removed shell from default modules (mentioned in the issue)
  • fixed "yaml.load() without loader=... is deprecated" warning

Fixes #1019

Status

READY

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

  • tox (docker fails cause permissions?) [fresh ubuntu 19]
    py36/py37/lint commands succeeded
  • built the new example cfg
  • tested building+running dockerimage myself

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@codecov
Copy link

codecov bot commented Oct 4, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@2b04dab). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1125   +/-   ##
=========================================
  Coverage          ?   99.91%           
=========================================
  Files             ?       46           
  Lines             ?     2489           
  Branches          ?        0           
=========================================
  Hits              ?     2487           
  Misses            ?        2           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b04dab...5758c14. Read the comment docs.

Copy link
Member

@FabioRosado FabioRosado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for working on this issue I've reviewed your changes and I'm happy with them 😄

We love to thank contributors by sending them opsdroid stickers! Fill in the claim form to get yours!

@FabioRosado FabioRosado merged commit dcde2f8 into opsdroid:master Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update example config script
3 participants