Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix travis build validation issues #1358

Merged
merged 4 commits into from
Feb 10, 2020

Conversation

FabioRosado
Copy link
Member

@FabioRosado FabioRosado commented Feb 8, 2020

Description

I decided to try and figure out why the mock update was failing on the cli tools so I was checking the travis and noticed there was some validation issues, this PR aims to update travis.yml and fix these issues.

I don't think this will make much of a difference since everything seems to be working anyway other than the skip_cleanup param. Let me know if you think we should update travis or just do it together with another PR 😄 👍

Fixes #

Status

READY | UNDER DEVELOPMENT | ON HOLD

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Tox all green

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@codecov
Copy link

codecov bot commented Feb 8, 2020

Codecov Report

Merging #1358 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1358   +/-   ##
======================================
  Coverage    99.9%   99.9%           
======================================
  Files          52      52           
  Lines        3047    3047           
======================================
  Hits         3044    3044           
  Misses          3       3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 806220e...cdc45c3. Read the comment docs.

Copy link
Member

@jacobtomlinson jacobtomlinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thanks!

@FabioRosado FabioRosado merged commit a03ae49 into opsdroid:master Feb 10, 2020
@FabioRosado FabioRosado deleted the update-mock branch February 10, 2020 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants