Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed to self.opsdroid.send #1584

Merged
merged 1 commit into from
Jul 17, 2020
Merged

Changed to self.opsdroid.send #1584

merged 1 commit into from
Jul 17, 2020

Conversation

tctovsli
Copy link
Contributor

@tctovsli tctovsli commented Jul 17, 2020

Description

Fixes example in documentation.

Status

READY

Type of change

  • Documentation (fix or adds documentation)

How Has This Been Tested?

Not tested.

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@codecov
Copy link

codecov bot commented Jul 17, 2020

Codecov Report

Merging #1584 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1584   +/-   ##
=======================================
  Coverage   99.91%   99.91%           
=======================================
  Files          53       53           
  Lines        3335     3335           
=======================================
  Hits         3332     3332           
  Misses          3        3           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a50e0d...fd78ac0. Read the comment docs.

Copy link
Member

@FabioRosado FabioRosado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @tctovsli thank you for opening this PR and spotting the issue on the documentation. I guess when we changed things with the class based skills some things got forgotten like this one. 👍

@FabioRosado FabioRosado merged commit 1aa5100 into opsdroid:master Jul 17, 2020
@tctovsli tctovsli deleted the patch-2 branch July 17, 2020 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants