Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change helper message to more accurately reflect reality; add link to… #1598

Merged
merged 2 commits into from
Jul 30, 2020
Merged

Change helper message to more accurately reflect reality; add link to… #1598

merged 2 commits into from
Jul 30, 2020

Conversation

law
Copy link
Contributor

@law law commented Jul 28, 2020

Description

Fixes #1597

Status

READY

Type of change

  • Documentation (fix or adds documentation)

How Has This Been Tested?

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@codecov
Copy link

codecov bot commented Jul 28, 2020

Codecov Report

Merging #1598 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1598   +/-   ##
=======================================
  Coverage   99.88%   99.88%           
=======================================
  Files          53       53           
  Lines        3343     3343           
=======================================
  Hits         3339     3339           
  Misses          4        4           
Impacted Files Coverage Δ
opsdroid/helper.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6495f75...90248d5. Read the comment docs.

Copy link
Member

@FabioRosado FabioRosado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again thank you for both raising the issue and the PR to fix this.

I am happy with the changes, and the CI failure doesn't have to do with this PR so I'll merge it as soon as possible 😄 👍

@FabioRosado FabioRosado merged commit f3c1896 into opsdroid:master Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configuration validator warning could be more useful + accurate
2 participants