Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate gitter tests to pytest #1800

Merged
merged 3 commits into from
Jul 18, 2021

Conversation

jacobtomlinson
Copy link
Member

@jacobtomlinson jacobtomlinson commented Jul 18, 2021

Description

Migrated Gitter tests to pytest.

  • Moved connector code out of __init__.py.
  • Moved tests into opsdroid/connector/gitter/tests.
  • Rewrote in pytest.
  • Used new test machinery.

Related to #1502

Status

READY

Type of change

  • Hygiene

Checklist:

  • I have performed a self-review of my own code
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@codecov
Copy link

codecov bot commented Jul 18, 2021

Codecov Report

Merging #1800 (f99d11d) into master (d890de2) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1800      +/-   ##
==========================================
- Coverage   99.28%   99.28%   -0.01%     
==========================================
  Files          77       78       +1     
  Lines        4634     4633       -1     
==========================================
- Hits         4601     4600       -1     
  Misses         33       33              
Impacted Files Coverage Δ
opsdroid/connector/gitter/__init__.py 100.00% <100.00%> (ø)
opsdroid/connector/gitter/connector.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d890de2...f99d11d. Read the comment docs.

@jacobtomlinson jacobtomlinson merged commit cc45e5a into opsdroid:master Jul 18, 2021
@jacobtomlinson jacobtomlinson deleted the gitter-tests-rewrite branch July 18, 2021 21:21
Dissonant-Tech pushed a commit to Dissonant-Tech/opsdroid that referenced this pull request Aug 12, 2021
* Migrate gitter tests to pytest

* Whoops removed a useful import

* Remove attribute error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant